public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: DJ Delorie <dj@redhat.com>, Eli Zaretskii <eliz@gnu.org>
Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: MinGW compilation warnings in libiberty's xstrndup.c
Date: Fri, 19 May 2017 22:31:00 -0000	[thread overview]
Message-ID: <38b0f9f9-4189-eff9-4962-beb5043e87c3@redhat.com> (raw)
In-Reply-To: <xnd1b4ik8l.fsf@greed.delorie.com>

On 05/19/2017 10:56 PM, DJ Delorie wrote:
> 
> Eli Zaretskii <eliz@gnu.org> writes:
>> It should use HAVE_STRNLEN instead, because that's the only
>> strnlen-related macro defined in config.g when strnlen is probed by
>> the configure script.
> 
> Ah, but gcc's configure defines HAVE_DECL_STRNLEN.  Header guards need
> to be coordinated across all the users, not just libiberty.
> 

The "user" in this case is libiberty itself.

Thanks,
Pedro Alves

  reply	other threads:[~2017-05-19 22:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08 15:37 Eli Zaretskii
2017-05-19 15:27 ` Pedro Alves
2017-05-19 15:47   ` Eli Zaretskii
2017-05-19 16:08     ` Pedro Alves
2017-05-19 22:28 ` DJ Delorie
2017-05-19 22:31   ` Pedro Alves [this message]
2017-05-19 22:56     ` DJ Delorie
2017-05-19 23:22       ` Pedro Alves
2017-05-20  1:25         ` DJ Delorie
2017-05-22 16:28           ` Pedro Alves
2017-05-26 21:49 ` DJ Delorie
2017-05-28 18:31   ` Eli Zaretskii
2017-05-31  6:17     ` DJ Delorie
2017-05-31  6:55       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38b0f9f9-4189-eff9-4962-beb5043e87c3@redhat.com \
    --to=palves@redhat.com \
    --cc=dj@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).