From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70002 invoked by alias); 19 May 2017 22:28:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69982 invoked by uid 89); 19 May 2017 22:28:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*i:sk:xnd1b4i, H*MI:sk:xnd1b4i, H*f:sk:xnd1b4i X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 May 2017 22:28:33 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A928624CF; Fri, 19 May 2017 22:28:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7A928624CF Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7A928624CF Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2D54674ACD; Fri, 19 May 2017 22:28:32 +0000 (UTC) Subject: Re: MinGW compilation warnings in libiberty's xstrndup.c To: DJ Delorie , Eli Zaretskii References: Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org From: Pedro Alves Message-ID: <38b0f9f9-4189-eff9-4962-beb5043e87c3@redhat.com> Date: Fri, 19 May 2017 22:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg01619.txt.bz2 On 05/19/2017 10:56 PM, DJ Delorie wrote: > > Eli Zaretskii writes: >> It should use HAVE_STRNLEN instead, because that's the only >> strnlen-related macro defined in config.g when strnlen is probed by >> the configure script. > > Ah, but gcc's configure defines HAVE_DECL_STRNLEN. Header guards need > to be coordinated across all the users, not just libiberty. > The "user" in this case is libiberty itself. Thanks, Pedro Alves