From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 31A593858D3C for ; Mon, 24 Jan 2022 10:09:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 31A593858D3C Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id CF37F1F38B; Mon, 24 Jan 2022 10:09:23 +0000 (UTC) Received: from murzim.suse.de (murzim.suse.de [10.160.4.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id ABE32A3B93; Mon, 24 Jan 2022 10:09:23 +0000 (UTC) Date: Mon, 24 Jan 2022 11:09:23 +0100 (CET) From: Richard Biener To: Jakub Jelinek cc: Jeff Law , =?ISO-8859-15?Q?Martin_Li=A8ka?= , gcc-patches@gcc.gnu.org, soeren@soeren-tempel.net Subject: Re: [PATCH] Disable -fsplit-stack support on non-glibc targets In-Reply-To: <20220124093332.GJ2646553@tucnak> Message-ID: <38or2193-386-p15-s9sr-sorp5srq1rp@fhfr.qr> References: <20211218104317.23622-1-soeren@soeren-tempel.net> <463eb1a5-bdfb-62e0-023f-d7f9438cf0a4@suse.cz> <20220122121638.GX2646553@tucnak> <20220122180348.GZ2646553@tucnak> <20220124093332.GJ2646553@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2022 10:09:27 -0000 On Mon, 24 Jan 2022, Jakub Jelinek wrote: > On Sat, Jan 22, 2022 at 07:03:48PM +0100, Jakub Jelinek via Gcc-patches wrote: > > On Sat, Jan 22, 2022 at 01:16:38PM +0100, Jakub Jelinek via Gcc-patches wrote: > > > Actually, I suspect we either need something like following patch, > > > or need to change gcc/config/{linux,rs6000/linux{,64},alpha/linux}.h > > > so that next to those OPTION_GLIBC etc. macros it also defines versions > > > of those macros with opts argument. > > > > And here is a larger but perhaps cleaner patch that matches how e.g. > > options.h defines TARGET_WHATEVER_P(opts) options and then TARGET_WHATEVER > > too. > > > > Only compile tested on x86_64-linux so far. > > Bootstrapped/regtested on x86_64-linux and i686-linux now, ok for trunk? OK. Thanks, Richard. > > 2022-01-22 Jakub Jelinek > > > > * config/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P, > > OPTION_BIONIC_P, OPTION_MUSL_P): Define. > > (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine > > using OPTION_*_P macros. > > * config/alpha/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P, > > OPTION_BIONIC_P, OPTION_MUSL_P): Define. > > (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine > > using OPTION_*_P macros. > > * config/rs6000/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P, > > OPTION_BIONIC_P, OPTION_MUSL_P): Define. > > (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine > > using OPTION_*_P macros. > > * config/rs6000/linux64.h (OPTION_GLIBC_P, OPTION_UCLIBC_P, > > OPTION_BIONIC_P, OPTION_MUSL_P): Define. > > (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine > > using OPTION_*_P macros. > > * config/fuchsia.h (OPTION_MUSL_P): Redefine. > > * config/glibc-stdint.h (OPTION_MUSL_P): Define if not defined. > > * common/config/s390/s390-common.cc (s390_supports_split_stack): Re-add > > ATTRIBUTE_UNUSED to opts parameter. If OPTION_GLIBC_P is defined, use > > OPTION_GLIBC_P (opts) as condition, otherwise assume if (false). > > * common/config/i386/i386-common.cc (ix86_supports_split_stack): If > > OPTION_GLIBC_P is defined use !OPTION_GLIBC_P (opts) as condition, > > otherwise assume if (true). > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany; GF: Ivo Totev; HRB 36809 (AG Nuernberg)