From mboxrd@z Thu Jan 1 00:00:00 1970 From: grahams To: Jan Hubicka Cc: gcc-patches@gcc.gnu.org Subject: Re: Date: Mon, 24 Apr 2000 05:29:00 -0000 Message-id: <39043D4B.196AF7E5@rcp.co.uk> References: <200004180508.BAA08466@jwlab.FEITH.COM> <20000423104611.B6170@atrey.karlin.mff.cuni.cz> X-SW-Source: 2000-04/msg00935.html Jan Your last checkin to loop.c (revision 1.243) contains a typo. The typo is indicated in this extract from your patch note your change reversed the test from "not insn" to "is insn". @@ -4124,13 +4123,13 @@ for (next = NEXT_INSN (dominator); ; next = NEXT_INSN (next)) { - if ((GET_RTX_CLASS (GET_CODE (next)) == 'i' + if ((INSN_P (next) && (reg_mentioned_p (giv, PATTERN (next)) || reg_set_p (bl2->biv->src_reg, next))) || GET_CODE (next) == JUMP_INSN) break; #ifdef HAVE_cc0 - if (GET_RTX_CLASS (GET_CODE (next)) != 'i' + if (INSN_P (next) ^^^^ typo this should be ! INSN_P (next) || ! sets_cc0_p (PATTERN (next))) #endif dominator = next; Graham