From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4FA75385840D for ; Tue, 23 Apr 2024 20:02:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4FA75385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4FA75385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713902542; cv=none; b=ixp3GzqMiEoikZJF25vTeK7bJjzNPuatSbOMbiDNJP1Qkb7pyrv8uP6m3/uOy3x1jIr6WawkEVR5N/DrMnHv3kYlYQkRB4W/jtAVToQkRiQire9bzcrX3u7+iVEQmb1JXU1GanMVsms01VlMLFZBlmUhX5ofAJVQf0K9bdJPOo4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713902542; c=relaxed/simple; bh=fUAz6DoIKZc7wdmQjo5yuhQHYKfQvIqDm64bCcEu+Xg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=d/UlF3g8fT45TCqvRu+o+6YrqVDoNoK0wSeWkGcntt9tfi8Tpzslv7zzeJjRTm/46aJ4hymTowpR48FkfCWOHel0U3+IGVJ9zhL5M7bFm1hmF3OVK6ksbb8E0o61boPOYre3z962+EGSj19AE1kyvn19Q5ao8ahE03L4+YKkjug= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713902537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ue3WHU6as+PMc6wMZwR/EfQO/u+Ik432Ao3XA+OznA=; b=Lpfrjn18C9GGbyWovhpJ8qHrpJ2fn2HGM2VT/MUXcBKlX5mSwx38OdnnywfJSBil+LXAJK +L1QEGMdmyBkdsDZ155KC1bAl5zi74h1CCmq6PlHjCoUSCzWvwc44Ti0BsxRNQqWNZIU2w 6fN9d3ytshIqnnI0A9Qhe6M5O4wDZ1o= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-BeQbUv9ZOW6B5ArXcwzwWQ-1; Tue, 23 Apr 2024 16:02:15 -0400 X-MC-Unique: BeQbUv9ZOW6B5ArXcwzwWQ-1 Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-3c5f316d1ffso8009674b6e.3 for ; Tue, 23 Apr 2024 13:02:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713902534; x=1714507334; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8ue3WHU6as+PMc6wMZwR/EfQO/u+Ik432Ao3XA+OznA=; b=fckBqayEpNuWa0mwSziShou+1auQndD9O3M+rY2OAz9GhvO/LxSotniAGTfXMTCxNJ 1CcUcQTDzzgS1TOaAywlbkwDGzSNBMTbsAz6bESCVlwxS0GpllQh+JzrQ5SoYQpyR/7m Apjv2wPsaWbDkZiHYn7y9vH4peu16+NvXQtJquXbIutMuWdXkzAVxOUc3eqMoU+WBfYv 3ryUiorktkFxPaXXjoiJ6wAVSV4Sl14JKJEEj8EflzYOPAoJ/jl8FH0K1FkkpMnPZ8vE rq+awyFvAf9+mEORxc0+af1dj9KgP5NWB+d3iWi0tUTXYK8ZYRkpd6bd6DKAX68R+9Ao k9AA== X-Forwarded-Encrypted: i=1; AJvYcCXjPtg2PhKAVlk9peQIjM7uDbhJkUPtK4+NWElJ6U9sqvQFXEcfYXqCmNdH2Mi+7XVQUAGzaPeVm+TgM9vQVAzypTqUhpxnSg== X-Gm-Message-State: AOJu0YxAJFifg7DmoDcjOVWRUYf/vJl6TCSwX1jwQ5zirZJE7r8Kw91S NoHCqeHkRHx0QQdC2l/v8rVtsDKR4iY+pXp9xc9mHLYU/Z3GHzbiw0d+yo6oEm4Q+rZjFRDcr+U puhZfbWT2plmwF6j8XVXM0FGBQPKANlcnKJ5rSm8h58TgQbYaYekWNvhofOse2JQ= X-Received: by 2002:a05:6808:278f:b0:3c8:42c9:3232 with SMTP id es15-20020a056808278f00b003c842c93232mr53249oib.4.1713902534146; Tue, 23 Apr 2024 13:02:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9+guT8vHlmR0A9VJ5iBgJ07tGvtxk5yUWkhU/kVl7krkDT8KQn+eyTUN6kbX055ZtBAAnXQ== X-Received: by 2002:a05:6808:278f:b0:3c8:42c9:3232 with SMTP id es15-20020a056808278f00b003c842c93232mr53230oib.4.1713902533918; Tue, 23 Apr 2024 13:02:13 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id xx24-20020a05620a5d9800b0078f1583f724sm4869753qkn.59.2024.04.23.13.02.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 13:02:13 -0700 (PDT) Message-ID: <3942edcf-3aea-46c3-891a-6a7a8dafb8b0@redhat.com> Date: Tue, 23 Apr 2024 16:02:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] c++/modules testsuite: avoid expensive ggc-min-expand=0 To: Patrick Palka , gcc-patches@gcc.gnu.org References: <20240423182814.3195778-1-ppalka@redhat.com> From: Jason Merrill In-Reply-To: <20240423182814.3195778-1-ppalka@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/23/24 11:28, Patrick Palka wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? Is the test being run for multiple standard levels? I'd rather restrict it to one and keep fully testing GC-safety. > -- >8 -- > > The below testcase uses --param=ggc-min-expand=0 which forces a full GC > during every collection point and in turn takes over two minutes to run > and ends up being the main bottleneck of the modules.exp testsuite. > > This patch speeds up this test without (hopefully) significantly affecting > its coverage by using =1 instead of =0 which forces a full GC each time the > heap grows by 1%, which means exponentially fewer GCs. After this patch > the modules.exp testsuite finishes in 2m55s instead of 3m40s with -j8 on > my machine. > > gcc/testsuite/ChangeLog: > > * g++.dg/modules/pr99023_a.X: Use ggc-min-expand=1 instead of =0. > * g++.dg/modules/pr99023_b.X: Likewise. > --- > gcc/testsuite/g++.dg/modules/pr99023_a.X | 2 +- > gcc/testsuite/g++.dg/modules/pr99023_b.X | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/g++.dg/modules/pr99023_a.X b/gcc/testsuite/g++.dg/modules/pr99023_a.X > index c872d15f792..96bb4a2ab5a 100644 > --- a/gcc/testsuite/g++.dg/modules/pr99023_a.X > +++ b/gcc/testsuite/g++.dg/modules/pr99023_a.X > @@ -1,5 +1,5 @@ > // PR c++/99023, ICE > -// { dg-additional-options {-x c++-system-header initializer_list -fmodules-ts --param ggc-min-expand=0} } > +// { dg-additional-options {-x c++-system-header initializer_list -fmodules-ts --param ggc-min-expand=1} } > > // { dg-prune-output {linker input file unused} } > > diff --git a/gcc/testsuite/g++.dg/modules/pr99023_b.X b/gcc/testsuite/g++.dg/modules/pr99023_b.X > index ca5f32e5bcc..955378ad88f 100644 > --- a/gcc/testsuite/g++.dg/modules/pr99023_b.X > +++ b/gcc/testsuite/g++.dg/modules/pr99023_b.X > @@ -1,5 +1,5 @@ > // PR c++/99023, ICE > -// { dg-additional-options {-x c++-system-header iostream -fmodules-ts -flang-info-include-translate= --param ggc-min-expand=0} } > +// { dg-additional-options {-x c++-system-header iostream -fmodules-ts -flang-info-include-translate= --param ggc-min-expand=1} } > > // { dg-prune-output {linker input file unused} } >