From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24568 invoked by alias); 9 Aug 2017 08:21:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9962 invoked by uid 89); 9 Aug 2017 08:21:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Aug 2017 08:21:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C26E42B; Wed, 9 Aug 2017 01:21:20 -0700 (PDT) Received: from [192.168.1.19] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ED12F3F483; Wed, 9 Aug 2017 01:21:19 -0700 (PDT) Subject: Re: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary To: Michael Collison , "gcc-patches@gcc.gnu.org" Cc: nd References: <363725a3-b677-85ac-d4d2-95277dbbc524@arm.com> From: "Richard Earnshaw (lists)" Message-ID: <39661db3-4089-9d69-119e-3716814c4fc5@arm.com> Date: Wed, 09 Aug 2017 08:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00648.txt.bz2 On 09/08/17 06:25, Michael Collison wrote: > Because the comment (for example) in g+=.dg/ext/packed8.C says > > // NOTE: This test assumes packed structure layout differs from unpacked > // structure layout. This isn't true, e.g., with the default > // arm-none-elf options. > > If we could just delete the -mstructure-size-boundary=8 option why was it added in the first place? > Because the comment it out of date. It was added at a time when the default structure size boundard (pre eabi) was 32. R. > -----Original Message----- > From: Richard Earnshaw (lists) [mailto:Richard.Earnshaw@arm.com] > Sent: Monday, August 7, 2017 5:32 AM > To: Michael Collison ; gcc-patches@gcc.gnu.org > Cc: nd > Subject: Re: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary > > On 06/08/17 00:25, Michael Collison wrote: >> This patch fixes test case failures on arm targets due to '-mstructure-size-boundary' being deprecated. The test cases were failing because a warning was being issued and due to the fact that the size of packed and unpacked structures is the same after deprecating '-mstructure-size-boundary' >> >> Okay for trunk? >> >> 2017-08-04 Michael Collison >> >> * testsuite/g++.dg/ext/packed8.C: Skip test for arm_eabi. >> * testsuite/g++.dg/init/array16.C: Skip test for arm_eabi. >> * testsuite/g++.dg/other/crash-4.C: Skip test for arm_eabi. >> * testsuite/gcc.dg/builtin-stringop-chk-1.c: Skip test for arm_eabi. >> > > Why would we want to skip the test? If you delete the -mstructure-size-boundary option then the test should execute correctly on all arm-eabi based platforms and most other ARM platforms where 8 was the default anyway. > > R. > >> >> pr7519v1.patch >> >> >> diff --git a/gcc/testsuite/g++.dg/ext/packed8.C >> b/gcc/testsuite/g++.dg/ext/packed8.C >> index 91ee8b3..4f38670 100644 >> --- a/gcc/testsuite/g++.dg/ext/packed8.C >> +++ b/gcc/testsuite/g++.dg/ext/packed8.C >> @@ -2,7 +2,7 @@ >> // NOTE: This test assumes packed structure layout differs from unpacked >> // structure layout. This isn't true, e.g., with the default >> // arm-none-elf options. >> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } } >> +// { dg-skip-if "packed structure layout does not differ from >> +unpacked layout" { { arm*-*-* } && { arm_eabi } } } >> >> class A >> { >> diff --git a/gcc/testsuite/g++.dg/init/array16.C >> b/gcc/testsuite/g++.dg/init/array16.C >> index 188d1a8..3334e25 100644 >> --- a/gcc/testsuite/g++.dg/init/array16.C >> +++ b/gcc/testsuite/g++.dg/init/array16.C >> @@ -1,7 +1,7 @@ >> // Causes timeout for the MMIX simulator on a 3GHz P4 and we can't >> // have "compile" for some targets and "run" for others. >> // { dg-do run { target { ! mmix-*-* } } } -// { dg-options >> "-mstructure-size-boundary=8" { target arm*-*-* } } >> +// { dg-skip-if "packed structure layout does not differ from >> +unpacked layout" { { arm*-*-* } && { arm_eabi } } } >> >> // Copyright (C) 2004 Free Software Foundation, Inc. >> // Contributed by Nathan Sidwell 8 Dec 2004 >> diff --git a/gcc/testsuite/g++.dg/other/crash-4.C >> b/gcc/testsuite/g++.dg/other/crash-4.C >> index a77fe05..8530f44 100644 >> --- a/gcc/testsuite/g++.dg/other/crash-4.C >> +++ b/gcc/testsuite/g++.dg/other/crash-4.C >> @@ -7,7 +7,7 @@ >> // NOTE: This test assumes packed structure layout differs from unpacked >> // structure layout. This isn't true, e.g., with the default >> // arm-none-elf options. >> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } } >> +// { dg-skip-if "packed structure layout does not differ" { { >> +arm*-*-* } && { arm_eabi } } } >> >> struct a >> { >> diff --git a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c >> b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c >> index e265578..d839097 100644 >> --- a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c >> +++ b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c >> @@ -2,7 +2,7 @@ >> are emitted properly. */ >> /* { dg-do compile } */ >> /* { dg-options "-O2 -Wno-format -std=gnu99 >> -ftrack-macro-expansion=0" } */ >> -/* { dg-additional-options "-mstructure-size-boundary=8" { target >> arm*-*-* } } */ >> +// { dg-skip-if "packed structure layout does not differ from >> +unpacked layout" { { arm*-*-* } && { arm_eabi } } } >> // { dg-skip-if "packed attribute missing for t" { "epiphany-*-*" } } >> >> extern void abort (void); >> >