[PATCH][Revised] Fix PR66509

[PATCH][Revised] Fix PR66509

[Jack Howarth]

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

  The attached revised patch adjusts the tests for the filds and fists
mnemonics to use the assembly...

filds (%ebp); fists (%ebp)

and the test for the fildq and fistq mnemonics to use the assembly...

fildq (%ebp); fistpq (%ebp)

which will assemble for both 64-bit and 32-bit mode. This is required
to avoid "ambiguous instructions require an explicit suffix" errors
from the clang-based assembler in Xcode 7. The change also has the
side-benefit of allowing the legacy GNU assembler from Xcode 6.3 or
earlier to properly detect that the filds, fists, fildq and fistq
mnemonics are available on x86_64-apple-darwin. Bootstrapped tested on
x86_64-apple-darwin14 against the Apple Inc version cctools-870, GNU
assembler version 1.38 and on x86_64-apple-darwin15 against the new
clang-based assembler.
        Okay for gcc trunk?
                   Jack
ps Also confirmed with 'as -32' and 'as -64' on x86_64 Fedora.

[-- Attachment #2: PR66509_v2.patch --]
[-- Type: application/octet-stream, Size: 912 bytes --]

2015-06-26  Jack Howarth  <howarth.at.gcc@gmail.com>

	PR target/66509
	* configure.ac: Fix filds and fildq test for 64-bit.
	* configure: Regenerated.

 
Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac	(revision 225011)
+++ gcc/configure.ac	(working copy)
@@ -3885,13 +3885,13 @@ foo:	nop
 
     gcc_GAS_CHECK_FEATURE([filds and fists mnemonics],
        gcc_cv_as_ix86_filds,,,
-       [filds mem; fists mem],,
+       [filds (%ebp); fists (%ebp)],,
        [AC_DEFINE(HAVE_AS_IX86_FILDS, 1,
          [Define if your assembler uses filds and fists mnemonics.])])
 
     gcc_GAS_CHECK_FEATURE([fildq and fistpq mnemonics],
        gcc_cv_as_ix86_fildq,,,
-       [fildq mem; fistpq mem],,
+       [fildq (%ebp); fistpq (%ebp)],,
        [AC_DEFINE(HAVE_AS_IX86_FILDQ, 1,
          [Define if your assembler uses fildq and fistq mnemonics.])])
 

Re: [PATCH][Revised] Fix PR66509

[H.J. Lu]

On Fri, Jun 26, 2015 at 9:09 AM, Jack Howarth <howarth.at.gcc@gmail.com> wrote:
>   The attached revised patch adjusts the tests for the filds and fists
> mnemonics to use the assembly...
>
> filds (%ebp); fists (%ebp)
>
> and the test for the fildq and fistq mnemonics to use the assembly...
>
> fildq (%ebp); fistpq (%ebp)
>
> which will assemble for both 64-bit and 32-bit mode. This is required
> to avoid "ambiguous instructions require an explicit suffix" errors
> from the clang-based assembler in Xcode 7. The change also has the
> side-benefit of allowing the legacy GNU assembler from Xcode 6.3 or
> earlier to properly detect that the filds, fists, fildq and fistq
> mnemonics are available on x86_64-apple-darwin. Bootstrapped tested on
> x86_64-apple-darwin14 against the Apple Inc version cctools-870, GNU
> assembler version 1.38 and on x86_64-apple-darwin15 against the new
> clang-based assembler.
>         Okay for gcc trunk?
>                    Jack
> ps Also confirmed with 'as -32' and 'as -64' on x86_64 Fedora.

fildq (%ebp); fistpq (%ebp)  are valid for GNU assembler.

-- 
H.J.

Re: [PATCH][Revised] Fix PR66509

[Mike Stump]

On Jun 26, 2015, at 9:09 AM, Jack Howarth <howarth.at.gcc@gmail.com> wrote:
>  The attached revised patch adjusts the tests for the filds and fists
> mnemonics to use the assembly...
> 
> filds (%ebp); fists (%ebp)
> 
> and the test for the fildq and fistq mnemonics to use the assembly...
> 
> fildq (%ebp); fistpq (%ebp)
> 
> which will assemble for both 64-bit and 32-bit mode. This is required
> to avoid "ambiguous instructions require an explicit suffix" errors
> from the clang-based assembler in Xcode 7. The change also has the
> side-benefit of allowing the legacy GNU assembler from Xcode 6.3 or
> earlier to properly detect that the filds, fists, fildq and fistq
> mnemonics are available on x86_64-apple-darwin. Bootstrapped tested on
> x86_64-apple-darwin14 against the Apple Inc version cctools-870, GNU
> assembler version 1.38 and on x86_64-apple-darwin15 against the new
> clang-based assembler.
>        Okay for gcc trunk?

Ok.