From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id D2E663858CD1 for ; Wed, 20 Dec 2023 18:57:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D2E663858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D2E663858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703098639; cv=none; b=RjfrYz4ZjOXm2iXyUeNFSdcoZe7ehCaYkgkjC/qUf3l7WOgO+Dj24KwZpidqqjU9Op+waWjRQR2Gcn+Bp8WhIjwpjqtpX3QLBoB/9W1ezT6KdWG04LfsV9FNu69RX933P/OATWITCdo3wt5z7CijfetC7BVTa4OQNdGGLgVG128= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703098639; c=relaxed/simple; bh=OVhmjai0xNzWcyyEFH+PNZWHVkkvF/hlWlHjBc01Ax8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=iVEvQSWZuZkPKp31xTSwy5RAN2ZIlHNzSIbWOgmLScPWW6jfTwBuahrsBf00ty7jBPiREu6sXTBlyLniNIrZAQgeGCKfIvrlV80uvIZAhv1cydekDfBuzi8eudji/3N2/E4itxDpRnyqnMrWG3fGBc+qlGZJyYAyHiggvRXlHGw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-35f418f394dso27023855ab.0 for ; Wed, 20 Dec 2023 10:57:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703098637; x=1703703437; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o6OwlIko118D6goQK51jE1bTFzybwZUurbbutbtV7zY=; b=S7oeaIXDP+8x0JVFmdkC34gSuWyi/yVQdSV43Z9Swoy8cHL0M/xYi8tWNuqglQfMce 6N81RtcrKAwR6X5MbR8S7SZs5ijt/3X7mJE/LunX3Y5dxke7ioed9oAYOHNtqhk7AoJ/ bFYZREYauqVTvlgkXz+ZwyI8nywwA/aCY4yyYJ7sUTZyM/F9bm5T+jq/fkGTWg2nKlNI fq71NTC0H0LR2F1YsdKTgaqSJ3O+TM74e6jfAt6FA0mdFvy/Fg5PvHToSaPoWApPf2Vu xOmcAAXjQjezBT6DSjXNygzoJTf4QZni3mL/OEH1Ulgn83leTGnJjokwAKIpqnejnjv1 P4/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703098637; x=1703703437; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o6OwlIko118D6goQK51jE1bTFzybwZUurbbutbtV7zY=; b=j5BluvHIooQ9I+jA+qT8oElbrH9NNxX+GcIl2ZUCks28I3fRgsn26rvajYzKgBVRwU kAplGEG+pZ4+/gS9iGMvCvGN3qUs7XdaCq0gD0mA2zqHLYgk6GJiOf65zHikSnjTRvP6 xd07cXzGD8TTeUpsFTgEH4dLVka+HMP71O4Sowdz/z+uWhTpAFqKr+kFzKOaWqOwrATt ing0r7P1eSx/xyCQPzch9fP4HbC4mQKQj386T3VHXOU+/ft9Ed9k2qU6QgssAhQ8Ams6 5MYu/kyZA5tD/AsZNbg0pL4waLv/Q78r2H/gkHthlJQD1o912MRxt2mTUMVBHXVNilCr aZug== X-Gm-Message-State: AOJu0YwEwF+lsyORCvcpgX+GiC2G+sRNxQTCxxOc9ViGaAokbyn5D7mQ 8oA3M5LUmYqsv7b09xUBrtA= X-Google-Smtp-Source: AGHT+IEDCu0+DtFVhzS80xeiuW5VD+xDzBtyaVAcKU/72sB41QJKK8bPcxlsPR4ylS+IMiDleBpVaQ== X-Received: by 2002:a05:6e02:1ba3:b0:35f:c678:9509 with SMTP id n3-20020a056e021ba300b0035fc6789509mr3013089ili.48.1703098636942; Wed, 20 Dec 2023 10:57:16 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id x2-20020a056e02074200b0035e6c8203c0sm29156ils.75.2023.12.20.10.57.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 10:57:16 -0800 (PST) Message-ID: <39a1a8fb-6d6f-4c81-a4df-5d658467e34f@gmail.com> Date: Wed, 20 Dec 2023 11:57:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3][RFC] RISC-V: Add vector related reservations Content-Language: en-US To: Edwin Lu , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com, kito.cheng@gmail.com, Robin Dapp References: <20231215185328.794425-1-ewlu@rivosinc.com> <20231215185328.794425-3-ewlu@rivosinc.com> From: Jeff Law In-Reply-To: <20231215185328.794425-3-ewlu@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/15/23 11:53, Edwin Lu wrote: > This patch copies the vector reservations from generic-ooo.md and > inserts them into generic.md and sifive.md. The vector pipelines are > necessary to avoid an ICE from the assert > > gcc/ChangeLog: > > * config/riscv/generic-ooo.md: syntax > * config/riscv/generic.md (pipe0): new reservation > (generic_vec_load): ditto > (generic_vec_store): ditto > (generic_vec_loadstore_seg): ditto > (generic_generic_vec_alu): ditto > (generic_vec_fcmp): ditto > (generic_vec_imul): ditto > (generic_vec_fadd): ditto > (generic_vec_fmul): ditto > (generic_crypto): ditto > (generic_vec_perm): ditto > (generic_vec_reduction): ditto > (generic_vec_ordered_reduction): ditto > (generic_vec_idiv): ditto > (generic_vec_float_divsqrt): ditto > (generic_vec_mask): ditto > (generic_vec_vesetvl): ditto > (generic_vec_setrm): ditto > (generic_vec_readlen): ditto > * config/riscv/sifive-7.md (sifive_7): new reservation > (sifive_7_vec_load): ditto > (sifive_7_vec_store): ditto > (sifive_7_vec_loadstore_seg): ditto > (sifive_7_sifive_7_vec_alu): ditto > (sifive_7_vec_fcmp): ditto > (sifive_7_vec_imul): ditto > (sifive_7_vec_fadd): ditto > (sifive_7_vec_fmul): ditto > (sifive_7_crypto): ditto > (sifive_7_vec_perm): ditto > (sifive_7_vec_reduction): ditto > (sifive_7_vec_ordered_reduction): ditto > (sifive_7_vec_idiv): ditto > (sifive_7_vec_float_divsqrt): ditto > (sifive_7_vec_mask): ditto > (sifive_7_vec_vesetvl): ditto > (sifive_7_vec_setrm): ditto > (sifive_7_vec_readlen): ditto > > Signed-off-by: Edwin Lu > Co-authored-by: Robin Dapp > --- > gcc/config/riscv/generic-ooo.md | 19 ++--- > gcc/config/riscv/generic.md | 118 ++++++++++++++++++++++++++++++++ > gcc/config/riscv/sifive-7.md | 118 ++++++++++++++++++++++++++++++++ > 3 files changed, 242 insertions(+), 13 deletions(-) > > diff --git a/gcc/config/riscv/generic-ooo.md b/gcc/config/riscv/generic-ooo.md > index de93245f965..18b606bb981 100644 > --- a/gcc/config/riscv/generic-ooo.md > +++ b/gcc/config/riscv/generic-ooo.md I'm not sure why you changed these. In general we try to keep lines under 80 columns in the source. Things like insn reservations are in a grey area as the lists sometimes get very long. In general I'd leave this stuff alone if it doesn't have a function change. > > index 3e49d942495..7ac974ad634 100644 > --- a/gcc/config/riscv/generic.md > +++ b/gcc/config/riscv/generic.md Note that some of the stuff pointed out on patch #1 applies here to, like rdfrm not being a vector load/store. So as you clean up patch #1, make sure to mirror the cleanups in patch #2 of the series. Jeff