From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id E93333858D32 for ; Tue, 14 Nov 2023 21:40:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E93333858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E93333858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699998019; cv=none; b=r+6+KQckgjSX4XXk9aMx2kB1hqutJVNIViyjr0g+OaIYXOjfoCEEM6o9c7DSKePLiQoB1rXEtJlOp8JQAuwJBBqY4qIDXoLkoPk8LlNjGEyArAHFb/Wn54tQcXce/6DuM7vpBvphdkm1JQApCY6XUP+imD/Wr4qApnBlZ61X110= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699998019; c=relaxed/simple; bh=vv70JK8+pTem1EEXC1rwtdvNK2Gz4pAKVbE01GW8gaY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cT84kbhQ87mwhwkreeRSGszxiQjLj4ZS3ZMUZnPhDIWW/MClXnryTaYDGuo/DJPBIUVvjEGgFIQGF1nyUsJaGFjJgYBHPrD94OecfqLX3m/wK8/cr+Oq541WwpYDn4V5BzY9mNcpiB0fWC45dw9PE9QQEGOwmfMfKlsSX/33kTI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AELGNch031183; Tue, 14 Nov 2023 21:40:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=aHYIrlYKtIG+aXrqY8T52S6M1qUVoguSyS/sW1K9OUI=; b=h8bzZOOtmo9hNfeS49d1ejgAzAcI0ECu+MkDLdMNJOTK/8bFnHQNl86LKtGr7CxAn4cd WG0qTsuJTaolFmEQ8Kt2tDE8MfQV1NhwCZrPfz9g/D6V0ChGeZSm5yWJBZ3Zl/eEyALL tzmgoOqiPqP1RrdaMAW4xjl74jMy5ISJIua/mvvxb5JZVe3uDsmX7GfncuUXg4CeMinn ocjE3n2EwfRKvXdgrdKOHaj0p/wgxG4Zuf0Fra7QSYbEOiR1UAfkqDU8gjj80iL5Twsz toJh1PkTqGuHEkzCezEcyhgLLWMnaKmw3Ovmi5vdMb7snEjolKcmY1EdNIL3pwSDZOCN lw== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ucgburxjh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Nov 2023 21:40:17 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AEJn51M015464; Tue, 14 Nov 2023 21:40:16 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3uakxsu6k8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Nov 2023 21:40:16 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AELeFEL35520818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Nov 2023 21:40:15 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B5E1C5805E; Tue, 14 Nov 2023 21:40:15 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 44E1758051; Tue, 14 Nov 2023 21:40:15 +0000 (GMT) Received: from [9.61.149.35] (unknown [9.61.149.35]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 14 Nov 2023 21:40:15 +0000 (GMT) Message-ID: <39a70acb-e3ff-4f4d-8d9d-98f005a28d77@linux.ibm.com> Date: Tue, 14 Nov 2023 15:40:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rs6000: Disable PCREL for unsupported targets [PR111045] Content-Language: en-US To: "Kewen.Lin" Cc: segher@kernel.crashing.org, gcc-patches@gcc.gnu.org, Michael Meissner , P Jeevitha References: <448048b2-1256-4d13-924e-695b4b3ff9ba@linux.vnet.ibm.com> <2c4fb77c-4cc9-dce8-b25f-4c3a463d348c@linux.ibm.com> <31f76b1c-86ce-bb08-e888-c7d7bb49e75f@linux.ibm.com> <2029afa9-e971-21a9-f346-e335ef384d78@linux.ibm.com> <29fc5f0f-130a-85b3-0d50-82ac9f3494b4@linux.ibm.com> <5bd33bfc-ca84-6879-75b9-628313bdd7e7@linux.ibm.com> From: Peter Bergner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: GEa8zyqtTY7IM0XsG5qQ2_mvV48ErihQ X-Proofpoint-ORIG-GUID: GEa8zyqtTY7IM0XsG5qQ2_mvV48ErihQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-14_22,2023-11-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=810 mlxscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311140159 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/13/23 8:33 PM, Kewen.Lin wrote: >> if (PCREL_SUPPORTED_BY_OS) > .... >> + else >> + { >> + if (TARGET_PCREL >> + && (rs6000_isa_flags_explicit & OPTION_MASK_PCREL) != 0) >> + error ("use of %qs is invalid for this target", "-mpcrel"); >> rs6000_isa_flags &= ~OPTION_MASK_PCREL; >> } > > now, I think it should be fine not to explicitly mask it off Power10 > default flags? Then leave Power10 default flags unchanged seems more > consistent. The others look good to me! Thanks again. Ah, good catch, yes, I'll remove the clearing of the bit, since we know it's either already clear (because that is the default value) or if it's set, then that's the error condition we're catching here. That also means that we can remove the test for rs6000_isa_flags_explicit & OPTION_MASK_PCREL) != 0 too, since at this point, TARGET_PCREL can only be true if it was explicitly enabled with -mpcrel by the user. Therefor, the code can now look like: if (PCREL_SUPPORTED_BY_OS) .... else if (TARGET_PCREL) error ("use of %qs is invalid for this target", "-mpcrel"); I'll make that change, redo the bootstrap and regtesting and then officially submit the patch. Thanks! Peter