From: Murray Steele <murray.steele@arm.com>
To: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v3 2/2][GCC] arm: Declare MVE types internally via pragma
Date: Tue, 21 Dec 2021 11:20:26 +0000 [thread overview]
Message-ID: <39cdd9c4-04b8-d612-e707-5576aa73149d@arm.com> (raw)
In-Reply-To: <03099bb4-1dcf-aae5-3d77-7112ae22948a@arm.com>
Hi,
I'd like to ping this patch revision [1].
Thanks,
Murray
[1]: https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586476.html
---
On 09/12/2021 15:24, Murray Steele via Gcc-patches wrote:
> Changes from original patch:
>
> 1. Make mentioned changes to changelog.
> 2. Add namespace-end comments.
> 3. Add #error for when arm-mve-builtins.def is included without
> defining DEF_MVE_TYPE.
> 4. Make placement of '#undef DEF_MVE_TYPE' consistent.
>
> ---
>
> This patch moves the implementation of MVE ACLE types from
> arm_mve_types.h to inside GCC via a new pragma, which replaces the prior
> type definitions. This allows for the types to be used internally for
> intrinsic function definitions.
>
> Bootstrapped and regression tested on arm-none-linux-gnuabihf, and
> regression tested on arm-eabi -- no issues.
>
> Thanks,
> Murray
>
> gcc/ChangeLog:
>
> * config.gcc: Add arm-mve-builtins.o to extra_objs.
> * config/arm/arm-c.c (arm_pragma_arm): Handle "#pragma GCC arm".
> (arm_register_target_pragmas): Register it.
> * config/arm/arm-protos.h: (arm_mve::arm_handle_mve_types_h): New
> prototype.
> * config/arm/arm_mve_types.h: Replace MVE type definitions with
> new pragma.
> * config/arm/t-arm: (arm-mve-builtins.o): New target rule.
> * config/arm/arm-mve-builtins.cc: New file.
> * config/arm/arm-mve-builtins.def: New file.
> * config/arm/arm-mve-builtins.h: New file.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/arm/mve/mve.exp: Add new subdirectories.
> * gcc.target/arm/mve/general-c/type_redef_1.c: New test.
> * gcc.target/arm/mve/general/double_pragmas_1.c: New test.
> * gcc.target/arm/mve/general/nomve_1.c: New test.
next prev parent reply other threads:[~2021-12-21 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 10:15 [PATCH " Murray Steele
2021-11-18 15:45 ` Richard Earnshaw
2021-11-23 9:37 ` Murray Steele
2021-11-23 14:16 ` Richard Earnshaw
2021-11-23 15:45 ` Murray Steele
2021-11-25 9:42 ` Murray Steele
2021-12-08 10:04 ` [PING][PATCH " Murray Steele
2021-12-08 15:23 ` [PATCH " Richard Earnshaw
2021-12-08 15:39 ` Murray Steele
2021-12-08 17:34 ` Richard Earnshaw
2021-12-09 15:24 ` [PATCH v3 " Murray Steele
2021-12-21 11:20 ` Murray Steele [this message]
2021-12-22 15:00 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39cdd9c4-04b8-d612-e707-5576aa73149d@arm.com \
--to=murray.steele@arm.com \
--cc=Richard.Earnshaw@foss.arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).