public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mike Stump <mikestump@comcast.net>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: Christophe Lyon <christophe.lyon@linaro.org>,
	Marek Polacek <polacek@redhat.com>,
	Gcc Patch List <gcc-patches@gcc.gnu.org>,
	"Joseph S. Myers" <joseph@codesourcery.com>,
	Jason Merrill <jason@redhat.com>
Subject: Re: [PATCH c/c++] use explicit locations for some warnings in c-pragma.c
Date: Fri, 06 Nov 2015 21:18:00 -0000	[thread overview]
Message-ID: <3B3292DF-EE4A-4AE0-9FB4-70AADEA3A2F8@comcast.net> (raw)
In-Reply-To: <CAESRpQBAndAxL8xtUQQK5HTpNudR0bjQGdUQpP84KNXgyb9Bmw@mail.gmail.com>

On Nov 4, 2015, at 1:02 PM, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
> On 4 November 2015 at 09:45, Mike Stump <mrs@mrs.kithrup.com> wrote:
>> in the top of the tree.  This is bad as the same line appears in a PASS: and an XFAIL:.  Each test case should be unique.  Should it be updated to 64?
> 
> I think it is sufficient to change it to:
> 
> /* { dg-warning "24:missing" "wrong column" { xfail *-*-* }  2 } */

I tested this out, works just fine.

2015-11-06  Mike Stump  <mikestump@comcast.net>

	* gcc.dg/pragma-diag-5.c: Make test cases unique.

Index: testsuite/gcc.dg/pragma-diag-5.c
===================================================================
--- testsuite/gcc.dg/pragma-diag-5.c	(revision 229885)
+++ testsuite/gcc.dg/pragma-diag-5.c	(working copy)
@@ -1,6 +1,6 @@
 /* { dg-do compile } */
 #pragma GCC diagnostic /* { dg-warning "missing" "missing" } */
-/* { dg-warning "24:missing" "missing" { xfail *-*-* }  2 } */
+/* { dg-warning "24:missing" "wrong column" { xfail *-*-* }  2 } */
 
 #pragma GCC diagnostic warn /* { dg-warning "24:expected" } */
 
Committed revision 229891.

Thanks for your help.

      parent reply	other threads:[~2015-11-06 21:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25 17:47 Manuel López-Ibáñez
2015-05-25 19:48 ` Jason Merrill
2015-05-25 20:17 ` Marek Polacek
2015-05-25 20:55   ` Manuel López-Ibáñez
2015-09-20 20:38     ` Christophe Lyon
2015-09-20 22:35       ` Manuel López-Ibáñez
2015-09-21  0:24         ` Christophe Lyon
2015-09-21  0:29           ` Manuel López-Ibáñez
2015-09-21  0:33             ` Christophe Lyon
2015-09-21  1:46               ` Manuel López-Ibáñez
2015-09-21  5:50                 ` Christophe Lyon
2015-09-21 12:32                   ` Manuel López-Ibáñez
2015-11-04  9:46         ` Mike Stump
2015-11-04 21:02           ` Manuel López-Ibáñez
2015-11-06 21:16             ` Mike Stump
2015-11-06 21:18             ` Mike Stump [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B3292DF-EE4A-4AE0-9FB4-70AADEA3A2F8@comcast.net \
    --to=mikestump@comcast.net \
    --cc=christophe.lyon@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=lopezibanez@gmail.com \
    --cc=polacek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).