From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-413021-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 8949 invoked by alias); 6 Nov 2015 21:18:27 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 8940 invoked by uid 89); 6 Nov 2015 21:18:26 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: resqmta-po-07v.sys.comcast.net
Received: from resqmta-po-07v.sys.comcast.net (HELO resqmta-po-07v.sys.comcast.net) (96.114.154.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 06 Nov 2015 21:18:25 +0000
Received: from resomta-po-05v.sys.comcast.net ([96.114.154.229])	by resqmta-po-07v.sys.comcast.net with comcast	id eMJD1r00D4xDoy801MJPqT; Fri, 06 Nov 2015 21:18:23 +0000
Received: from [IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d] ([IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d])	by resomta-po-05v.sys.comcast.net with comcast	id eMJL1r00J2ztT3H01MJMLx; Fri, 06 Nov 2015 21:18:22 +0000
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: [PATCH c/c++] use explicit locations for some warnings in c-pragma.c
From: Mike Stump <mikestump@comcast.net>
In-Reply-To: <CAESRpQBAndAxL8xtUQQK5HTpNudR0bjQGdUQpP84KNXgyb9Bmw@mail.gmail.com>
Date: Fri, 06 Nov 2015 21:18:00 -0000
Cc: Christophe Lyon <christophe.lyon@linaro.org>, Marek Polacek <polacek@redhat.com>, Gcc Patch List <gcc-patches@gcc.gnu.org>, "Joseph S. Myers" <joseph@codesourcery.com>, Jason Merrill <jason@redhat.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3B3292DF-EE4A-4AE0-9FB4-70AADEA3A2F8@comcast.net>
References: <CAESRpQAss9wY48rxjsVC_VHn5c2bC+ZKf4m6fvL-ZNVFLkmKEA@mail.gmail.com> <20150525195650.GY27320@redhat.com> <CAESRpQA=V4JmGTzOmJxgjCe+_mUMXdhMMVBnuGiDeW8LxOYi5A@mail.gmail.com> <CAKdteOYY1O50YLv7URgXX1Yiht=VPJvgT6Z8p2k6bUrDfb6pCw@mail.gmail.com> <CAESRpQCe5=ih8-kw-kMg7v+rxLHbfdr3VtGAfbyyPFJ=Fez+aQ@mail.gmail.com> <9BCE0DCA-FF55-4C94-ADA0-78AAE57CA26B@mrs.kithrup.com> <CAESRpQBAndAxL8xtUQQK5HTpNudR0bjQGdUQpP84KNXgyb9Bmw@mail.gmail.com>
To: =?iso-8859-1?Q?Manuel_L=F3pez-Ib=E1=F1ez?= <lopezibanez@gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2015-11/txt/msg00737.txt.bz2

On Nov 4, 2015, at 1:02 PM, Manuel L=F3pez-Ib=E1=F1ez <lopezibanez@gmail.co=
m> wrote:
> On 4 November 2015 at 09:45, Mike Stump <mrs@mrs.kithrup.com> wrote:
>> in the top of the tree.  This is bad as the same line appears in a PASS:=
 and an XFAIL:.  Each test case should be unique.  Should it be updated to =
64?
>=20
> I think it is sufficient to change it to:
>=20
> /* { dg-warning "24:missing" "wrong column" { xfail *-*-* }  2 } */

I tested this out, works just fine.

2015-11-06  Mike Stump  <mikestump@comcast.net>

	* gcc.dg/pragma-diag-5.c: Make test cases unique.

Index: testsuite/gcc.dg/pragma-diag-5.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- testsuite/gcc.dg/pragma-diag-5.c	(revision 229885)
+++ testsuite/gcc.dg/pragma-diag-5.c	(working copy)
@@ -1,6 +1,6 @@
 /* { dg-do compile } */
 #pragma GCC diagnostic /* { dg-warning "missing" "missing" } */
-/* { dg-warning "24:missing" "missing" { xfail *-*-* }  2 } */
+/* { dg-warning "24:missing" "wrong column" { xfail *-*-* }  2 } */
=20
 #pragma GCC diagnostic warn /* { dg-warning "24:expected" } */
=20
Committed revision 229891.

Thanks for your help.