From: Richard Biener <richard.guenther@gmail.com>
To: Jeff Law <law@redhat.com>,Yuri Rumyantsev <ysrumyan@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,Igor Zamyatin
<izamyatin@gmail.com>
Subject: Re: [PATCH] Simple optimization for MASK_STORE.
Date: Fri, 08 May 2015 19:16:00 -0000 [thread overview]
Message-ID: <3CA18E59-07AA-4072-A9D7-A87D8182F663@gmail.com> (raw)
In-Reply-To: <554D03C3.4080700@redhat.com>
On May 8, 2015 8:43:15 PM GMT+02:00, Jeff Law <law@redhat.com> wrote:
>On 05/08/2015 03:27 AM, Richard Biener wrote:
>> On Wed, May 6, 2015 at 4:04 PM, Yuri Rumyantsev <ysrumyan@gmail.com>
>wrote:
>>> Hi All,
>>>
>>> Here is a patch which gives us significant speed-up on HASWELL for
>>> test containing masked stores. The main goal of that patch is
>attempt
>>> to avoid HW hazard for maskmove instructions through inserting
>>> additional check on zero mask and putting all masked store
>statements
>>> into separate block on false edge.All MASK_STORE statements having
>the
>>> same mask put into one block. Any comments will be appreciate.
>>
>> Hmm. I'm not very happy with this "optimization" happening at the
>> GIMPLE level - it feels more like a mdreorg thing...
>I haven't looked at the patch, but it sounds like just specialization
>using a runtime check to select between the implementations which is
>fairly natural to do at the gimple level.
Well, sure. Which is why I suggested a un-ifcvt pass instead.
Anyway, the implementation has multiple issues.
Richard.
>Jeff
next prev parent reply other threads:[~2015-05-08 19:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 14:04 Yuri Rumyantsev
2015-05-08 9:27 ` Richard Biener
2015-05-08 18:43 ` Jeff Law
2015-05-08 19:16 ` Richard Biener [this message]
2015-05-20 14:10 ` Yuri Rumyantsev
2015-05-29 14:28 ` Yuri Rumyantsev
2015-06-09 12:15 ` Richard Biener
2015-06-18 15:41 ` Yuri Rumyantsev
2015-07-07 13:55 ` Yuri Rumyantsev
2015-07-10 5:51 ` Jeff Law
2015-07-20 15:26 ` Yuri Rumyantsev
2015-07-21 13:59 ` Richard Biener
2015-07-23 20:32 ` Jeff Law
2015-07-24 9:04 ` Yuri Rumyantsev
2015-07-24 9:24 ` Richard Biener
2015-07-24 19:26 ` Jeff Law
2015-07-27 9:04 ` Richard Biener
2015-08-06 11:07 ` Yuri Rumyantsev
2015-08-13 11:40 ` Yuri Rumyantsev
2015-08-13 11:46 ` Richard Biener
2015-11-02 15:24 ` Yuri Rumyantsev
2015-11-05 15:49 ` Yuri Rumyantsev
2015-11-06 12:56 ` Richard Biener
2015-11-06 13:29 ` Yuri Rumyantsev
2015-11-10 12:33 ` Richard Biener
2015-11-10 12:48 ` Ilya Enkovich
2015-11-10 14:46 ` Richard Biener
2015-11-10 14:56 ` Ilya Enkovich
2015-11-10 17:02 ` Mike Stump
2015-11-11 9:18 ` Richard Biener
2015-11-11 13:13 ` Yuri Rumyantsev
2015-11-12 13:59 ` Richard Biener
2015-11-19 15:20 ` Yuri Rumyantsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CA18E59-07AA-4072-A9D7-A87D8182F663@gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=izamyatin@gmail.com \
--cc=law@redhat.com \
--cc=ysrumyan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).