From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34648 invoked by alias); 11 Sep 2019 18:55:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 34631 invoked by uid 89); 11 Sep 2019 18:55:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=hear, HX-Spam-Relays-External:ESMTPA X-HELO: resqmta-ch2-02v.sys.comcast.net Received: from resqmta-ch2-02v.sys.comcast.net (HELO resqmta-ch2-02v.sys.comcast.net) (69.252.207.34) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2019 18:55:22 +0000 Received: from resomta-ch2-09v.sys.comcast.net ([69.252.207.105]) by resqmta-ch2-02v.sys.comcast.net with ESMTP id 87XbikYcGIZAX87lwi5jGD; Wed, 11 Sep 2019 18:55:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=20190202a; t=1568228120; bh=uhfvd1fBuTE1pIJLZW5bvlLLvD96UlDJ9kSA28INyEk=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To; b=cFYXpw/VWnrA7m+4JWZ4GPFg7SPOLmzPyO+dFPpvvt9CSRzfWV2i+ixi1aJHnwk0W ch+AV/Gp/C049/hpuHRuNnIufx5RO9ZVZSC4f93Yb03Of82kwPBt/1UFXj+0hi+zdJ sJs6nngr4DsD+Jp7xXiF9DsunwMb83vveysE+g1VXIQfLMhIBfnrvqHnOmCCABtBjQ QvVZ7TcDcdUo/srE+fSvEHXitw+3AvFxONgaucmWzNwrlNH1fgTicmHBqDbaWBPcx6 TccD5M+FYXrJTg7rsrGQ44DTUJikwuXdlLDN+Dw2n6lkg2TWFR84dnX9GvLS7ngyTJ 381dflBi1XrOQ== Received: from [IPv6:2601:640:4000:fcbb:177:b38e:cc87:ccd1] ([IPv6:2601:640:4000:fcbb:177:b38e:cc87:ccd1]) by resomta-ch2-09v.sys.comcast.net with ESMTPA id 87luiV4WJamW487lviUYUi; Wed, 11 Sep 2019 18:55:20 +0000 X-Xfinity-VMeta: sc=-100;st=legit Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH V6 04/11] testsuite: new require effective target indirect_calls From: Mike Stump In-Reply-To: <20190829151347.13536-5-jose.marchesi@oracle.com> Date: Wed, 11 Sep 2019 18:55:00 -0000 Cc: gcc-patches@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <3CD73F6C-7900-48E5-95DA-345E5884AE00@comcast.net> References: <20190829151347.13536-1-jose.marchesi@oracle.com> <20190829151347.13536-5-jose.marchesi@oracle.com> To: "Jose E. Marchesi" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00776.txt.bz2 On Aug 29, 2019, at 8:13 AM, Jose E. Marchesi wr= ote: >=20 > This patch adds a new dg_require_effective_target procedure to the > testsuite infrastructure: indirect_calls. This new function tells > whether a target supports calls to non-constant call targets. Ok. I'll let people contemplate some comments... I'm torn between targets that can't support C and gooping up the test suite= and approving. I'll error on the side of approving this, but, would like = to hear from folks if I go to far. Since they are easy to identify, maintain and ignore... I went with approv= al. People can contemplate other ways to do this, like introduce a fake marker = for when the feature is used and when running a program with such a marker,= then mark it as unsupported. This way, no test need be marked, and all fu= ture test cases that use the feature, just flip to unsupported, no maintena= nce required. We do this sort of thing with programs that overflow the RAM, by using a st= ylized error message from ld, and noticing that in dejagnu, and then not ex= pecting it to work. If you can find a way to tally stack space, and check it before running it,= the other change to tightly track stack space then would not be as necessa= ry. I think you might be able to do this on your target. Having the stack= space marked is generally useful for other targets, as most won't have a n= ice way to sort out small stacks, so my general comment apply less to the = stack size, but, things that can cause you less maintenance burden are like= ly good in any event.