public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kresten Krab Thorup <krab@trifork.com>
To: Jeff Sturm <jsturm@one-point.com>
Cc: gcc-patches@gcc.gnu.org,  java-patches@gcc.gnu.org
Subject: Re: libffi: closures for sparc
Date: Wed, 17 Jul 2002 08:57:00 -0000	[thread overview]
Message-ID: <3D3591D8.3000602@trifork.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0207171025510.19377-100000@ops2.one-point.com>

Jeff Sturm wrote:
> b) The mess in java_raw_api.c is mostly caused by treating the `raw'
> argument to ffi_java_raw_call as a pointer to ffi_raw, when it is really a
> pointer to _Jv_word.  The two unions are not compatible, or even close.
> For instance ffi_raw may not have a 32-bit integer member resembling a
> `jint'.
> 
> This whole file ought to be looked at more closely, since it seems to be
> using ffi_raw as something it isn't.  I'd expect ppc64 to have the same
> problems as sparc64.

I'm out of the loop now, but it should be known that the "raw" api was 
thought as an optimized version of the general ffi api which would make 
sense exactly on architectures where the interpreter's stack (i.e. the 
union of jint, jchar, etc.) is very similar to the layout of arguments 
in the host environment's ABI.  As such, it is indeed ugly; and relies 
on all kinds of assumptions...

Also see http://gcc.gnu.org/ml/java/1999-q3/msg00174.html

Kresten


  reply	other threads:[~2002-07-17 15:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-17  8:09 Jeff Sturm
2002-07-17  8:57 ` Kresten Krab Thorup [this message]
2002-07-17 14:37   ` Jeff Sturm
2002-07-17 16:18 Boehm, Hans
2002-07-24  9:54 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D3591D8.3000602@trifork.com \
    --to=krab@trifork.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java-patches@gcc.gnu.org \
    --cc=jsturm@one-point.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).