From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id E31C83858D35 for ; Wed, 22 Nov 2023 10:52:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E31C83858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E31C83858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700650364; cv=none; b=E5F1Yc9uCaKhUMMFruKO1Q9vgLIHWLr8j3ssAupUZAvGGFNM9ZAb2U+O+fSpWkXj3eJnb/wkLM4Iq/Eqn4I4BbZw+xqOcr6C3Jx6CHN8PUTTcqfTUFPr/p/OCP2NoWN1zGCiwwB3zzf0vzm2D02KRDGwdAYWBRY4yKASixtnFKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700650364; c=relaxed/simple; bh=LBPzupEVTQNQJ2c5Xyrv8V2Ro09o5wxJV8Y/2HxnZsM=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=JPzpvXmL8nxvGXcYZGqUFjW2JKufw9L+VbUl+mUYbHAnoY8tiRNKuJaK0NNji054ZTZD1LxIWsIZUeKC05NaxiWsdUp3jRdAGZ9tz5tUY0Kwu5HFnc6ibZSJyCJKNRjkGTiLMLIBm3O6DdmHx5djhFbgpsx0/V9i1P6UQKNP0kA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-32ddfb38c02so4448187f8f.3 for ; Wed, 22 Nov 2023 02:52:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700650360; x=1701255160; darn=gcc.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BLElGMq23UlBUN9+P/tPakDGo46ywx/xEz1Tq7qsciQ=; b=Rjeg5SA/5obVFA4uAQGMKpakYL8Df8xKQznJVXbcnLeZIUGakT10cTT8iBpEcFcGJn 6nMZlI4QUeBdsMwl74+SHTHlRWecag1diB+fOhkPQ0S1Xd6Lrjl6hTdOxlbMCrTa543b D2y1awUaxiBnuygbVRmkTQiwM9kIrROjq4ur0k0jt/Xv5glyuFBFynbG+/os+8J0sFqO XdPnCGffOKHcjaxDzeEbXiN64kPX5AlXlfcSdjQZPSHhdmpo2AcRngXFtMh9oG3oPY84 h5x7ZM2OWPqGXZTZLV6jfg8s9uaLqD9zugAMXv9PuWBTNB8ONSi9Bxww8wtKi8Zi/vue hIKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700650360; x=1701255160; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BLElGMq23UlBUN9+P/tPakDGo46ywx/xEz1Tq7qsciQ=; b=ppjygRQHfeVP/awk+ETfvN7xyMKm6JWQaQULB8n8c8AZo9tgmSoVFHQtoHQcT85eRR 4OLLFqfZTubS8lu0gwbxb+AlvsQtySuwk+TbgngI9fmikJXyUDaiWyI7kjur1I59qLcZ hdJwPS/EsjwfWovsAQ47HRt4l5CyNtko4+jjhsi8SjzJIPL79IF0oSRtLv0bGUM55ZF2 BV+AKqFJJ/wJ0eco3GPnmXSNtdLXsZS2uKjwDUmger1zMWyaZ991fE3K2kgfrUsQE6lK nRoaibFw+so6NywT2137ma2PnCMrwkKrW4n4SZr8WNeKXTemr9yMjy8VCtYvesYTqIeB wCPA== X-Gm-Message-State: AOJu0YyNP+vkvLNF07i7onDQFmi0Ug8u49sx4hqaEze8nMUHnkeQ/y4y yPeOTHFFnF09/i2CEfzmUtk= X-Google-Smtp-Source: AGHT+IEzWfJQAbHl1Qgr5eKy2wlxQESnmBZNx/dxkK4pLjCI3nLxijK4VdDCNOY4fVpy83k/THYaGQ== X-Received: by 2002:a5d:6d0d:0:b0:32f:811f:5046 with SMTP id e13-20020a5d6d0d000000b0032f811f5046mr1420225wrq.11.1700650360469; Wed, 22 Nov 2023 02:52:40 -0800 (PST) Received: from smtpclient.apple (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.gmail.com with ESMTPSA id cm4-20020a5d5f44000000b00332d3b89561sm804666wrb.97.2023.11.22.02.52.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Nov 2023 02:52:40 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: Darwin: Replace environment runpath with embedded [PR88590] From: Iain Sandoe In-Reply-To: <92736664-0EF6-4A62-B309-31311B736892@gmail.com> Date: Wed, 22 Nov 2023 10:52:39 +0000 Cc: Thomas Schwinge , GCC Patches , Martin Jambor Content-Transfer-Encoding: quoted-printable Message-Id: <3D7BD6A2-6B28-4AF6-9194-F93B3C207571@gmail.com> References: <653fd72a.050a0220.a6a20.de86SMTPIN_ADDED_BROKEN@mx.google.com> <5D574615-8242-439C-A4A8-B66CF896D66D@gmail.com> <2C6A1839-8D61-4AEE-A9CB-F40971F61AF7@gmail.com> <8734x6vktd.fsf@euler.schwinge.homeip.net> <22AC949A-3CE2-47E0-83F6-9D0CC6B52C99@gmail.com> <9CB59C76-0451-487C-A708-BBCBEF32D448@gmail.com> <87zfzc1st3.fsf@euler.schwinge.homeip.net> <92736664-0EF6-4A62-B309-31311B736892@gmail.com> To: FX Coudert X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi FX, > On 17 Nov 2023, at 14:20, FX Coudert wrote: >=20 >>> I have done a full rebuild, and having looked more at the structure = of libtool.m4 I am now convinced that having that line outside of the = scope of _LT_DARWIN_LINKER_FEATURES is simply wrong (probably a = copy-pasto or leftover from earlier code). The latter; my original patch to do this had all the work inside = libtool.m4 - but that proved to be unwieldy in practice, so the eventual patch split the ENABLE_DARWIN_AT_RPATH AM_CONDITIONAL out = and applies it (after libtool is initiallised) in configure.ac cases that need it. It seems I failed to remove all the old code in that change :(. >>> Having rebuilt everything, it only manifests itself in = fixincludes/ChangeLog. Iain is traveling right now, but when he is back = I would like to submit this patch if he agrees with the above. It was = regtested on x86_64-apple-darwin21. I have also regtested on i686, x86_64, aarch64 Darwin, x86_64 and = aarch64 Linux. >=20 > With the correct patch attached. I believe this can be applied as a partial reversion of a previously = approved patch, thanks Iain >=20 > <0001-Build-fix-error-in-fixinclude-configure.patch>