From: Paul Koning <paulkoning@comcast.net>
To: Jeff Law <law@redhat.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, doc] describe mode checking for doloop_end pattern
Date: Fri, 12 Oct 2018 14:10:00 -0000 [thread overview]
Message-ID: <3E43D9D6-EFDF-4B08-A95A-2AA99CDD7853@comcast.net> (raw)
In-Reply-To: <e598b2d3-e281-0a49-5114-4c6d9112c44e@redhat.com>
> On Oct 11, 2018, at 11:01 PM, Jeff Law <law@redhat.com> wrote:
>
> On 10/11/18 3:09 PM, Paul Koning wrote:
>> Updated with an additional item I just debugged.
>>
>> Since the code that uses the doloop_end pattern does not check the operand mode as given in the pattern, the pattern itself may need to do this, and that was not documented. In addition, if the doloop_end pattern is a define_expand, there must be a define_insn (or define_insn_and_split) matching the generated pattern. I had a define_split instead, and the result was an ICE in loop optimization (loop2_done pass).
>>
>> This patch adds that information. It also updates the example to reflect this.
>>
>> Ok for trunk?
>>
>> paul
>>
>> ChangeLog:
>>
>> 2018-10-11 Paul Koning <ni1d@arrl.net>
>>
>> * doc/md.texi (doloop_end): Document that the pattern code may
>> need to check operand mode.
> OK.
> jeff
Thanks. Committed.
paul
next prev parent reply other threads:[~2018-10-12 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 21:23 Paul Koning
2018-10-12 3:03 ` Jeff Law
2018-10-12 14:10 ` Paul Koning [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-11 15:31 Paul Koning
2018-10-17 8:35 ` Sandra Loosemore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E43D9D6-EFDF-4B08-A95A-2AA99CDD7853@comcast.net \
--to=paulkoning@comcast.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).