From: Jim Wilson <wilson@tuliptree.org>
To: "Svein E. Seldal" <Svein.Seldal@solidas.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
denisc@overta.ru, marekm@linux.org.pl
Subject: Re: [avr] Patch for -mint8 option -- unreviewed patch
Date: Wed, 04 Jun 2003 18:13:00 -0000 [thread overview]
Message-ID: <3EDE36C0.1090004@tuliptree.org> (raw)
In-Reply-To: <3EBCDB0B.7070303@solidas.com>
Using 32-bit long long with an 8-bit target is sensible, and is already
done for some other 8-bit targets. So the concept is OK.
You are defining __AVR_INT8__ in two places, which seems redundant. You
only need it in one place. The correct place would be the first one in
TARGET_CPU_CPP_BUILTINS.
The ChangeLog entry isn't correct. You need to list every macro
modified, and briefly describe the change. You haven't done this. So
it should look something like this
* config/avr/avr.h (TARGET_CPU_CPP_BUILTINS): Define __AVR_INT8__
(LONG_LONG_TYPE_SIZE): Check INT_TYPE_SIZE.
The patch is OK with these changes.
The avr has two listed maintainers, so I included them in the cc's in
case they want to comment.
I was going to suggest that a doc change was missing, but then I noticed
that the -mint8 option isn't documented. Perhaps you could add the
missing documentation?
Jim
prev parent reply other threads:[~2003-06-04 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-24 23:55 [avr] Patch for -mint8 option Svein E. Seldal
2002-12-17 8:58 ` unreviewed patch Svein E. Seldal
2003-05-10 10:57 ` [avr] Patch for -mint8 option -- " Svein E. Seldal
2003-05-30 14:05 ` unreviwed patch -- 3rd attempt (since 2002-11) Svein E. Seldal
2003-06-04 18:13 ` Jim Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EDE36C0.1090004@tuliptree.org \
--to=wilson@tuliptree.org \
--cc=Svein.Seldal@solidas.com \
--cc=denisc@overta.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=marekm@linux.org.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).