From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24384 invoked by alias); 4 Jun 2003 18:13:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24352 invoked from network); 4 Jun 2003 18:13:46 -0000 Received: from unknown (HELO smtp-out.comcast.net) (24.153.64.109) by sources.redhat.com with SMTP; 4 Jun 2003 18:13:46 -0000 Received: from tuliptree.org (c-67-161-44-158.client.comcast.net [67.161.44.158]) by mtaout05.icomcast.net (iPlanet Messaging Server 5.2 HotFix 1.16 (built May 14 2003)) with ESMTP id <0HFY00HS4YM7RZ@mtaout05.icomcast.net> for gcc-patches@gcc.gnu.org; Wed, 04 Jun 2003 14:13:20 -0400 (EDT) Date: Wed, 04 Jun 2003 18:13:00 -0000 From: Jim Wilson Subject: Re: [avr] Patch for -mint8 option -- unreviewed patch To: "Svein E. Seldal" Cc: gcc-patches , denisc@overta.ru, marekm@linux.org.pl Message-id: <3EDE36C0.1090004@tuliptree.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii; format=flowed Content-transfer-encoding: 7BIT X-Accept-Language: en-us, en User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003 References: <3DE1D77D.3050903@solidas.com> <3EBCDB0B.7070303@solidas.com> X-SW-Source: 2003-06/txt/msg00351.txt.bz2 Using 32-bit long long with an 8-bit target is sensible, and is already done for some other 8-bit targets. So the concept is OK. You are defining __AVR_INT8__ in two places, which seems redundant. You only need it in one place. The correct place would be the first one in TARGET_CPU_CPP_BUILTINS. The ChangeLog entry isn't correct. You need to list every macro modified, and briefly describe the change. You haven't done this. So it should look something like this * config/avr/avr.h (TARGET_CPU_CPP_BUILTINS): Define __AVR_INT8__ (LONG_LONG_TYPE_SIZE): Check INT_TYPE_SIZE. The patch is OK with these changes. The avr has two listed maintainers, so I included them in the cc's in case they want to comment. I was going to suggest that a doc change was missing, but then I noticed that the -mint8 option isn't documented. Perhaps you could add the missing documentation? Jim