From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7594 invoked by alias); 6 Oct 2004 02:13:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7556 invoked from network); 6 Oct 2004 02:13:07 -0000 Received: from unknown (HELO smtp1.fuse.net) (216.68.8.174) by sourceware.org with SMTP; 6 Oct 2004 02:13:07 -0000 Received: from gx4.fuse.net ([66.42.149.195]) by smtp1.fuse.net (InterMail vM.6.01.03.04 201-2131-111-106-20040729) with ESMTP id <20041006021301.SSXG14841.smtp1.fuse.net@gx4.fuse.net> for ; Tue, 5 Oct 2004 22:13:01 -0400 Received: from dellpi.pinski.fam ([66.42.149.195]) by gx4.fuse.net (InterMail vG.1.00.00.00 201-2136-104-20040331) with ESMTP id <20041006021300.SNNL746.gx4.fuse.net@dellpi.pinski.fam>; Tue, 5 Oct 2004 22:13:00 -0400 Received: from [10.0.0.80] (zhivago.i.pinski.fam [10.0.0.80]) by dellpi.pinski.fam (8.12.2/8.12.1) with ESMTP id i962D0VT000083; Tue, 5 Oct 2004 22:13:01 -0400 (EDT) In-Reply-To: <1097015702.22266.583.camel@localhost.localdomain> References: <2852718A-1614-11D9-81C0-000A95D692F4@physics.uc.edu> <1097015702.22266.583.camel@localhost.localdomain> Mime-Version: 1.0 (Apple Message framework v618) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <3F36926E-173D-11D9-B1A5-000A95D692F4@physics.uc.edu> Content-Transfer-Encoding: 7bit Cc: GCC Patches From: Andrew Pinski Subject: Re: [PATCH] Fix PRs middle-end/15014 and middle-end/16973, removing labels with their address taken Date: Wed, 06 Oct 2004 02:35:00 -0000 To: law@redhat.com X-SW-Source: 2004-10/txt/msg00470.txt.bz2 On Oct 5, 2004, at 6:35 PM, Jeffrey A Law wrote: > If we're going to allow this, then I would strongly recommend > against this approach to the problem. Instead just move > these labels to the start of their nearest following block that > is reachable. Well then you have to fix cfgcleanup which is done using non-tree or non-RTL code. This is much harder than it should be for the problem at hand which is why I picked the method I did. > Inserting arbitrary edges into the CFG is generally bad. Usually it is but this case does not show up too much so really it should not matter that much as I said before. -- Pinski