From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 446473858D39 for ; Wed, 8 Feb 2023 09:45:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 446473858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 620A1FEC; Wed, 8 Feb 2023 01:46:31 -0800 (PST) Received: from [10.57.50.54] (unknown [10.57.50.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 229293F8C6; Wed, 8 Feb 2023 01:45:48 -0800 (PST) Message-ID: <3a08db7e-be26-e3e1-6b1f-c008ab040dda@foss.arm.com> Date: Wed, 8 Feb 2023 09:45:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH][GCC] arm: Optimize arm-mlib.h header inclusion (pr108505). To: Srinath Parvathaneni , gcc-patches@gcc.gnu.org Cc: nd@arm.com, richard.earnshaw@arm.com, kyrylo.tkachov@arm.com References: Content-Language: en-GB From: Richard Earnshaw In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3496.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/01/2023 17:44, Srinath Parvathaneni via Gcc-patches wrote: > Hello, > > I have committed a fix [1] into gcc trunk for a build issue mentioned in pr108505 and > latter received few upstream comments proposing more robust fix for this issue. > > In this patch I'm addressing those comments and sending this as a followup patch. > > Regression tested on arm-none-eabi target and found no regressions. > > Ok for master? > OK. But please correct the syntax for the PR in the subject. It should be "[PR...]" not "(PR...)". R. > [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610513.html > > Regards, > Srinath. > > gcc/ChangeLog: > > 2023-01-27 Srinath Parvathaneni > > PR target/108505 > * config.gcc (tm_mlib_file): Define new variable. > > > ############### Attachment also inlined for ease of reply ############### > > > diff --git a/gcc/config.gcc b/gcc/config.gcc > index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644 > --- a/gcc/config.gcc > +++ b/gcc/config.gcc > @@ -4355,6 +4355,7 @@ case "${target}" in > case ${arm_multilib} in > aprofile|rmprofile) > tmake_profile_file="arm/t-multilib" > + tm_mlib_file="arm/arm-mlib.h" > ;; > @*) > ml=`echo "X$arm_multilib" | sed '1s,^X@,,'` > @@ -4393,7 +4394,7 @@ case "${target}" in > # through to the multilib selector > with_float="soft" > tmake_file="${tmake_file} ${tmake_profile_file}" > - tm_file="$tm_file arm/arm-mlib.h" > + tm_file="$tm_file $tm_mlib_file" > TM_MULTILIB_CONFIG="$with_multilib_list" > fi > fi > > >