From: Rasmus Villemoes <rv@rasmusvillemoes.dk>
To: gcc-patches@gcc.gnu.org
Cc: Vagrant Cascadian <vagrant@debian.org>,
Jonathan Wakely <jwakely.gcc@gmail.com>,
Jakub Jelinek <jakub@redhat.com>,
Joseph Myers <joseph@codesourcery.com>, Jeff Law <law@redhat.com>
Subject: Re: [PATCH] gcc: honour -ffile-prefix-map in ASM_MAP [PR93371]
Date: Mon, 17 Oct 2022 12:00:21 +0200 [thread overview]
Message-ID: <3a36b694-348b-05d1-b3c9-699c627aee20@rasmusvillemoes.dk> (raw)
In-Reply-To: <49ad2c54-f179-3ef2-a0ce-85ec842da416@rasmusvillemoes.dk>
On 27/09/2022 08.54, Rasmus Villemoes wrote:
> On 12/09/2022 11.46, Rasmus Villemoes wrote:
>> On 29/08/2022 11.29, Rasmus Villemoes wrote:
>>> -ffile-prefix-map is supposed to be a superset of -fmacro-prefix-map
>>> and -fdebug-prefix-map. However, when building .S or .s files, gas is
>>> not called with the appropriate --debug-prefix-map option when
>>> -ffile-prefix-map is used.
>>>
>>> While the user can specify -fdebug-prefix-map when building assembly
>>> files via gcc, it's more ergonomic to also support -ffile-prefix-map;
>>> especially since for .S files that could contain the __FILE__ macro,
>>> one would then also have to specify -fmacro-prefix-map.
>>>
>>> gcc:
>>> PR driver/93371
>>> * gcc.cc (ASM_MAP): Honour -ffile-prefix-map.
>>> ---
>>>
>>> I've tested that this works as expected, both by looking at how gas is
>>> now invoked, and by running 'strings' on the generated .o file. But I
>>> don't know how to add something to the testsuite for this.
>>
>> Is this ok for trunk? If so, how about older maintained branches?
>>
>> And does anyone have ideas for how I could add a test case?
>
> ping.
>
ping^2
next prev parent reply other threads:[~2022-10-17 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 9:29 Rasmus Villemoes
2022-09-12 9:46 ` Rasmus Villemoes
2022-09-27 6:54 ` Rasmus Villemoes
2022-10-17 10:00 ` Rasmus Villemoes [this message]
2022-11-01 20:11 ` Jeff Law
2022-11-02 12:35 ` Rasmus Villemoes
2022-11-02 15:45 ` Jeff Law
2022-11-03 13:29 ` Rasmus Villemoes
2022-11-16 3:50 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a36b694-348b-05d1-b3c9-699c627aee20@rasmusvillemoes.dk \
--to=rv@rasmusvillemoes.dk \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=jwakely.gcc@gmail.com \
--cc=law@redhat.com \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).