public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nathan Sidwell <nathan@acm.org>
To: Nathaniel Shead <nathanieloshead@gmail.com>, gcc-patches@gcc.gnu.org
Cc: Jason Merrill <jason@redhat.com>
Subject: Re: [PATCH] c++: Set DECL_CONTEXT for __cxa_thread_atexit [PR99187]
Date: Sun, 19 Nov 2023 16:46:21 -0500	[thread overview]
Message-ID: <3a45b8a2-38fa-40fa-9664-b09505d46fc3@acm.org> (raw)
In-Reply-To: <65568c2d.170a0220.3ebfe.69ad@mx.google.com>

On 11/16/23 16:39, Nathaniel Shead wrote:
> Bootstrapped and regtested on x86_64-pc-linux-gnu. I don't have write
> access.
> 
> -- >8 --
> 
> Modules streaming requires DECL_CONTEXT to be set on declarations that
> are streamed. This ensures that __cxa_thread_atexit is given translation
> unit context much like is already done with many other support
> functions.
> 
> 	PR c++/99187
> 
> gcc/cp/ChangeLog:
> 
> 	* cp-tree.h (enum cp_tree_index):
> 	(thread_atexit_node):
> 	* decl.cc (get_thread_atexit_node):
> 
> gcc/testsuite/ChangeLog:
> 
> 	* g++.dg/modules/pr99187.C: New test.
> 
> Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>

thanks, I've committed it for you.

nathan

-- 
Nathan Sidwell


      reply	other threads:[~2023-11-19 21:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 21:39 Nathaniel Shead
2023-11-19 21:46 ` Nathan Sidwell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a45b8a2-38fa-40fa-9664-b09505d46fc3@acm.org \
    --to=nathan@acm.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=nathanieloshead@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).