From: Martin Sebor <msebor@gmail.com>
To: Jozef Lawrynowicz <jozef.l@somniumtech.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)
Date: Thu, 18 May 2017 16:08:00 -0000 [thread overview]
Message-ID: <3a467726-4d3a-ac42-83e4-6758116735c7@gmail.com> (raw)
In-Reply-To: <CAG7Dreagw3nVE9w8Wa=CerM0xcC1UT8xSQb_GfSVe03aBGpjrA@mail.gmail.com>
On 05/17/2017 09:45 AM, Jozef Lawrynowicz wrote:
> Add warning to back end and add test.
>
> Patch is attached.
>
> If the patch is acceptable, I would appreciate if someone could commit
> it for me as I do not have write access.
>
> 2017-05-XX Jozef Lawrynowicz <jozef.l@somniumtech.com>
> gcc/
> PR target/78818
> * config/msp430/msp430.c (msp430_unique_section): Warn if .persistent
> attribute is used on an automatic variable.
+ if (!message && TREE_NAME_EQ (name, ATTR_PERSIST) && !TREE_STATIC (*
node)
+ && !TREE_PUBLIC (* node) && !DECL_EXTERNAL (* node))
+ message = "%qE attribute has no effect on automatic variables";
In code like this (both existing and new) where the format string
is being assigned to a pointer that is then passed to one of the
diagnostic functions, I believe the string literal needs to wrapped
in G_() so that it can be translated.
Martin
next prev parent reply other threads:[~2017-05-18 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 15:47 Jozef Lawrynowicz
2017-05-18 16:08 ` Martin Sebor [this message]
2017-05-18 18:05 Jozef Lawrynowicz
2017-05-30 11:51 Nick Clifton
2017-06-08 15:50 ` Jozef Lawrynowicz
2017-06-13 15:54 ` Nick Clifton
2017-06-13 17:46 ` Jozef Lawrynowicz
2017-06-15 13:39 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a467726-4d3a-ac42-83e4-6758116735c7@gmail.com \
--to=msebor@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jozef.l@somniumtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).