* Re: [Patch, libgfortran] Inquire internal unit within child dtio procedure
@ 2016-10-05 13:47 Dominique d'Humières
2016-10-05 14:52 ` Jerry DeLisle
0 siblings, 1 reply; 3+ messages in thread
From: Dominique d'Humières @ 2016-10-05 13:47 UTC (permalink / raw)
To: jvdelisle; +Cc: fortran, gcc-patches List
Dear Jerry,
> Committed as trivial.
Many things are trivial unless noted otherwise! The patch causes the following failures:
FAIL: gfortran.dg/inquire_13.f90 -O0 execution test
FAIL: gfortran.dg/inquire_15.f90 -O0 execution test
FAIL: gfortran.dg/inquire_6.f90 -O0 execution test
FAIL: gfortran.dg/inquire_9.f90 -O0 execution test
FAIL: gfortran.dg/large_unit_2.f90 -O0 execution test
FAIL: gfortran.dg/make_unit.f90 -O0 execution test
FAIL: gfortran.dg/negative_unit.f -O0 execution test
FAIL: gfortran.dg/negative_unit_int8.f -O0 execution test
FAIL: gfortran.dg/pr20950.f -O0 execution test
see, e.g., https://gcc.gnu.org/ml/gcc-testresults/2016-10/msg00375.html.
Also the test gfortran.dg/dtio_15.f90 succeeds even with revision r240768 reverted.
Thanks for working on the issue while waiting for the four character fix!
Dominique
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch, libgfortran] Inquire internal unit within child dtio procedure
2016-10-05 13:47 [Patch, libgfortran] Inquire internal unit within child dtio procedure Dominique d'Humières
@ 2016-10-05 14:52 ` Jerry DeLisle
0 siblings, 0 replies; 3+ messages in thread
From: Jerry DeLisle @ 2016-10-05 14:52 UTC (permalink / raw)
To: Dominique d'Humières; +Cc: fortran, gcc-patches List
On 10/05/2016 06:47 AM, Dominique d'Humières wrote:
> Dear Jerry,
>
>> Committed as trivial.
>
> Many things are trivial unless noted otherwise! The patch causes the following failures:
>
> FAIL: gfortran.dg/inquire_13.f90 -O0 execution test
> FAIL: gfortran.dg/inquire_15.f90 -O0 execution test
> FAIL: gfortran.dg/inquire_6.f90 -O0 execution test
> FAIL: gfortran.dg/inquire_9.f90 -O0 execution test
> FAIL: gfortran.dg/large_unit_2.f90 -O0 execution test
> FAIL: gfortran.dg/make_unit.f90 -O0 execution test
> FAIL: gfortran.dg/negative_unit.f -O0 execution test
> FAIL: gfortran.dg/negative_unit_int8.f -O0 execution test
> FAIL: gfortran.dg/pr20950.f -O0 execution test
>
> see, e.g., https://gcc.gnu.org/ml/gcc-testresults/2016-10/msg00375.html.
>
> Also the test gfortran.dg/dtio_15.f90 succeeds even with revision r240768 reverted.
>
> Thanks for working on the issue while waiting for the four character fix!
>
> Dominique
>
My haste got me. I did regression test so I must have done something wrong when
I ran the tests, maybe in the wrong build directory, I only have about 10 of
them here.
I am pretty sure I know whats wrong so will fix it shortly.
Jerry
Jerry
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Patch, libgfortran] Inquire internal unit within child dtio procedure
@ 2016-10-05 4:50 JerryD
0 siblings, 0 replies; 3+ messages in thread
From: JerryD @ 2016-10-05 4:50 UTC (permalink / raw)
To: fortran; +Cc: GCC Patches
Committed as trivial. Reported on c.l.f Regression tested on x86-64.
Regards,
Jerry
2016-10-04 Jerry DeLisle <jvdelisle@gcc.gnu.org>
io/inquire.c (inquire_via_unit): Add check for internal unit
passed into child IO procedure.
2016-10-04 Jerry DeLisle <jvdelisle@gcc.gnu.org>
* gfortran.dg/dtio_15.f90: New test.
r240766 = d59520df9fe83f1a9aea7e766cef52bf6ec790df (refs/remotes/svn/trunk)
A gcc/testsuite/gfortran.dg/dtio_15.f90
M libgfortran/ChangeLog
M libgfortran/io/inquire.c
diff --git a/libgfortran/io/inquire.c b/libgfortran/io/inquire.c
index 2bb518b6..7751b8df 100644
--- a/libgfortran/io/inquire.c
+++ b/libgfortran/io/inquire.c
@@ -41,7 +41,9 @@ inquire_via_unit (st_parameter_inquire *iqp, gfc_unit * u)
const char *p;
GFC_INTEGER_4 cf = iqp->common.flags;
- if (iqp->common.unit == GFC_INTERNAL_UNIT || iqp->common.unit ==
GFC_INTERNAL_UNIT4)
+ if (iqp->common.unit == GFC_INTERNAL_UNIT ||
+ iqp->common.unit == GFC_INTERNAL_UNIT4 ||
+ u->internal_unit_kind != 0)
generate_error (&iqp->common, LIBERROR_INQUIRE_INTERNAL_UNIT, NULL);
if ((cf & IOPARM_INQUIRE_HAS_EXIST) != 0)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-05 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-05 13:47 [Patch, libgfortran] Inquire internal unit within child dtio procedure Dominique d'Humières
2016-10-05 14:52 ` Jerry DeLisle
-- strict thread matches above, loose matches on Subject: below --
2016-10-05 4:50 JerryD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).