From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A8E97395BC17 for ; Thu, 27 May 2021 17:40:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A8E97395BC17 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-kOmSb_-2M-KZD1QTdGxf-g-1; Thu, 27 May 2021 13:40:38 -0400 X-MC-Unique: kOmSb_-2M-KZD1QTdGxf-g-1 Received: by mail-qt1-f198.google.com with SMTP id u3-20020a05622a0103b02902274c59d552so568590qtw.23 for ; Thu, 27 May 2021 10:40:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5XRyNCPjIKT37qzEgwGnrLHhuZ5OLm0HqSuixJ/f1jY=; b=PsUmDwbyvxg+46JgXd1bYSmzk86bDvn8Q2U4qGnRUNU+8LCSBTZ05NZXD4xwbdV57X oiZKPTvKIRhBy3aZCfWLC0eaUv9BDo8YMOHNRDA1GYwyH4/6k6i20dj0IXg3VxK1YYYu MVSYhyuP6tNnBNMNSX/bFlAVS0ty8gSqGEVvJtChZNgMBt1PTJsNxFUYyBGreKQ4z0Ct BAxA4R7qMF0155G0OKA8VT8DUC/D2bGoiADCiJh2n68EaQ1Mow4Dm04MWOXcNe9HJi1e qnpVwCoeC3Yqq2Lvo/yjUJEPp2NP+c0BoQTlZ/zU2m+CHTmq2kasm8ozNeKOh2gTqieg bBRw== X-Gm-Message-State: AOAM530WlBbC+dIqhDoHmZYp3aXS0JrZua4nYN+ITZGUBDAdHWW8z9QK /Xnrlsq08XYKReAZEDuFySXaswfqsb/za7gx6ZCzBNbpMcgo4C2jDh1FJiRgV/DhwYxKd+036D5 YWZGKoDDrCeNImW8Ty3XkgdnhlqpSj6fD8HMF2EEuuiv/l6cZWHgZUdtG4hRraS8Kqw== X-Received: by 2002:a05:622a:4a:: with SMTP id y10mr4173845qtw.230.1622137237804; Thu, 27 May 2021 10:40:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyygC9ELeZvoJOxpMzUsdiayW/ZodtmPvFsdbeSVoMb/1Z3rwk5MRBsLUMJzSyjJXQB4+u0GA== X-Received: by 2002:a05:622a:4a:: with SMTP id y10mr4173816qtw.230.1622137237471; Thu, 27 May 2021 10:40:37 -0700 (PDT) Received: from [192.168.1.148] ([130.44.159.43]) by smtp.gmail.com with ESMTPSA id m10sm1734651qtq.62.2021.05.27.10.40.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 10:40:36 -0700 (PDT) Subject: Re: [PATCH] c++: parameter pack inside static_assert [PR99893] To: Patrick Palka , gcc-patches@gcc.gnu.org References: <20210527150517.3398785-1-ppalka@redhat.com> From: Jason Merrill Message-ID: <3a55d16f-c12f-2ff9-bf64-85501ada8d71@redhat.com> Date: Thu, 27 May 2021 13:40:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210527150517.3398785-1-ppalka@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2021 17:40:42 -0000 On 5/27/21 11:05 AM, Patrick Palka wrote: > Here, we're not finding the parameter pack inside the static_assert because > STATIC_ASSERT trees are tcc_exceptional, and we weren't explicitly walking > them in cp_walk_subtrees. > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for > trunk? OK. > gcc/cp/ChangeLog: > > PR c++/99893 > * tree.c (cp_walk_subtrees) : New case. > > gcc/testsuite/ChangeLog: > > PR c++/99893 > * g++.dg/cpp0x/static_assert17.C: New test. > --- > gcc/cp/tree.c | 5 +++++ > gcc/testsuite/g++.dg/cpp0x/static_assert17.C | 9 +++++++++ > 2 files changed, 14 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/cpp0x/static_assert17.C > > diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c > index 372d89fa9ed..fec5afaa2be 100644 > --- a/gcc/cp/tree.c > +++ b/gcc/cp/tree.c > @@ -5446,6 +5446,11 @@ cp_walk_subtrees (tree *tp, int *walk_subtrees_p, walk_tree_fn func, > } > break; > > + case STATIC_ASSERT: > + WALK_SUBTREE (STATIC_ASSERT_CONDITION (*tp)); > + WALK_SUBTREE (STATIC_ASSERT_MESSAGE (*tp)); > + break; > + > default: > return NULL_TREE; > } > diff --git a/gcc/testsuite/g++.dg/cpp0x/static_assert17.C b/gcc/testsuite/g++.dg/cpp0x/static_assert17.C > new file mode 100644 > index 00000000000..64843c60edd > --- /dev/null > +++ b/gcc/testsuite/g++.dg/cpp0x/static_assert17.C > @@ -0,0 +1,9 @@ > +// PR c++/99893 > +// { dg-do compile { target c++11 } } > + > +void f(...); > + > +template > +void g() { > + f([] { static_assert(Ts::value, ""); }...); > +} >