From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A00663858D20 for ; Wed, 27 Mar 2024 14:21:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A00663858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A00663858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711549311; cv=none; b=FBQPImsQ/c1Chlcro0GM78Blg94X3a7o/baG8eZa1kVbP24mCf23HtRDVT8HggZnw6nmnDCUmJRYTa+TD5XKIJWhQKhmggFcJEKFa7jW3q5IovyhBMfJ9JhyhJCHhoFTTF1z4kf3ks7FDaSfHjABaans5KyuLyEM/AP9V17lvU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711549311; c=relaxed/simple; bh=tgk4RipxwNGtvY6ekjnTC4f2kbYkbX7jF7jauyQNcvg=; h=DKIM-Signature:From:Date:To:Subject:Message-ID:MIME-Version; b=w+4ZgvIdRs8PV460ehm6qlHm59wA7y3nmRix2X2zyfJ+Ji5pQW5UK5r1AeNMOYEtbTK2j6IEsB8MTyNK7m+IHVcBNRlfTJSMYaE4VhlZskud37olWxiPH+pk2GA61BBhsAVNVwcbUjBqUDmfRaiAT0zF0yKlgVhSce7O9nIZwvk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711549309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BR9T1089iwP4tkJvOsBpC+CQrHjkwRHNSG1Yg376/YE=; b=MwBs8YQuVc092ASCNJoFwQozq4IC7byAYq5Nv+OkIe7kuXuLv1cp5T/gn1kCmK0nKCgpxF 5K2ClWm1OdoZoKCPui+CLhEH7kCpSSyIB4SDtCn4c22++BRjDw18hrmma5bYmrLkHCISQn 1nn2Zj7hB+1xTbc6W1LfBRouY325FRc= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-wNioV7JRNo6pCKPhYY4vvQ-1; Wed, 27 Mar 2024 10:21:47 -0400 X-MC-Unique: wNioV7JRNo6pCKPhYY4vvQ-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-789dade2871so796976585a.3 for ; Wed, 27 Mar 2024 07:21:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711549307; x=1712154107; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BR9T1089iwP4tkJvOsBpC+CQrHjkwRHNSG1Yg376/YE=; b=uALqaGH5JGKt0UOO0pS5UhMM2XiOuu6OKel3N+bBhKQXcR/+w59RNmKDb6kvlqReJo Kn7IX7vXOjNJ1/unuR8SP+fPz8R5pybH8HWk5mLNJKx5wdUSbxoAwHipvtw1J3L9qpKd mLUeN3F6z3xmWMPEsw/6MAsU+wmbR8vtmOFQtCRYYtywuHNxzQvJEvS2/RaeQKG3fJnC AYe/4TVqeTO7Ij1z4ZCIU2EnwBMeiVosVhJHTG8rRpoi7dMtH1ol4OAMMQwnFBvcJMrh qCTD7Xv54M5sO8DDzbNRYwqVhhT5s2u6BP59bAMCyrw+mjbjOivm4mRiSoiSrPggl0T+ 7Auw== X-Gm-Message-State: AOJu0Yx5kyXV7bgFxfbfg34bklDc1QyrSh6GG2Fx0e7OzV86iW4K/uMy nG9k9wq2TF4Ec8IErQ7TiqaKArMWBgw2pVnIbMTOWJiC+NiFOv0d+LhCnhU8sPxCvnOQnBF8qqq h3ChyG20F/qQ3nZTkVsrjJSzPWWaq/u9lBzjtimZlHtfXjy/5YniOOlw= X-Received: by 2002:ac8:5a06:0:b0:431:82d3:2701 with SMTP id n6-20020ac85a06000000b0043182d32701mr945748qta.42.1711549307373; Wed, 27 Mar 2024 07:21:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbYtaj7g0DQvszFaWSiIItu5g7Kdc6IPaMvhD66oxqnUIZ0YiNQDE6UwNSXYaq/oiZqX8LQA== X-Received: by 2002:ac8:5a06:0:b0:431:82d3:2701 with SMTP id n6-20020ac85a06000000b0043182d32701mr945725qta.42.1711549306985; Wed, 27 Mar 2024 07:21:46 -0700 (PDT) Received: from [192.168.1.130] (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id fj7-20020a05622a550700b0042f3e288807sm4778976qtb.95.2024.03.27.07.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 07:21:46 -0700 (PDT) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Wed, 27 Mar 2024 10:21:45 -0400 (EDT) To: centurion cc: "gcc-patches@gcc.gnu.org" , jason@redhat.com Subject: Re: [PATCH] c++: fix alias CTAD [PR114377] In-Reply-To: Message-ID: <3aa96b37-96df-7070-f842-c0b1c65df17a@idea> References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 25 Mar 2024, centurion wrote: > From b34312d82b236601c348382d30e625558f37d40c Mon Sep 17 00:00:00 2001 > From: centurion > Date: Mon, 25 Mar 2024 01:57:21 +0400 > Subject: [PATCH] c++: fix alias CTAD [PR114377] > > PR c++/114377 > > gcc/cp/ChangeLog: > > PR c++/114377 > * pt.cc (find_template_parameter_info::found): Use TREE_TYPE for > TEMPLATE_DECL instead of DECL_INITIAL. Makes sense, this is consistent with e.g. template_parm_to_arg. LGTM! > > gcc/testsuite/ChangeLog: > > * g++.dg/cpp2a/class-deduction-alias19.C: New test. > --- > gcc/cp/pt.cc | 3 ++- > .../g++.dg/cpp2a/class-deduction-alias19.C | 15 +++++++++++++++ > 2 files changed, 17 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/g++.dg/cpp2a/class-deduction-alias19.C > > diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc > index 8cf0d5b7a8d..d8a02f1cd7f 100644 > --- a/gcc/cp/pt.cc > +++ b/gcc/cp/pt.cc > @@ -11032,7 +11032,8 @@ find_template_parameter_info::found (tree parm) > { > if (TREE_CODE (parm) == TREE_LIST) > parm = TREE_VALUE (parm); > - if (TREE_CODE (parm) == TYPE_DECL) > + if (TREE_CODE (parm) == TYPE_DECL > + || TREE_CODE(parm) == TEMPLATE_DECL) Style note: there should be a space before the ( of a function/macro call > parm = TREE_TYPE (parm); > else > parm = DECL_INITIAL (parm); > diff --git a/gcc/testsuite/g++.dg/cpp2a/class-deduction-alias19.C b/gcc/testsuite/g++.dg/cpp2a/class-deduction-alias19.C > new file mode 100644 > index 00000000000..1ea79bd7691 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/cpp2a/class-deduction-alias19.C > @@ -0,0 +1,15 @@ > +// PR c++/114377 > +// { dg-do compile { target c++20 } } > + > +template