From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id C843B38582B7 for ; Tue, 7 Nov 2023 00:11:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C843B38582B7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C843B38582B7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::129 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699315922; cv=none; b=VuUUKDlHkkkIB7HFWUjVuk9+X+eGRQikcN1aqQ0stIg8XL2Xf6TYtrpTtxOeB7TVravycwVFKmoiCplvVsKWXTjgH5aaoQQntp0P7cRRcIfzRn8KWKj01xM9IntfoYfEKuHicWnUZ1Q7Y+SscsAjc1mSnIMi2ij9qoof6hljhlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699315922; c=relaxed/simple; bh=cuzNeOjgvHNekp7XN02/jIYCBsvH9jE8Pir7j/dV5sA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rssgNKl2aCXn4SbFnMM0phlVdePEVfa+tws1YiKCCB8H/E9B1ajhWrONw/CxFh5iq4HgaqR0cdPoNhCQpT/UAQRJBfwH8NbZeBK/KpOJ5Dbih+uKC3/a2F5CsMvnHeR8tKxYoTsMSrY/Ly8TfcAeUiKxVC8Jq2OAPS/frNlColw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-3576e74ae9dso17644225ab.3 for ; Mon, 06 Nov 2023 16:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699315918; x=1699920718; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fWd6qJ8QNDbyJFwypyWgA3yFdZaJb0J1zmytAHZyuw4=; b=EPby83WCSemcb5xUtkzjtRH4YE+p9GJ6gj4vsT4g5rKD8H/Fk0YbHsJU+zYvGYhAwO gei0VdkOpS/kxpZlVo6wS5nAz36wIjWUEJlVkd8ZMecL3YpfF9oaRdfKqEUTBfFsrpUL NKimFmrUPl3g91RHPl8JScQSbalym9TiyKtE10ZFpZ1Rq2v7fn1VjV76v/hOKzSxVLps b5Psf7aj020fqIL/Ewycv5MtH3Pmgn9CXTArikIQx2D0v8UfvCX00rdEgyBtZRFSfFvn IrjPSfbJ0vBSKvd3FvyDLmaLTBQIk/gWnR3T4spTsMQP6UZySLEBOfNZrUvynW/CAYUR Zm8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699315918; x=1699920718; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fWd6qJ8QNDbyJFwypyWgA3yFdZaJb0J1zmytAHZyuw4=; b=Hj5/pYjDbHv0zPCJf98sO2oVbamPVUFg79a/e0v2Tti3STtcHgVPRtsIzBrL1gWhNt UL//nW+MI0JsXP3EJLhUECpzEHXHRUbCbDTO9CcvGE/zoFwFgofemKgdJBWnIJXI7E5r K30UUdP1Z3b6WTv+3b/gavyortBd+ggrEgz7GMNfBXsAt36fwOg7N+EPngFOLMJUxYEN cRD6gtL2FBjNfYiE/XnymyZ5IMyYfMQU8GV8fQ37+W5j1jRuVVn1x3SMRa0yQPUluP8u mCY+GohBD9IYDSvzDaSm55T4j7J5dETji0C7j3XLm7okWPFlUb5IT4frqxkCfsK5ivNI FShQ== X-Gm-Message-State: AOJu0YybVw4wkFf7zBQ0sW/wP0dgOI28ILIv6FVFXkz2qd8GOOrSg2Eq D/EO+rAkfx2Pmwfwjn/8zi/slwMxxUlDvw== X-Google-Smtp-Source: AGHT+IFFTnJ+oauiz8fkL4ykm52lgDPttf+jA83qXLKi87Z0svy54dNUS1XBwnf9WotNwP3EGAkEmA== X-Received: by 2002:a05:6e02:1b85:b0:359:442a:426a with SMTP id h5-20020a056e021b8500b00359442a426amr1541785ili.8.1699315917986; Mon, 06 Nov 2023 16:11:57 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id r2-20020a92cd82000000b00357f657cbbdsm2801501ilb.30.2023.11.06.16.11.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Nov 2023 16:11:57 -0800 (PST) Message-ID: <3aaf8797-8a7d-43b2-b39d-177075a0a9a8@gmail.com> Date: Mon, 6 Nov 2023 17:11:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/12] mode-switching: Add note problem Content-Language: en-US To: gcc-patches@gcc.gnu.org, jlaw@ventanamicro.com, richard.sandiford@arm.com References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/5/23 11:46, Richard Sandiford wrote: > optimize_mode_switching uses REG_DEAD notes to track register > liveness, but it failed to tell DF to calculate up-to-date notes. > > Noticed by inspection. I don't have a testcase that fails > because of this. > > gcc/ > * mode-switching.cc (optimize_mode_switching): Call > df_note_add_problem. OK. Triggering this would likely be fairly hard, so I'm not going to stress about a testcase. jeff