From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id 31BC13858CDB for ; Sat, 11 Nov 2023 17:51:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 31BC13858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 31BC13858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699725100; cv=none; b=bX+W8PtyG/V8uh+gbnFxUnG9ex5HYl8XvnBL86JYYxiY0yY958UbbVOeaNS0qxufVjDm1rAToTfNXub0HXuk0p2HAn4aq2G5LPu2HIfIKNoLmgkpO1KAQnYTdEy4o4gcl2OthGHoozjndDGYf3Ngz/cBeSepMY51uHhXuU3RHfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699725100; c=relaxed/simple; bh=ij2oOWFqaJfqcAI34gbsLmNhZUzRe06PxiCXnkQNb/o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dN1sbZr8SCCkrV/89sExiTxR7JsD4nesl8K1KV79lJjtLIA9iB4HqFVfl766OqCHbfsbm4lZGQ/WJB6O/rW6d/CA5dTy4450mBkLvtDEnLiDJhKys3s1+Fh8MHcautAuECfhXu6KdIYl4rcW8Y7/nQTGJ67/IQ1l3z/Ol0p8kQY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-7ad1236c419so110604639f.0 for ; Sat, 11 Nov 2023 09:51:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699725098; x=1700329898; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gPEBO1Yp4yhx576gcFjtFLUt4xSqO/JbUGQRTnE725s=; b=lJDbdoDfe0E0QZzzVbrqI27khtZE+y0WLbLZjaS4RiAs4T/Vjk3yPtsaXWv4rilNyz BkqWYG9A5GDlcuUBlkqlpQrzkRIGE0Ky+akMaSOjv1gbpE2qPoZV5X+c/pxFbQjgF5Kw A7Kva7NBL/biOi6xSHIptZtZHyBZaSwJliFC04+ocQbR7IZNEjl2vM2EYEZj4GZ0SodK W5IYa+/cV42pTqtLcuMkCIJqnoocgR4+h3LOpCGwolmUT3Dl2Fb67v3N6m0kelchOC8W CSo3Kw6PRGstpiDpTIFpELu8glDlsfuglX75ucINL+YrH6ZK0zUBMkTAjNoDWqub07BM B/Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699725098; x=1700329898; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gPEBO1Yp4yhx576gcFjtFLUt4xSqO/JbUGQRTnE725s=; b=HB9upSGtkZZ4u8cmnJL1UyykjgsTclfVR0lLk1O6VXqAIqWZhm6YBVjZj3VA+ekP38 GKco9yxXi48S7uy1X2eCe421rXVr6D7eiBun+O+h02d+EHVrYXpk+9PU6uplBg4F+2ep CIGPyRWW2lL4K7gycHWWS9JHMWRgwMOlXBX1fk8Pp/eIIPQRrMGp3bhGKDdR6hW0jp75 /kYH0RPxgWnEYIFlbSGvh5q0Wb6vtAiOGscKUkfUVMh6Y8WV63tbe/sxS+FxcVArKfgk yBr2GuatnB6g+ybNFW3ww11Jbwcu3+UCsjXCPQHfFkoz/Pvp+za15ddWDwJ/UOzoJNW0 msJw== X-Gm-Message-State: AOJu0YwadvDc0ZAivW/pAwjuhABU04OXfldroHkjwU+x3GoNbaPiP4jE hnOZKYYzzFyqVBBBi5n8OoENcVzPaNN4rA== X-Google-Smtp-Source: AGHT+IGUoGlJc+tlHzIu8K2bAkxgOpnZ5iY0NbtqpdnFlIgIb0Ow+21682qF8KIRtROFmvwTqLSwAg== X-Received: by 2002:a6b:e80c:0:b0:787:8fc:75d8 with SMTP id f12-20020a6be80c000000b0078708fc75d8mr2791693ioh.9.1699725098241; Sat, 11 Nov 2023 09:51:38 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id s7-20020a6bdc07000000b0076c569c7a48sm580768ioc.39.2023.11.11.09.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Nov 2023 09:51:37 -0800 (PST) Message-ID: <3ab20bc6-a82b-427e-bb76-ebac7ecfd04e@gmail.com> Date: Sat, 11 Nov 2023 10:51:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] libgcc/m68k: Fixes for soft float Content-Language: en-US To: Keith Packard , gcc-patches@gcc.gnu.org References: <20230823021504.3864764-1-keithp@keithp.com> <9ab8c5e2-806b-4ab2-a4cd-fcce2491e6d9@gmail.com> <87y1f5nltq.fsf@keithp.com> From: Jeff Law In-Reply-To: <87y1f5nltq.fsf@keithp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/10/23 18:02, Keith Packard wrote: > >> I'm largely trusting your reputation on the fpgnulib changes. I won't >> claim to know that code at all. The assembly bits were simple enough >> that I could make out what you were doing relatively easily. > > Thanks for that review -- m68k assembly isn't my strongest language. The > kludge to return pointers in both d1 and a1 was a bit ugly, but seemed > like a much more robust plan than attempting to use different registers > depending on the target ABI... I get by. Things like m68k, hppa, etc have stuck harder than I would have ever imagined. But ppc, alpha, and some of the others I've worked on through the years, not so much. And yes there are ABI implications on the return value. As you know back in the day things weren't typed so well, so varying the location of the return value based on type wasn't terribly safe. Dual output worked around a class of problems. These days varying args/return value location based on types is common. > > The real check for these fixes was to run a fairly comprehensive C > library test suite (part of picolibc) and just iterate until I stopped > getting failures. Those tests have found so many corner cases in both > the C library, FPU emulation and compilers ... Not surprised. Thanks again, Jeff