From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-fw-9103.amazon.com (smtp-fw-9103.amazon.com [207.171.188.200]) by sourceware.org (Postfix) with ESMTPS id 1A7323858C54 for ; Thu, 1 Dec 2022 03:04:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A7323858C54 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=amazon.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1669863896; x=1701399896; h=from:to:cc:subject:date:message-id:mime-version; bh=n44CWie6ZyBARZ6rd7QJxlVSEgggNAG5o0LtzcHGd4A=; b=tJKVG8KzE5Gx5zpHGQNNR4q87VTOyv0F475orchoEej7LHrUqR6IDB0O VKKaxtdLY9RumKsJjLSb3xhUs03R2SxYpOp1Jb3Ard6vylTBW29OhxNNN dFaJdVX3PohBX4xrFssUlIQOpGEBsjwLHVytTr9MGH/xy1v04WHG1iZD0 4=; X-Amazon-filename: 0001-AArch64-Add-UNSPECV_PATCHABLE_AREA-PR98776.patch X-IronPort-AV: E=Sophos;i="5.96,207,1665446400"; d="scan'208,217,223";a="1079125799" Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-pdx-2b-m6i4x-cadc3fbd.us-west-2.amazon.com) ([10.25.36.214]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2022 03:04:53 +0000 Received: from EX13MTAUWC002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2b-m6i4x-cadc3fbd.us-west-2.amazon.com (Postfix) with ESMTPS id E469DA0B77; Thu, 1 Dec 2022 03:04:52 +0000 (UTC) Received: from EX19D001UWB002.ant.amazon.com (10.13.138.54) by EX13MTAUWC002.ant.amazon.com (10.43.162.240) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 1 Dec 2022 03:04:52 +0000 Received: from EX19D001UWB002.ant.amazon.com (10.13.138.54) by EX19D001UWB002.ant.amazon.com (10.13.138.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1118.20; Thu, 1 Dec 2022 03:04:52 +0000 Received: from EX19D001UWB002.ant.amazon.com ([fe80::228:5f96:8949:28b8]) by EX19D001UWB002.ant.amazon.com ([fe80::228:5f96:8949:28b8%7]) with mapi id 15.02.1118.020; Thu, 1 Dec 2022 03:04:52 +0000 From: "Pop, Sebastian" To: "gcc-patches@gcc.gnu.org" CC: "sebpop@gmail.com" , Kyrylo Tkachov , Richard Sandiford Subject: AArch64: Add UNSPECV_PATCHABLE_AREA [PR98776] Thread-Topic: AArch64: Add UNSPECV_PATCHABLE_AREA [PR98776] Thread-Index: AQHZBTCTBfQC3+DIFk6eavlOh3NJyw== Date: Thu, 1 Dec 2022 03:04:52 +0000 Message-ID: <3b2be13be3534681af5a64b8163a3c8c@amazon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.43.162.134] Content-Type: multipart/mixed; boundary="_004_3b2be13be3534681af5a64b8163a3c8camazoncom_" MIME-Version: 1.0 X-Spam-Status: No, score=-17.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_004_3b2be13be3534681af5a64b8163a3c8camazoncom_ Content-Type: multipart/alternative; boundary="_000_3b2be13be3534681af5a64b8163a3c8camazoncom_" --_000_3b2be13be3534681af5a64b8163a3c8camazoncom_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi, Currently patchable area is at the wrong place on AArch64. It is placed immediately after function label, before .cfi_startproc. This patch adds UNSPECV_PATCHABLE_AREA for pseudo patchable area instruction and modifies aarch64_print_patchable_function_entry to avoid placing patchable area before .cfi_startproc. The patch passed bootstrap and regression test on aarch64-linux. Ok to commit to trunk and backport to active release branches? Thanks, Sebastian gcc/ PR target/93492 * config/aarch64/aarch64-protos.h (aarch64_output_patchable_area): Declared. * config/aarch64/aarch64.cc (aarch64_print_patchable_function_entry= ): Emit an UNSPECV_PATCHABLE_AREA pseudo instruction. (aarch64_output_patchable_area): New. * config/aarch64/aarch64.md (UNSPECV_PATCHABLE_AREA): New. (patchable_area): Define. gcc/testsuite/ PR target/93492 * gcc.target/aarch64/pr98776.c: New. --_000_3b2be13be3534681af5a64b8163a3c8camazoncom_-- --_004_3b2be13be3534681af5a64b8163a3c8camazoncom_ Content-Type: text/x-patch; name="0001-AArch64-Add-UNSPECV_PATCHABLE_AREA-PR98776.patch" Content-Description: 0001-AArch64-Add-UNSPECV_PATCHABLE_AREA-PR98776.patch Content-Disposition: attachment; filename="0001-AArch64-Add-UNSPECV_PATCHABLE_AREA-PR98776.patch"; size=4289; creation-date="Thu, 01 Dec 2022 02:57:01 GMT"; modification-date="Thu, 01 Dec 2022 02:57:01 GMT" Content-Transfer-Encoding: base64 RnJvbSBiOWNmODdiY2RmNjVmNTE1YjM4ZjE4NTFlYjk1YzE4YWFhMTgwMjUz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBTZWJhc3RpYW4gUG9w IDxzcG9wQGFtYXpvbi5jb20+CkRhdGU6IFdlZCwgMzAgTm92IDIwMjIgMTk6 NDU6MjQgKzAwMDAKU3ViamVjdDogW1BBVENIXSBBQXJjaDY0OiBBZGQgVU5T UEVDVl9QQVRDSEFCTEVfQVJFQSBbUFI5ODc3Nl0KCkN1cnJlbnRseSBwYXRj aGFibGUgYXJlYSBpcyBhdCB0aGUgd3JvbmcgcGxhY2Ugb24gQUFyY2g2NC4g IEl0IGlzIHBsYWNlZAppbW1lZGlhdGVseSBhZnRlciBmdW5jdGlvbiBsYWJl bCwgYmVmb3JlIC5jZmlfc3RhcnRwcm9jLiAgVGhpcyBwYXRjaAphZGRzIFVO U1BFQ1ZfUEFUQ0hBQkxFX0FSRUEgZm9yIHBzZXVkbyBwYXRjaGFibGUgYXJl YSBpbnN0cnVjdGlvbiBhbmQKbW9kaWZpZXMgYWFyY2g2NF9wcmludF9wYXRj aGFibGVfZnVuY3Rpb25fZW50cnkgdG8gYXZvaWQgcGxhY2luZwpwYXRjaGFi bGUgYXJlYSBiZWZvcmUgLmNmaV9zdGFydHByb2MuCgpnY2MvCglQUiB0YXJn ZXQvOTM0OTIKCSogY29uZmlnL2FhcmNoNjQvYWFyY2g2NC1wcm90b3MuaCAo YWFyY2g2NF9vdXRwdXRfcGF0Y2hhYmxlX2FyZWEpOgoJRGVjbGFyZWQuCgkq IGNvbmZpZy9hYXJjaDY0L2FhcmNoNjQuY2MgKGFhcmNoNjRfcHJpbnRfcGF0 Y2hhYmxlX2Z1bmN0aW9uX2VudHJ5KToKCUVtaXQgYW4gVU5TUEVDVl9QQVRD SEFCTEVfQVJFQSBwc2V1ZG8gaW5zdHJ1Y3Rpb24uCgkoYWFyY2g2NF9vdXRw dXRfcGF0Y2hhYmxlX2FyZWEpOiBOZXcuCgkqIGNvbmZpZy9hYXJjaDY0L2Fh cmNoNjQubWQgKFVOU1BFQ1ZfUEFUQ0hBQkxFX0FSRUEpOiBOZXcuCgkocGF0 Y2hhYmxlX2FyZWEpOiBEZWZpbmUuCgpnY2MvdGVzdHN1aXRlLwoJUFIgdGFy Z2V0LzkzNDkyCgkqIGdjYy50YXJnZXQvYWFyY2g2NC9wcjk4Nzc2LmM6IE5l dy4KLS0tCiBnY2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC1wcm90b3MuaCAg ICAgICAgfCAgMiArKwogZ2NjL2NvbmZpZy9hYXJjaDY0L2FhcmNoNjQuY2Mg ICAgICAgICAgICAgIHwgMjQgKysrKysrKysrKysrKysrKysrKysrLQogZ2Nj L2NvbmZpZy9hYXJjaDY0L2FhcmNoNjQubWQgICAgICAgICAgICAgIHwgMTQg KysrKysrKysrKysrKwogZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FhcmNo NjQvcHI5ODc3Ni5jIHwgMTEgKysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2Vk LCA1MCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9k ZSAxMDA2NDQgZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FhcmNoNjQvcHI5 ODc3Ni5jCgpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZy9hYXJjaDY0L2FhcmNo NjQtcHJvdG9zLmggYi9nY2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC1wcm90 b3MuaAppbmRleCA0YmU5M2M5M2MyNi4uMmZiYTI0ZDk0N2QgMTAwNjQ0Ci0t LSBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LXByb3Rvcy5oCisrKyBi L2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LXByb3Rvcy5oCkBAIC0xMDc0 LDQgKzEwNzQsNiBAQCBjb25zdCBjaGFyICphYXJjaDY0X2luZGlyZWN0X2Nh bGxfYXNtIChydHgpOwogZXh0ZXJuIGJvb2wgYWFyY2g2NF9oYXJkZW5fc2xz X3JldGJyX3AgKHZvaWQpOwogZXh0ZXJuIGJvb2wgYWFyY2g2NF9oYXJkZW5f c2xzX2Jscl9wICh2b2lkKTsKIAorZXh0ZXJuIHZvaWQgYWFyY2g2NF9vdXRw dXRfcGF0Y2hhYmxlX2FyZWEgKHVuc2lnbmVkIGludCwgYm9vbCk7CisKICNl bmRpZiAvKiBHQ0NfQUFSQ0g2NF9QUk9UT1NfSCAqLwpkaWZmIC0tZ2l0IGEv Z2NjL2NvbmZpZy9hYXJjaDY0L2FhcmNoNjQuY2MgYi9nY2MvY29uZmlnL2Fh cmNoNjQvYWFyY2g2NC5jYwppbmRleCBlOTdmM2IzMmY3Yy4uZTg0YjMzYjk1 OGMgMTAwNjQ0Ci0tLSBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LmNj CisrKyBiL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LmNjCkBAIC0yMjY4 NCw3ICsyMjY4NCwyOSBAQCBhYXJjaDY0X3ByaW50X3BhdGNoYWJsZV9mdW5j dGlvbl9lbnRyeSAoRklMRSAqZmlsZSwKICAgICAgIGFzbV9mcHJpbnRmIChm aWxlLCAiXHRoaW50XHQzNCAvLyBidGkgY1xuIik7CiAgICAgfQogCi0gIGRl ZmF1bHRfcHJpbnRfcGF0Y2hhYmxlX2Z1bmN0aW9uX2VudHJ5IChmaWxlLCBw YXRjaF9hcmVhX3NpemUsIHJlY29yZF9wKTsKKyAgaWYgKGNmdW4tPm1hY2hp bmUtPmxhYmVsX2lzX2Fzc2VtYmxlZCkKKyAgICB7CisgICAgICBydHggcGEg PSBnZW5fcGF0Y2hhYmxlX2FyZWEgKEdFTl9JTlQgKHBhdGNoX2FyZWFfc2l6 ZSksCisJCQkJICAgR0VOX0lOVCAocmVjb3JkX3ApKTsKKyAgICAgIGJhc2lj X2Jsb2NrIGJiID0gRU5UUllfQkxPQ0tfUFRSX0ZPUl9GTiAoY2Z1biktPm5l eHRfYmI7CisgICAgICBydHhfaW5zbiAqaW5zbiA9IGVtaXRfaW5zbl9iZWZv cmUgKHBhLCBCQl9IRUFEIChiYikpOworICAgICAgSU5TTl9BRERSRVNTRVNf TkVXIChpbnNuLCAtMSk7CisgICAgfQorICBlbHNlCisgICAgeworICAgICAg ZGVmYXVsdF9wcmludF9wYXRjaGFibGVfZnVuY3Rpb25fZW50cnkgKGZpbGUs IHBhdGNoX2FyZWFfc2l6ZSwKKwkJCQkJICAgICAgcmVjb3JkX3ApOworICAg IH0KK30KKworLyogT3V0cHV0IHBhdGNoYWJsZSBhcmVhLiAgKi8KKwordm9p ZAorYWFyY2g2NF9vdXRwdXRfcGF0Y2hhYmxlX2FyZWEgKHVuc2lnbmVkIGlu dCBwYXRjaF9hcmVhX3NpemUsIGJvb2wgcmVjb3JkX3ApCit7CisgIGRlZmF1 bHRfcHJpbnRfcGF0Y2hhYmxlX2Z1bmN0aW9uX2VudHJ5IChhc21fb3V0X2Zp bGUsCisJCQkJCSAgcGF0Y2hfYXJlYV9zaXplLAorCQkJCQkgIHJlY29yZF9w KTsKIH0KIAogLyogSW1wbGVtZW50IEFTTV9PVVRQVVRfREVGX0ZST01fREVD TFMuICBPdXRwdXQgLnZhcmlhbnRfcGNzIGZvciBhbGlhc2VzLiAgKi8KZGlm ZiAtLWdpdCBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0Lm1kIGIvZ2Nj L2NvbmZpZy9hYXJjaDY0L2FhcmNoNjQubWQKaW5kZXggNzZiNjg5OGNhMDQu LjY1MDE1MDNlYjI1IDEwMDY0NAotLS0gYS9nY2MvY29uZmlnL2FhcmNoNjQv YWFyY2g2NC5tZAorKysgYi9nY2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC5t ZApAQCAtMzAzLDYgKzMwMyw3IEBACiAgICAgVU5TUEVDX1RBR19TUEFDRQkJ OyBUcmFuc2xhdGUgYWRkcmVzcyB0byBNVEUgdGFnIGFkZHJlc3Mgc3BhY2Uu CiAgICAgVU5TUEVDX0xEMVJPCiAgICAgVU5TUEVDX1NBTFRfQUREUgorICAg IFVOU1BFQ1ZfUEFUQ0hBQkxFX0FSRUEKIF0pCiAKIChkZWZpbmVfY19lbnVt ICJ1bnNwZWN2IiBbCkBAIC03ODIxLDYgKzc4MjIsMTkgQEAKICAgWyhzZXRf YXR0ciAidHlwZSIgImxzNjQiKV0KICkKIAorKGRlZmluZV9pbnNuICJwYXRj aGFibGVfYXJlYSIKKyAgWyh1bnNwZWNfdm9sYXRpbGUgWyhtYXRjaF9vcGVy YW5kIDAgImNvbnN0X2ludF9vcGVyYW5kIikKKwkJICAgICAobWF0Y2hfb3Bl cmFuZCAxICJjb25zdF9pbnRfb3BlcmFuZCIpXQorCQkgICAgVU5TUEVDVl9Q QVRDSEFCTEVfQVJFQSldCisgICIiCit7CisgIGFhcmNoNjRfb3V0cHV0X3Bh dGNoYWJsZV9hcmVhIChJTlRWQUwgKG9wZXJhbmRzWzBdKSwKKwkJCSAgICAg ICAgIElOVFZBTCAob3BlcmFuZHNbMV0pICE9IDApOworICByZXR1cm4gIiI7 Cit9CisgIFsoc2V0IChhdHRyICJsZW5ndGgiKSAoc3ltYm9sX3JlZiAiSU5U VkFMIChvcGVyYW5kc1swXSkiKSldCispCisKIDs7IEFkdlNJTUQgU3R1ZmYK IChpbmNsdWRlICJhYXJjaDY0LXNpbWQubWQiKQogCmRpZmYgLS1naXQgYS9n Y2MvdGVzdHN1aXRlL2djYy50YXJnZXQvYWFyY2g2NC9wcjk4Nzc2LmMgYi9n Y2MvdGVzdHN1aXRlL2djYy50YXJnZXQvYWFyY2g2NC9wcjk4Nzc2LmMKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmIwNzViOGY3 NWVmCi0tLSAvZGV2L251bGwKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFy Z2V0L2FhcmNoNjQvcHI5ODc3Ni5jCkBAIC0wLDAgKzEsMTEgQEAKKy8qIHsg ZGctZG8gImNvbXBpbGUiIH0gKi8KKy8qIHsgZGctb3B0aW9ucyAiLU8xIC1m cGF0Y2hhYmxlLWZ1bmN0aW9uLWVudHJ5PTEgLWZhc3luY2hyb25vdXMtdW53 aW5kLXRhYmxlcyIgfSAqLworCisvKiBUZXN0IHRoZSBwbGFjZW1lbnQgb2Yg dGhlIC5MUEZFMCBsYWJlbC4gICovCisKK3ZvaWQKK2ZvbyAodm9pZCkKK3sK K30KKworLyogeyBkZy1maW5hbCB7IHNjYW4tYXNzZW1ibGVyICJcdFwuY2Zp X3N0YXJ0cHJvY1xuLipcLkxQRkUwOlxuXHRub3Bcblx0cmV0XG4iIH0gfSAq LwotLSAKMi4zNy4xCgo= --_004_3b2be13be3534681af5a64b8163a3c8camazoncom_--