From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 70FA9385783A for ; Thu, 27 Aug 2020 02:26:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70FA9385783A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-4qJufKIoO8WHwfS7-dcIVA-1; Wed, 26 Aug 2020 22:26:36 -0400 X-MC-Unique: 4qJufKIoO8WHwfS7-dcIVA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 552C985C733; Thu, 27 Aug 2020 02:26:35 +0000 (UTC) Received: from [10.10.112.61] (ovpn-112-61.rdu2.redhat.com [10.10.112.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2B0660C0F; Thu, 27 Aug 2020 02:26:34 +0000 (UTC) Subject: Re: [PATCH] lra: Canonicalize mult to shift in address reloads To: Alex Coplan Cc: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com References: <20200825101855.clw3dgzfxsgudpzn@arm.com> <20200826151528.snpm6mj7fttc4mwu@arm.com> From: Vladimir Makarov Message-ID: <3bb5b3af-4182-4712-61ae-57f247441774@redhat.com> Date: Wed, 26 Aug 2020 22:26:34 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200826151528.snpm6mj7fttc4mwu@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 02:26:39 -0000 On 2020-08-26 11:15 a.m., Alex Coplan wrote: > Thanks for the review, both. > > > Please find a reworked version of the patch attached incorporating > Richard's feedback. > > Testing: > * Bootstrap and regtest on aarch64-none-linux-gnu, > arm-none-linux-gnueabihf, and x86_64-pc-linux-gnu: no regressions. > > Is the updated patch OK for master? > Yes.  Thank you, Alex.