From: Jeff Law <jeffreyalaw@gmail.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Cleanup back_threader::find_path_to_names.
Date: Fri, 5 Nov 2021 16:38:26 -0600 [thread overview]
Message-ID: <3bf4c6d4-e97b-8203-d7fc-498ab150c77c@gmail.com> (raw)
In-Reply-To: <CAGm3qMUrXPqDy=YYNrxOKf8DO9OsdTYPJ6QBuGqGrt=LifZ93A@mail.gmail.com>
On 11/5/2021 2:44 PM, Aldy Hernandez wrote:
> On Fri, Nov 5, 2021 at 9:06 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>>
>>
>> On 11/5/2021 9:09 AM, Aldy Hernandez wrote:
>>> The main path discovery function was due for a cleanup. First,
>>> there's a nagging goto and second, my bitmap use was sloppy. Hopefully
>>> this makes the code easier for others to read.
>>>
>>> Regstrapped on x86-64 Linux. I also made sure there were no difference
>>> in the number of threads with this patch.
>>>
>>> No functional changes.
>>>
>>> OK?
>>>
>>> gcc/ChangeLog:
>>>
>>> * tree-ssa-threadbackward.c (back_threader::find_paths_to_names):
>>> Remove gotos and other cleanups.
I should have looked closer. The recursive call happens after you have
already tested "done", so yea, removing the return value is trivial.
V2 is OK for the turnk.
Jeff
prev parent reply other threads:[~2021-11-05 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 15:09 Aldy Hernandez
2021-11-05 20:06 ` Jeff Law
2021-11-05 20:44 ` Aldy Hernandez
2021-11-05 22:38 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bf4c6d4-e97b-8203-d7fc-498ab150c77c@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).