From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id EB5C7385AC28 for ; Fri, 5 Nov 2021 22:38:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB5C7385AC28 Received: by mail-pj1-x102d.google.com with SMTP id w9-20020a17090a1b8900b001a6b3b7ec17so4232269pjc.3 for ; Fri, 05 Nov 2021 15:38:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TXbfsOB48wO15Lvc7I03zf7MLBhNrvsEIgfywIGKfIw=; b=sQKIhEeXfoEsyea6kC+Km9PZmoKOr6roLi+ZGbjpH+eBEuxdFwvxpQLsz6Igl01I0q m+3/xmlzf2eTaJB3zfjAzAtIdIJszLpkhKuLgBey4M/yr4NHc/uTkPaRrlPbyPc+yNZo tPdenlAJDBIeYEawvxDzs7sS4wud6GgqCa+bYDmAOXYWd3v3OWrNnQsFJFRqZCDrf8/+ 6JKc6Ta7ACtRXdGUgvXd+37FACst6eJPTBbicGm0BlAhFOJMQOJlntm/yE+ykIOXKG3h C88feumKwtUWD97h3aHa5H3K9LNhC4uqDb9TJTzChsqa3R6kFoDz20wIUlNNqWbXberb yxJg== X-Gm-Message-State: AOAM530uRY2pSPsbLOKs7izsru0g0C266D0C6HsbhQ4kuAf+9XK7+XAC 9zadUjqViwN9/DXzN6vLHeE= X-Google-Smtp-Source: ABdhPJw7/hG3CBZlZXQFPzKqsJIMqiCqwUcc3R0iVrnylgZ9AYaj21Re9hLcJvW0Hv1E20jNSXt7mw== X-Received: by 2002:a17:90a:930c:: with SMTP id p12mr33432005pjo.176.1636151908983; Fri, 05 Nov 2021 15:38:28 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id mr2sm7013835pjb.25.2021.11.05.15.38.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 15:38:28 -0700 (PDT) Message-ID: <3bf4c6d4-e97b-8203-d7fc-498ab150c77c@gmail.com> Date: Fri, 5 Nov 2021 16:38:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] Cleanup back_threader::find_path_to_names. Content-Language: en-US To: Aldy Hernandez Cc: GCC patches References: <20211105150905.37199-1-aldyh@redhat.com> <3d6f6538-e979-2440-18df-632296fb1abd@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2021 22:38:31 -0000 On 11/5/2021 2:44 PM, Aldy Hernandez wrote: > On Fri, Nov 5, 2021 at 9:06 PM Jeff Law wrote: >> >> >> On 11/5/2021 9:09 AM, Aldy Hernandez wrote: >>> The main path discovery function was due for a cleanup. First, >>> there's a nagging goto and second, my bitmap use was sloppy. Hopefully >>> this makes the code easier for others to read. >>> >>> Regstrapped on x86-64 Linux. I also made sure there were no difference >>> in the number of threads with this patch. >>> >>> No functional changes. >>> >>> OK? >>> >>> gcc/ChangeLog: >>> >>> * tree-ssa-threadbackward.c (back_threader::find_paths_to_names): >>> Remove gotos and other cleanups. I should have looked closer.  The recursive call happens after you have already tested "done", so yea, removing the return value is trivial. V2 is OK for the turnk. Jeff