From: Antoni Boucher <bouanto@zoho.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: Antoni Boucher via Jit <jit@gcc.gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libgccjit: add some reflection functions in the jit C api
Date: Fri, 18 Jun 2021 11:55:10 -0400 [thread overview]
Message-ID: <3c328b40570b10b22a8925fd64b2781dc9264358.camel@zoho.com> (raw)
In-Reply-To: <e962387aff72bce1ea29b0fc2cb04b84c26f9855.camel@redhat.com>
Le vendredi 11 juin 2021 à 14:00 -0400, David Malcolm a écrit :
> On Fri, 2021-06-11 at 08:15 -0400, Antoni Boucher wrote:
> > Thank you for your answer.
> > I attached the updated patch.
>
> BTW you (or possibly me) dropped the mailing lists; was that
> deliberate?
Oh, my bad.
> >
> > See my answers below.
> >
> > Le jeudi 10 juin 2021 à 18:41 -0400, David Malcolm a écrit :
> > > On Thu, 2021-05-27 at 21:51 -0400, Antoni Boucher wrote:
> > > > I chose option A, so everything is a size_t, now.
> > > > I also renamed the dyncast functions.
> > > > Here's the new patch.
> > >
> > > Thanks, sorry again about the delays in reviewing your work.
> > >
> > > You didn't specify how you tested the patch; are you running the
> > > full
> > > jit regression test suite?
> >
> > Yes, I run the full jit test suite.
>
> Great.
>
> [...snip...]
>
> > >
> > > I can't remember, sorry, do you have push rights to the gcc git
> > > repository?
> >
> > I don't have push rights; it's actually my first contribution to
> > gcc.
>
> Congratulations! I'm excited about having Rust support for GCC (two
> different ways, in fact!)
Yup. Exciting times!
>
> > I have signed the FSF copyright attribution.
>
> I can push changes on your behalf, but I'd prefer it if you did it,
> especially given that you have various other patches you want to get
> in.
>
> Instructions on how to get push rights to the git repo are here:
> https://gcc.gnu.org/gitwrite.html
>
> I can sponsor you.
Thanks.
I did sign up to get push rights.
Have you accepted my request to get those?
>
> Note that your patches would still need review/approval ("Write After
> Approval").
>
> > > Do you have a preference as to which patch you want me to look at
> > > next?
> > > Otherwise I'll go through them in the order in
> > > https://github.com/antoyo/rustc_codegen_gcc/tree/master/gcc-patches
> >
> > You can indeed look in this directory in the order they were added.
> > There was one patch before the reflection one (0001-This-patch-
> > handles-
> > truncation-and-extension-for-cast.patch), but since it's only a
> > bugfix,
> > it doesn't matter if it's merged after.
>
> That one looks good to me now too (I've replied on that patch).
>
> >
> > This one is ready for review, but I believe the other one needs
> > correction on my end since the last review you made. I'll make sure
> > to
> > fix them soon.
>
> Now I'm confused as to which patches you're referring to, sorry.
> I'll
> hold off for now on further reviews; let me know when you want me to
> look at them, and which ones.
>
> Thanks
> Dave
>
next prev parent reply other threads:[~2021-06-18 15:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 1:01 Antoni Boucher
2020-10-02 20:17 ` David Malcolm
2020-10-02 20:24 ` David Malcolm
2020-10-02 22:39 ` [PATCH] libgccjit: add some reflection functions in the jit C api [PR96889] Antoni Boucher
2020-10-03 18:14 ` [PATCH] libgccjit: add some reflection functions in the jit C api [WIP] Antoni Boucher
2020-10-15 16:02 ` [PATCH] libgccjit: add some reflection functions in the jit C api Antoni Boucher
2020-10-15 16:23 ` Andrea Corallo
2020-10-15 17:39 ` Antoni Boucher
2020-10-15 18:04 ` Andrea Corallo
2020-10-15 21:52 ` David Malcolm
2020-10-17 0:41 ` Antoni Boucher
2020-11-03 22:13 ` Antoni Boucher
2021-05-13 8:33 ` Martin Liška
2021-05-13 21:30 ` David Malcolm
2021-05-14 2:11 ` Antoni Boucher
2021-05-26 0:19 ` Antoni Boucher
2021-05-27 22:19 ` David Malcolm
2021-05-28 1:51 ` Antoni Boucher
2021-06-10 22:41 ` David Malcolm
[not found] ` <bc9e81dc3f0a68d6389c9765b5901a5dbd1dcd71.camel@zoho.com>
[not found] ` <e962387aff72bce1ea29b0fc2cb04b84c26f9855.camel@redhat.com>
2021-06-18 15:55 ` Antoni Boucher [this message]
2021-06-18 16:09 ` David Malcolm
2021-06-18 19:41 ` Antoni Boucher
2021-06-18 20:37 ` David Malcolm
2021-07-19 16:10 ` Antoni Boucher
2021-07-29 12:59 ` Antoni Boucher
2021-08-31 12:34 ` Antoni Boucher
2021-09-28 0:53 ` Antoni Boucher
2021-10-13 2:09 ` Antoni Boucher
2021-10-23 21:08 ` SV: " Petter Tomner
2021-11-14 21:30 ` Antoni Boucher
2021-11-20 0:53 ` David Malcolm
2021-11-26 18:03 ` Gerald Pfeifer
2021-11-26 19:51 ` Gerald Pfeifer
[not found] ` <91ecd9dd299e4d61903b2995d8c64a09@kth.se>
2021-12-02 18:04 ` Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c328b40570b10b22a8925fd64b2781dc9264358.camel@zoho.com \
--to=bouanto@zoho.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).