From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9FD503858CD1 for ; Fri, 8 Dec 2023 23:36:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FD503858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9FD503858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702078562; cv=none; b=okv0s0oexUZ91ZqPkQVl+w29v4RDKEYysjahWjAqs9Isx0SDxC9LGWRocze+6r0MMUrMGc3kW+3qMjc71/ytzv9szvqrQTbMIFGkCR2BtrNJU0PBZjzRS5tmpvWMdbjSUEIQonLR9fDmRrDypHxCp6NxoUc8sqa6yS3xyJCEiJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702078562; c=relaxed/simple; bh=JZu4j95gUgiBHCObZt1W1EHPiwmCi4lZXrmqWoEajUw=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=T8KXFXIePRs0ZRqsZuVPnkiQGU+aKHEL6lO0/kGU0Ww5s/HJOHLW4s1CPXv35VnMryt1TsNSjoEnYBXIi4A4vlhrQIzKAr2F8ueuFiACD+pR2lHfgOzV0gRDhZJHP9Su7ME7BOA3lOnwEz4QKmKEJrvdRURri4GeN9nmey0+Vyw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702078560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2qF0jmA7FB1vg3E6QtMod3HiKuQqE/0Ddddy0ujvm7E=; b=P7YD4us3RfVEy63wmXgH0f6xJKDx8XacoDZFG2zlOJJrHxWsIORmOBMiRCapsD7xxcBUPx miEXUpBp0DX4GgjUStCkMh7pSzIhUtLSp+pMlmuUOnqVOIZdoY/FgVDKD+YdfMZ+eUUXXX K36qu7KK2ME0PgSEHjMxhWSAgwArSz0= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-fMqnwykhOtKgONZ76mwHAQ-1; Fri, 08 Dec 2023 18:35:58 -0500 X-MC-Unique: fMqnwykhOtKgONZ76mwHAQ-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-77efd96a03fso260710985a.1 for ; Fri, 08 Dec 2023 15:35:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702078558; x=1702683358; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2qF0jmA7FB1vg3E6QtMod3HiKuQqE/0Ddddy0ujvm7E=; b=PwEeLLcHeGxyY/SelzDFhWbTVdcOzbKI+bravUB2VRwnx2otZPFZJiL06Af/lBLw0Z WJyOjagSxD44mPWpxypMjEJRY68n0OToq31l7ZTjAapUKc5364xCi8RbrhKXJrD9UgWS KUP/g8lhyIzuKcYQ7jOz0B1B01mq9JH9l/rkc00UkPQa8DhPO71QRI8RSDT9t1CTsHD3 TWyVi8x6Cy0ghbuXUPEqY+10GMzksy2EneEu0rBNtuXVwR8f8V6K7NT5hJHTHNKdN0ba ZOtJmLJ+Fmgux6MsHqW4KrqRe9CnTjrFoZcFtiKW34ffD9BoTPnvzRXFHIRmNJaRqJWZ fOQA== X-Gm-Message-State: AOJu0Yw7xzeexDtuvticYjha7kSP1JWiSx06eCTMQGTInz9M7HVP5L1U kc4kqglTIYDeLXHYq8XmC9XJomccB0mvhEA9gp43c/0ASWKGqPzWeVvcD1VIuKQNpzXR3mREHjZ ZDZKjv4l4lBxuM286kQ== X-Received: by 2002:a05:620a:55b4:b0:77f:1362:8648 with SMTP id vr20-20020a05620a55b400b0077f13628648mr849913qkn.73.1702078558353; Fri, 08 Dec 2023 15:35:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbV8+eIIO3BWnJKsapYdX4XTw5MSePablHWluGwc+NTm6dzw9Uen0h54z2KsmFnwaOmeJKBw== X-Received: by 2002:a05:620a:55b4:b0:77f:1362:8648 with SMTP id vr20-20020a05620a55b400b0077f13628648mr849907qkn.73.1702078557979; Fri, 08 Dec 2023 15:35:57 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id q23-20020ae9e417000000b0077d8526bcdesm1032289qkc.86.2023.12.08.15.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 15:35:57 -0800 (PST) Message-ID: <3c6df46e0031a707eb650e8540b65c1cd7457829.camel@redhat.com> Subject: Re: [PATCH 0/4] v2 of Option handling: add documentation URLs From: David Malcolm To: Joseph Myers , Tobias Burnus , Mark Wielaard Cc: gcc-patches Date: Fri, 08 Dec 2023 18:35:56 -0500 In-Reply-To: <419f3147-fdb3-fcda-fcaf-23b08e2ca872@codesourcery.com> References: <9e5d6710-84e-15b9-d955-5381a6dc18a9@codesourcery.com> <20231116142858.3996740-1-dmalcolm@redhat.com> <20231121010937.848E320433@pchp3.se.axis.com> <06599eb5c08f8461ec77d7f032e6968558ce1d90.camel@redhat.com> <6114f586-c61f-4695-bf3e-106b98c9fe20@codesourcery.com> <419f3147-fdb3-fcda-fcaf-23b08e2ca872@codesourcery.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2023-11-21 at 23:43 +0000, Joseph Myers wrote: > On Tue, 21 Nov 2023, Tobias Burnus wrote: >=20 > > On 21.11.23 14:57, David Malcolm wrote: > > > On Tue, 2023-11-21 at 02:09 +0100, Hans-Peter Nilsson wrote: > > > > Sorry for barging in though I did try finding the relevant > > > > discussion, but is committing this generated stuff necessary? > > > > Is it because we don't want to depend on Python being > > > > present at build time? > > > Partly, yes, [...] > >=20 > > I wonder how to ensure that this remains up to date. Should there > > be an > > item at > >=20 > > https://gcc.gnu.org/branching.html=C2=A0and/or > > https://gcc.gnu.org/releasing.html=C2=A0similar to the .pot generation? >=20 > My suggestion earlier in the discussion was that it should be added > to the=20 > post-commit CI discussed starting at=20 > (I > think=20 > that CI is now in operation).=C2=A0 These are generated files that ought > to be=20 > kept up to date with each commit that affects .opt files, unlike the > .pot=20 > files where the expectation is that they should be up to date for > releases=20 > and updated from time to time at other times for submission to the > TP. I had a go at scripting the testing of this, but I am terrible at shell scripts (maybe I should use Python?). Here's what I have so far: $ cat contrib/regenerate-index-urls.sh set -x SRC_DIR=3D$1 BUILD_DIR=3D$2 NUM_JOBS=3D$3 # FIXME: error-checking! mkdir -p $BUILD_DIR || exit 1 cd $BUILD_DIR $SRC_DIR/configure --disable-bootstrap --enable-languages=3Dc,d,fortran || = exit 2 make html-gcc -j$NUM_JOBS || exit 3 cd gcc || exit 4 make regenerate-opt-urls || exit 5 cd $SRC_DIR (git diff $1 > /dev/null ) && echo "regenerate-opt-urls needs to be run and= the results committed" || exit 6 # e.g. # time bash contrib/regenerate-index-urls.sh $(pwd) $(pwd)/../build-ci 64 This takes about 100 seconds of wallclock on my 64-core box (mostly configuring gcc, which as well as the usual sequence of unparallelized tests seems to require building libiberty and lto-plugin). Is that something we want to do on every commit? Is implementing the CI a blocker for getting the patches in? (if so, I'll likely need some help) As it turned out, I hadn't regenerated the .opt.urls in my working copy for a couple of weeks, leading to a correct-looking patch containing things like: @@ -154,8 +157,8 @@ UrlSuffix(gcc/Warning-Options.html#index-Wbuiltin-decla= ration-mismatch) LangUrlS Wbuiltin-macro-redefined UrlSuffix(gcc/Warning-Options.html#index-Wbuiltin-macro-redefined) =20 -Wc11-c2x-compat -UrlSuffix(gcc/Warning-Options.html#index-Wc11-c2x-compat) +Wc11-c23-compat +UrlSuffix(gcc/Warning-Options.html#index-Wc11-c23-compat) =20 Wc90-c99-compat UrlSuffix(gcc/Warning-Options.html#index-Wc90-c99-compat) so I think the idea works; and the only issue for not regenerating was some missing/out-of-date URLs. Dave