From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by sourceware.org (Postfix) with ESMTPS id 7659F3858012 for ; Fri, 13 Nov 2020 16:25:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7659F3858012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nathanmsidwell@gmail.com Received: by mail-qv1-xf36.google.com with SMTP id r12so4820358qvq.13 for ; Fri, 13 Nov 2020 08:25:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W5erdkqy6t2l6nj1y0QUyc1qRp+Wq/6GuS+m6lVuGXE=; b=r7PQqc2ODjtIdd/hzkACh4rPNY8T3zxbNgivaNQp9aEY9Iik1tuOTxIctnaZgd/2gU 7Uya2hxjME1i/4l9EbSkExw7BZG0ilQU+lJhOHH62WARt9sLGZkVoV1NjL1ck76QW8iH H7sPZm3xKYzvVHuRHBB5PuF/vXufm1o7dqQ30liLSkBnJrxPWw7CV/jmIR2yT7TNW2MV Gyg+kOLwlX1+roLqN6L5YlOZ/kw5IUWfkTq6aSnKDDWBFJIzqdIPmfe8giK/wiwnaX+N bVVTM/j7rwaEDZ5zzsJem+HpRhUAoCoWdqzP3mOLXkPGvAET8m9QcVqgNd99NgYyRFks dOCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W5erdkqy6t2l6nj1y0QUyc1qRp+Wq/6GuS+m6lVuGXE=; b=GV/sndvu6IJzqIjUk4soN9HmNbhHCQlZAEnFOrPEijps/vdOuJ/DU1cbTVLeoKVDBn ne4dhtYFJChSdAluDnXMz0XIORRfxUCXBZgiBlSLAnghFOEX2jnv5jYNv+yxb4jlfB4f Gu9L/u70br8peWBjZ5b0wbnIf9j4FctAeqYiLk4P6JRvPs2KedMPKMQWPJVh7bC/hhy/ KOO1cQR83QSkyOrU2Av5atj1CfiodlxRarH3feyx+GeHtgr6azfK0mZI2/ROV5lElkK+ GjsK9c5UFrmWlmK33rP8MiDdNTyWQ1x42i7wslY0mqagzcby8zR5e5Z15kkshs7+C3ix QyJA== X-Gm-Message-State: AOAM53395LmCF/hlcAsUGHofTplmCRw+7VQUmaD4jQz0tL8ck4ewY0ar 81awXTA5zkrY+MaQu5BhxYM= X-Google-Smtp-Source: ABdhPJxDNL+QGh4819M9Qs7iY8UQ6VpJLh496B4MTX1UiQ3aPO/KxKzgvGgEM/T2P3vygMQTLI38fg== X-Received: by 2002:a0c:b65b:: with SMTP id q27mr2790150qvf.8.1605284753683; Fri, 13 Nov 2020 08:25:53 -0800 (PST) Received: from ?IPv6:2620:10d:c0a8:1102:f904:b44a:e07f:c96a? ([2620:10d:c091:480::1:839e]) by smtp.googlemail.com with ESMTPSA id p65sm5455877qkb.92.2020.11.13.08.25.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Nov 2020 08:25:52 -0800 (PST) Sender: Nathan Sidwell Subject: Re: [22.2/32] module flags To: Richard Biener Cc: GCC Patches References: <7fc9e868-3db9-4972-ed67-6ff249f549c3@acm.org> <4d14b230-3263-9a13-3159-c4853f282761@acm.org> <688bd28f-5998-0def-8c40-03b817832d63@acm.org> <89819c10-e86d-9b01-5673-5223a525a135@acm.org> <35879e15-d74a-c664-4d44-15f4b3783d77@acm.org> <9ae23c4c-67a5-a267-c939-5a96e9488612@acm.org> <6666545b-0583-4812-4745-d51994465818@acm.org> <1ab99df5-3997-0895-c979-f8529f476df7@acm.org> <97e9477b-7173-b7f9-a884-616b972c57ba@acm.org> <01f091a5-cd8b-60b6-9552-2318ecd07025@acm.org> <5c533ebe-440d-188e-5bdb-38c14898852c@acm.org> <10c2ff88-0c67-8557-6c06-bf822f675c59@acm.org> From: Nathan Sidwell Message-ID: <3c7d3345-e292-a825-c65b-4fd5a371315a@acm.org> Date: Fri, 13 Nov 2020 11:25:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2020 16:26:00 -0000 On 11/13/20 9:27 AM, Richard Biener wrote: > On Fri, Nov 13, 2020 at 3:04 PM Nathan Sidwell wrote: >> > struct GTY(()) lang_decl_base { > - /* Larger than necessary for faster access. */ > - ENUM_BITFIELD(lang_decl_selector) selector : 16; > + ENUM_BITFIELD(lang_decl_selector) selector : 3; > ... > + unsigned attached_decls_p : 1; > + > + /* 10 spare bits. */ > > so for "faster access' you could still make selector 8 bits, reducing > spare bits to 5. could do -- we always know what kind of lang_decl to expect from the originating tree's code. It's only for the garbage collector that we need the selector. (+ the checkers) > Can you add comments (like on some other bits var / fn / type) > what kind of decls the new bits are used on? Maybe some > bits can be overloaded if spare bits are needed. sure. For the record it's VAR_DECL, TYPE_DECL, FUNCTION_DECL, CONCEPT_DECL, TEMPLATE_DECL, NAMESPACE_DECL (that's to many for a TREE_CHECK, we only go to 5). > > Thanks, > Richard. > >> nathan >> >> -- >> Nathan Sidwell -- Nathan Sidwell