public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Daniel Santos <daniel.santos@pobox.com>
To: Mike Stump <mikestump@comcast.net>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Bernd Edlinger <bernd.edlinger@hotmail.de>
Subject: [PATCH 0/2] [testsuite] PR80759 Fix test breakages on i386-pc-solaris2.*
Date: Fri, 19 May 2017 06:29:00 -0000	[thread overview]
Message-ID: <3c867dc8-7d4a-ae82-c875-d03ff6d88776@pobox.com> (raw)

There are a few issues with my ms-sysv.exp tests:

 1. Use of gas extensions in do_test.S cause breakages on Solaris,
 2. Parallelization breaks when no make -j<jobs> flag is passed,
 3. Builds aren't adding TEST_ALWAYS_FLAGS, so log files filled with
    color escape codes, and
 4. The "test unsupported" message is being spammed once for each -j<job>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80759

I've broken this apart into two patches because I don't know if you'll 
agree with the first one.  I fixed the make -j<n> issue and moved the 
parallelization code into a new gcc/target/lib/parallelize.exp in the 
first patch and fixed all of the other issues in the second.  I've 
removed all usage of gas .struct in my assembly file, used hard-coded 
the offsets into the code and added asserts to main.c to make sure they 
don't change.

I've bootstrapped and retested on x86_64 Linux and have asked Rainer to 
retest on Solaris.  Presuming that succeeds, are you OK with this 
change?  (I have SVN write privs now, so I can even commit it myself).

Thanks,
Daniel

             reply	other threads:[~2017-05-19  6:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19  6:29 Daniel Santos [this message]
2017-05-19  6:29 ` [PATCH 1/2] [testsuite] Move non-standard parallelization support into new lib and fix flaw Daniel Santos
2017-05-19  6:50 ` [PATCH 2/2] [testsuite] PR 80759 Remove gas extensions from do-test.S, fix other problems Daniel Santos
2017-05-19  8:54   ` Rainer Orth
2017-05-20  0:38     ` Daniel Santos
2017-05-19  9:04 ` [PATCH 0/2] [testsuite] PR80759 Fix test breakages on i386-pc-solaris2.* Rainer Orth
2017-07-02  5:06 ` [PATCH v2 0/2] [testsuite, libgcc] PR80759 Fix FAILs on Solaris and Darwin Daniel Santos
2017-07-02  5:10   ` [PATCH 2/2] [libgcc]: PR80759 fixes for Solaris & Darwin Daniel Santos
2017-07-02  5:10   ` [PATCH 1/2] [testsuite] PR80759 fix tests on Solaris and Darwin Daniel Santos
2017-07-17 16:11   ` PING: [PATCH v2 0/2] [testsuite, libgcc] PR80759 Fix FAILs " Daniel Santos
2017-07-17 16:38     ` Mike Stump
2017-07-17 18:50     ` Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c867dc8-7d4a-ae82-c875-d03ff6d88776@pobox.com \
    --to=daniel.santos@pobox.com \
    --cc=bernd.edlinger@hotmail.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).