From: Robin Dapp <rdapp.gcc@gmail.com>
To: 钟居哲 <juzhe.zhong@rivai.ai>, gcc-patches <gcc-patches@gcc.gnu.org>
Cc: rdapp.gcc@gmail.com, "kito.cheng" <kito.cheng@gmail.com>,
"kito.cheng" <kito.cheng@sifive.com>, palmer <palmer@dabbelt.com>,
palmer <palmer@rivosinc.com>, Jeff Law <jeffreyalaw@gmail.com>,
"pan2.li" <pan2.li@intel.com>
Subject: Re: [PATCH] RISC-V: Add RVV vwmacc/vwmaccu/vwmaccsu combine lowering optmization
Date: Tue, 6 Jun 2023 13:42:39 +0200 [thread overview]
Message-ID: <3cd0462a-82a6-0c6c-5afe-0c55021ac50d@gmail.com> (raw)
In-Reply-To: <8D5CFAAB047A3662+20230606193526718263173@rivai.ai>
> These enhance patterns are generated in complicate combining situations.
Yes, that's clear. One strategy is to look through combine's output and
see which combination results make sense for a particular backend.
I was wondering where the unspec-less patterns originate (when we
expand everything to predicated, unspec insns).
> Splitters can not work in complicate case, you could try my testcase.
> I am 100% it should be define_insn_and_split.
I didn't mean to say that splitters should be used, just that I had similary
"ugly" patterns with splitters and there will be more in the future.
Regards
Robin
next prev parent reply other threads:[~2023-06-06 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 9:58 juzhe.zhong
2023-06-06 11:16 ` Robin Dapp
2023-06-06 11:35 ` 钟居哲
2023-06-06 11:42 ` Robin Dapp [this message]
2023-06-06 11:46 ` 钟居哲
2023-06-06 11:58 ` Robin Dapp
2023-06-06 12:05 ` 钟居哲
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cd0462a-82a6-0c6c-5afe-0c55021ac50d@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=pan2.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).