From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 9160738AA277 for ; Tue, 10 Jan 2023 15:10:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9160738AA277 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 403AA3EA18; Tue, 10 Jan 2023 15:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1673363432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5iG86tvKQB+dxrSSWJm1hM5x8q2xGHtGmOU1resbgwU=; b=OcvmQ+JpljCjGWLCqZsxDkgal93mfSnu3oOgpygPYO2n6phw2t0ovrEg+XrWxQRw7QSH7y cKjGSIN1kncP27yl9JdsPpg4kILW+9vjBcoQXjpw00rIxHa+67n+G0Reh0zdGCQ/O2JnjA M3AnXGwpP7pEg9ECrE0M9j9vdcBjj/M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1673363432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5iG86tvKQB+dxrSSWJm1hM5x8q2xGHtGmOU1resbgwU=; b=gqnM5Df4dQpNpznxhWQrwSDOCvOlum5+f6S40o3atwlu+lU5q0BWYfoKZ20+Lu8VIxJvan hZiIJ+LbVDIaP0Dw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2C2D11358A; Tue, 10 Jan 2023 15:10:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3bO1Ceh/vWPudgAAMHmgww (envelope-from ); Tue, 10 Jan 2023 15:10:32 +0000 Content-Type: multipart/mixed; boundary="------------KR5z30xDykae0W5XhEJy7ezH" Message-ID: <3cf31374-0496-3119-7775-0c22bc03cb38@suse.cz> Date: Tue, 10 Jan 2023 16:10:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file Content-Language: en-US To: David Malcolm , gcc-patches@gcc.gnu.org References: <60f9fd2b-211e-c1d5-e17a-1fab1ee51338@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------KR5z30xDykae0W5XhEJy7ezH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/6/23 14:21, David Malcolm wrote: > On Fri, 2023-01-06 at 12:33 +0100, Martin Liška wrote: >> Patch can bootstrap on x86_64-linux-gnu and survives regression >> tests. > > Thanks for the patch. > > I noticed that you marked PR 108307 as a dup of this, which covers > -fdiagnostics-format=sarif-file (and a .S file as input). > > The patch doesn't add any test coverage (for either of the diagnostic > formats). > > If we try to emit a diagnostic and base_file_name is NULL, and the user > requested one of -fdiagnostics-format={json,sarif}-file, where do the > diagnostics go? Where should they go? Hey. I've done a new version of the patch where I utilize x_main_input_basename. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin --------------KR5z30xDykae0W5XhEJy7ezH Content-Type: text/x-patch; charset=UTF-8; name="0001-middle-end-always-find-a-basename-for-fdiagnostics-f.patch" Content-Disposition: attachment; filename*0="0001-middle-end-always-find-a-basename-for-fdiagnostics-f.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAwNzgyMzNiNGY4NGFlNmQ4MWE3MzI3NTg5NzIzYjJiZTUxOGQyOWNhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBUdWUsIDEwIEphbiAyMDIzIDE1OjE0OjA1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g bWlkZGxlLWVuZDogYWx3YXlzIGZpbmQgYSBiYXNlbmFtZSBmb3IgLWZkaWFnbm9zdGljcy1m b3JtYXQ9KgoKSW4gc29tZSBzaXR1YXRpb25zLCB4X2R1bXBfYmFzZV9uYW1lIGlzIE5VTEwg YW5kIHRodXMgd2UgY2FuCmFuZCBzaG91bGQgdXNlIHhfbWFpbl9pbnB1dF9iYXNlbmFtZSB3 aGljaCBzaG91bGQgbmV2ZXIgYmUgTlVMTC4KCglQUiBtaWRkbGUtZW5kLzEwNjEzMwoKZ2Nj L0NoYW5nZUxvZzoKCgkqIGdjYy5jYyAoZHJpdmVyX2hhbmRsZV9vcHRpb24pOiBVc2UgeF9t YWluX2lucHV0X2Jhc2VuYW1lCglpZiB4X2R1bXBfYmFzZV9uYW1lIGlzIG51bGwuCgkqIG9w dHMuY2MgKGNvbW1vbl9oYW5kbGVfb3B0aW9uKTogTGlrZXdpc2UuCgpnY2MvdGVzdHN1aXRl L0NoYW5nZUxvZzoKCgkqIGMtYysrLWNvbW1vbi9wcjEwNjEzMy5jOiBOZXcgdGVzdC4KLS0t CiBnY2MvZ2NjLmNjICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTAgKysrKysrKy0t LQogZ2NjL29wdHMuY2MgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEwICsrKysrKyst LS0KIGdjYy90ZXN0c3VpdGUvYy1jKystY29tbW9uL3ByMTA2MTMzLmMgfCAgMyArKysKIDMg ZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKIGNyZWF0 ZSBtb2RlIDEwMDY0NCBnY2MvdGVzdHN1aXRlL2MtYysrLWNvbW1vbi9wcjEwNjEzMy5jCgpk aWZmIC0tZ2l0IGEvZ2NjL2djYy5jYyBiL2djYy9nY2MuY2MKaW5kZXggZDYyOWNhNWU0MjQu LjM4MmNhODE3YTA5IDEwMDY0NAotLS0gYS9nY2MvZ2NjLmNjCisrKyBiL2djYy9nY2MuY2MK QEAgLTQyOTAsOSArNDI5MCwxMyBAQCBkcml2ZXJfaGFuZGxlX29wdGlvbiAoc3RydWN0IGdj Y19vcHRpb25zICpvcHRzLAogICAgICAgYnJlYWs7CiAKICAgICBjYXNlIE9QVF9mZGlhZ25v c3RpY3NfZm9ybWF0XzoKLSAgICAgIGRpYWdub3N0aWNfb3V0cHV0X2Zvcm1hdF9pbml0IChk Yywgb3B0cy0+eF9kdW1wX2Jhc2VfbmFtZSwKLQkJCQkgICAgIChlbnVtIGRpYWdub3N0aWNz X291dHB1dF9mb3JtYXQpdmFsdWUpOwotICAgICAgYnJlYWs7CisJeworCSAgY29uc3QgY2hh ciAqYmFzZW5hbWUgPSAob3B0cy0+eF9kdW1wX2Jhc2VfbmFtZSA/IG9wdHMtPnhfZHVtcF9i YXNlX25hbWUKKwkJCQkgIDogb3B0cy0+eF9tYWluX2lucHV0X2Jhc2VuYW1lKTsKKwkgIGRp YWdub3N0aWNfb3V0cHV0X2Zvcm1hdF9pbml0IChkYywgYmFzZW5hbWUsCisJCQkJCSAoZW51 bSBkaWFnbm9zdGljc19vdXRwdXRfZm9ybWF0KXZhbHVlKTsKKwkgIGJyZWFrOworCX0KIAog ICAgIGNhc2UgT1BUX1dhXzoKICAgICAgIHsKZGlmZiAtLWdpdCBhL2djYy9vcHRzLmNjIGIv Z2NjL29wdHMuY2MKaW5kZXggOWJhNDdkN2RlYWEuLjQ4MDljMThhNTI5IDEwMDY0NAotLS0g YS9nY2Mvb3B0cy5jYworKysgYi9nY2Mvb3B0cy5jYwpAQCAtMjg2Myw5ICsyODYzLDEzIEBA IGNvbW1vbl9oYW5kbGVfb3B0aW9uIChzdHJ1Y3QgZ2NjX29wdGlvbnMgKm9wdHMsCiAgICAg ICBicmVhazsKIAogICAgIGNhc2UgT1BUX2ZkaWFnbm9zdGljc19mb3JtYXRfOgotICAgICAg ZGlhZ25vc3RpY19vdXRwdXRfZm9ybWF0X2luaXQgKGRjLCBvcHRzLT54X2R1bXBfYmFzZV9u YW1lLAotCQkJCSAgICAgKGVudW0gZGlhZ25vc3RpY3Nfb3V0cHV0X2Zvcm1hdCl2YWx1ZSk7 Ci0gICAgICBicmVhazsKKwl7CisJICBjb25zdCBjaGFyICpiYXNlbmFtZSA9IChvcHRzLT54 X2R1bXBfYmFzZV9uYW1lID8gb3B0cy0+eF9kdW1wX2Jhc2VfbmFtZQorCQkJCSAgOiBvcHRz LT54X21haW5faW5wdXRfYmFzZW5hbWUpOworCSAgZGlhZ25vc3RpY19vdXRwdXRfZm9ybWF0 X2luaXQgKGRjLCBiYXNlbmFtZSwKKwkJCQkJIChlbnVtIGRpYWdub3N0aWNzX291dHB1dF9m b3JtYXQpdmFsdWUpOworCSAgYnJlYWs7CisJfQogCiAgICAgY2FzZSBPUFRfZmRpYWdub3N0 aWNzX3BhcnNlYWJsZV9maXhpdHM6CiAgICAgICBkYy0+ZXh0cmFfb3V0cHV0X2tpbmQgPSAo dmFsdWUKZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvYy1jKystY29tbW9uL3ByMTA2MTMz LmMgYi9nY2MvdGVzdHN1aXRlL2MtYysrLWNvbW1vbi9wcjEwNjEzMy5jCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi43ZDJjNWFmZTQxNwotLS0gL2Rldi9udWxs CisrKyBiL2djYy90ZXN0c3VpdGUvYy1jKystY29tbW9uL3ByMTA2MTMzLmMKQEAgLTAsMCAr MSwzIEBACisvKiBQUiBtaWRkbGUtZW5kLzEwNjEzMyAqLworLyogeyBkZy1kbyBjb21waWxl IH0gKi8KKy8qIHsgZGctb3B0aW9ucyAiLWZkaWFnbm9zdGljcy1mb3JtYXQ9anNvbi1maWxl IC1FIiB9ICovCi0tIAoyLjM5LjAKCg== --------------KR5z30xDykae0W5XhEJy7ezH--