From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=1yWv=MD=arm.com=Richard.Earnshaw@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id CD1C03858D1E
	for <gcc-patches@gcc.gnu.org>; Tue, 30 Apr 2024 15:11:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD1C03858D1E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CD1C03858D1E
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714489871; cv=none;
	b=iYPsUgkPawFAZVEMUU5QGrE0VnwlHhmn3VflAgyT/t6UyjjJcqWJDVySfRPKzOfm8dav3EsAANAiPMCrCPphllDS8IQMUdBfsr6m+s3WBo+cx6lmQOSGKadZfxwAZ2Xlgb9njTetokd7yAwDS1iyYoRfFhfkF6nIfUV2vJnx5/s=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1714489871; c=relaxed/simple;
	bh=eBkYqJOfgRty39n9QZQO5x/GkUqjgjCCmfdvz8U49Sg=;
	h=Message-ID:Date:MIME-Version:Subject:To:From; b=gvdS4QDZ51IB8HJpBJPbPnQmCZ+8VY+k1JO+LPBdxDGPue+0arNWSzCYIozdWuwBXKDqbLU0WzknGWsAeHm7UHN+XuE6GIevdjKdh3OXNBVeU9RtuvxcxvB1BBRrajAQirA7EYj0ZMB02vJetXdQCmpXZJsEmz95Mpz4V9y3GjQ=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C02922F4;
	Tue, 30 Apr 2024 08:11:32 -0700 (PDT)
Received: from [10.2.78.64] (e120077-lin.cambridge.arm.com [10.2.78.64])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CCC583F793;
	Tue, 30 Apr 2024 08:11:05 -0700 (PDT)
Message-ID: <3d2466ec-34ea-4ccc-aeb3-9a40b1052900@arm.com>
Date: Tue, 30 Apr 2024 16:11:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] testsuite: Verify r0-r3 are extended with CMSE
To: =?UTF-8?Q?Torbj=C3=B6rn_SVENSSON?= <torbjorn.svensson@foss.st.com>,
 gcc-patches@gcc.gnu.org
Cc: Richard.Ball@arm.com
References: <25390b61-d034-4f78-9bfc-c9bdcd6a1299@arm.com>
 <20240427141349.2191499-1-torbjorn.svensson@foss.st.com>
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
Content-Language: en-GB
In-Reply-To: <20240427141349.2191499-1-torbjorn.svensson@foss.st.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-3497.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On 27/04/2024 15:13, Torbjörn SVENSSON wrote:
> Add regression test to the existing zero/sign extend tests for CMSE to
> verify that r0, r1, r2 and r3 are properly extended, not just r0.
> 
> Test is done using -O0 to ensure the instructions are in a predictable
> order.
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.target/arm/cmse/extend-param.c: Add regression test.
> 
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
>  .../gcc.target/arm/cmse/extend-param.c        | 20 ++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/gcc/testsuite/gcc.target/arm/cmse/extend-param.c b/gcc/testsuite/gcc.target/arm/cmse/extend-param.c
> index 01fac786238..b8b8ecbff56 100644
> --- a/gcc/testsuite/gcc.target/arm/cmse/extend-param.c
> +++ b/gcc/testsuite/gcc.target/arm/cmse/extend-param.c
> @@ -93,4 +93,22 @@ __attribute__((cmse_nonsecure_entry)) char boolSecureFunc (bool index) {
>      return 0;
>    return array[index];
>  
> -}
> \ No newline at end of file
> +}
> +
> +/*
> +**__acle_se_boolCharShortEnumSecureFunc:
> +**	...
> +**	uxtb	r0, r0
> +**	uxtb	r1, r1
> +**	uxth	r2, r2
> +**	uxtb	r3, r3
> +**	...
> +*/
> +__attribute__((cmse_nonsecure_entry,optimize(0))) char boolCharShortEnumSecureFunc (bool a, unsigned char b, unsigned short c, enum offset d) {
> +
> +  size_t index = a + b + c + d;
> +  if (index >= ARRAY_SIZE)
> +    return 0;
> +  return array[index];
> +
> +}

Ok, but please can you add '-fshort-enums' to dg-options to ensure this test still behaves correctly if run with a different default (I missed that last time around).

R.