From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Ezra.Sitorus@arm.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v3 00/12] [GCC] arm: vld1q vst1 vst1q vst1 intrinsics
Date: Fri, 12 Jan 2024 17:03:55 +0000 [thread overview]
Message-ID: <3d6113fc-aa9c-4db1-bb0f-25c4abba5028@arm.com> (raw)
In-Reply-To: <20240102092345.28370-1-Ezra.Sitorus@arm.com>
On 02/01/2024 09:23, Ezra.Sitorus@arm.com wrote:
> From: Ezra Sitorus <ezra.sitorus@arm.com>
>
> Add vld1q, vst1, vst1q and vst1 intrinsics to arm port.
>
> Ezra Sitorus (12):
> [GCC] arm: vld1q_types_x2 ACLE intrinsics
> [GCC] arm: vld1q_types_x3 ACLE intrinsics
> [GCC] arm: vld1q_types_x4 ACLE intrinsics
> [GCC] arm: vst1_types_x2 ACLE intrinsics
> [GCC] arm: vst1_types_x3 ACLE intrinsics
> [GCC] arm: vst1_types_x4 ACLE intrinsics
> [GCC] arm: vst1q_types_x2 ACLE intrinsics
> [GCC] arm: vst1q_types_x3 ACLE intrinsics
> [GCC] arm: vst1q_types_x4 ACLE intrinsics
> [GCC] arm: vld1_types_x2 ACLE intrinsics
> [GCC] arm: vld1_types_x3 ACLE intrinsics
> [GCC] arm: vld1_types_x4 ACLE intrinsics
>
> gcc/config/arm/arm_neon.h | 2032 ++++++++++++++---
> gcc/config/arm/arm_neon_builtins.def | 12 +
> gcc/config/arm/iterators.md | 6 +
> gcc/config/arm/neon.md | 249 ++
> gcc/config/arm/unspecs.md | 8 +
> .../gcc.target/arm/simd/vld1_base_xN_1.c | 176 ++
> .../gcc.target/arm/simd/vld1_bf16_xN_1.c | 23 +
> .../gcc.target/arm/simd/vld1_fp16_xN_1.c | 23 +
> .../gcc.target/arm/simd/vld1_p64_xN_1.c | 23 +
> .../gcc.target/arm/simd/vld1q_base_xN_1.c | 183 ++
> .../gcc.target/arm/simd/vld1q_bf16_xN_1.c | 24 +
> .../gcc.target/arm/simd/vld1q_fp16_xN_1.c | 24 +
> .../gcc.target/arm/simd/vld1q_p64_xN_1.c | 24 +
> .../gcc.target/arm/simd/vst1_base_xN_1.c | 176 ++
> .../gcc.target/arm/simd/vst1_bf16_xN_1.c | 22 +
> .../gcc.target/arm/simd/vst1_fp16_xN_1.c | 23 +
> .../gcc.target/arm/simd/vst1_p64_xN_1.c | 23 +
> .../gcc.target/arm/simd/vst1q_base_xN_1.c | 185 ++
> .../gcc.target/arm/simd/vst1q_bf16_xN_1.c | 24 +
> .../gcc.target/arm/simd/vst1q_fp16_xN_1.c | 24 +
> .../gcc.target/arm/simd/vst1q_p64_xN_1.c | 24 +
> 21 files changed, 3018 insertions(+), 290 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vld1_base_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vld1_bf16_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vld1_fp16_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vld1_p64_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vld1q_base_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vld1q_bf16_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vld1q_fp16_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vld1q_p64_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vst1_base_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vst1_bf16_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vst1_fp16_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vst1_p64_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vst1q_base_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vst1q_bf16_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vst1q_fp16_xN_1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/vst1q_p64_xN_1.c
>
Thanks, I've pushed this series.
Reviewing this series did highlight a couple of issues with the existing code base (not your patch); I'll follow up on these separately.
R.
prev parent reply other threads:[~2024-01-12 17:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 9:23 Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 01/12] [GCC] arm: vld1q_types_x2 ACLE intrinsics Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 02/12] [GCC] arm: vld1q_types_x3 " Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 03/12] [GCC] arm: vld1q_types_x4 " Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 04/12] [GCC] arm: vst1_types_x2 " Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 05/12] [GCC] arm: vst1_types_x3 " Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 06/12] [GCC] arm: vst1_types_x4 " Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 07/12] [GCC] arm: vst1q_types_x2 " Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 08/12] [GCC] arm: vst1q_types_x3 " Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 09/12] [GCC] arm: vst1q_types_x4 " Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 10/12] [GCC] arm: vld1_types_x2 " Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 11/12] [GCC] arm: vld1_types_x3 " Ezra.Sitorus
2024-01-02 9:23 ` [PATCH v3 12/12] [GCC] arm: vld1_types_x4 " Ezra.Sitorus
2024-01-12 17:03 ` Richard Earnshaw (lists) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d6113fc-aa9c-4db1-bb0f-25c4abba5028@arm.com \
--to=richard.earnshaw@arm.com \
--cc=Ezra.Sitorus@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).