From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id A8A033858D20 for ; Fri, 3 Feb 2023 15:34:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8A033858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 897791474; Fri, 3 Feb 2023 07:35:23 -0800 (PST) Received: from [10.2.78.76] (unknown [10.2.78.76]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C77E43F71E; Fri, 3 Feb 2023 07:34:40 -0800 (PST) Message-ID: <3d9a5c0c-9e20-abe2-0a69-d747ceaa7cc6@foss.arm.com> Date: Fri, 3 Feb 2023 15:34:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] arm: Fix warning in libgcc/config/arm/pr-support.c Content-Language: en-GB To: Christophe Lyon , gcc-patches@gcc.gnu.org References: <20230201094650.65755-1-christophe.lyon@arm.com> From: Richard Earnshaw In-Reply-To: <20230201094650.65755-1-christophe.lyon@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3489.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01/02/2023 09:46, Christophe Lyon via Gcc-patches wrote: > I have noticed some warnings when building GCC for arm-eabi: > pr-support.c:110:7: warning: variable ‘set_pac_sp’ set but not used [-Wunused-but-set-variable] > pr-support.c:109:7: warning: variable ‘set_pac’ set but not used [-Wunused-but-set-variable] > > This small patch avoids them by defining these two variables undef > TARGET_HAVE_PACBTI, like the code which actually uses them. > > libgcc/ > * config/arm/pr-support.c (__gnu_unwind_execute): Use > TARGET_HAVE_PACBTI to define set_pac and set_pac_sp. OK R.