From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102152 invoked by alias); 31 Jul 2019 13:16:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102143 invoked by uid 89); 31 Jul 2019 13:16:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1100 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Jul 2019 13:16:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C9D5E344; Wed, 31 Jul 2019 06:16:52 -0700 (PDT) Received: from e120077-lin.cambridge.arm.com (e120077-lin.cambridge.arm.com [10.2.206.91]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E13963F575; Wed, 31 Jul 2019 06:16:51 -0700 (PDT) Subject: Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544) To: Bernd Edlinger , Richard Biener Cc: "gcc-patches@gcc.gnu.org" , Ramana Radhakrishnan , Kyrill Tkachov , Eric Botcazou References: From: "Richard Earnshaw (lists)" Message-ID: <3da1f037-f060-87ca-36ed-93c2ab73e620@arm.com> Date: Wed, 31 Jul 2019 13:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg01879.txt.bz2 On 30/07/2019 21:51, Bernd Edlinger wrote: > +/* { dg-options "-marm -march=armv6 -mno-unaligned-access -mfloat-abi=soft -mabi=aapcs -O3" } */ This isn't going to work as-is, we test many combinations of the compiler, either with explicit dejagnu settings or with the compiler defaults and the dejagnu settings can't generally be overridden this way. For -marm you require an effective-target of arm_arm_ok. For ldrd, it should be enough to just require an effective-target of arm_ldrd_strd_ok, then you can . I don't think we really care about any ABIs other than aapcs, so I'd just leave that off. And as for setting the float-abi, I don't see anything in the tests that would require that, so that can probably be omitted as well. I think with all this, you can then write something like /* { dg-require-effective-target arm_arm_ok && arm_ldrd_strd_ok } */ /* { dg-options "-marm -mno-unaligned-access -O3 } */ But I haven't tested that, so you might need to fiddle with it a bit, especially the effective-target rule. R.