From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4A0BA3858D33 for ; Thu, 22 Feb 2024 08:34:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A0BA3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A0BA3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708590898; cv=none; b=cIeSbSJsAxk409q0QjIjyJgF/ZrbNgX7/vXFXt4eT44pZh1J8UcjrJs4FGFuKQFMcHE9q//7P8uaLx94//UOo5Rk5BVV0nIqfDzAxw1JXCJ7kATCd9IG32VGorZsYHQ1/LB3clkU65PUBrS/FW9e7qjZ+J0a0RiajA2ipemFjOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708590898; c=relaxed/simple; bh=iDLYiPxXJcM/pePS3kiac6ZAERpX73ytc4N4YLlY2mA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=N0GJ2QAnBQZryfjHyg2SuiPjWZcpgs2TU1LusoflLVpBDJrifFueofsaSBW6kKybUpJE4+JgCKV+IvCREpBO9LAwvNBzHsVTDzQJiNp6I2to0PF3wpw+sJKKVlRysZSQtNAmcQUh65q4ZLXUxsmYTVNU7YdsPMZ6MnuEAOuo0CM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708590890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tESwyhC2LgRxw4wt6AcRhuIc+po5jIT2gMhjENq5G6A=; b=coQPxnj2IrxxGuUz9pT5fHOdpYxI38GVRgvAa8wYA6x+RN7o+MnFIk60rKhfOH9qeq4zyF O456MIuS5wRVzPw6O0ODfMIGl2N9ddeCQ7qul0DQIgMrry5/jkK5mOk/19jTdFKsfmR830 t8UJRjgVefXSOoApmj5ZTCeShHReKag= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-3LLNjWIEM8yV8uF28pNypA-1; Thu, 22 Feb 2024 03:34:49 -0500 X-MC-Unique: 3LLNjWIEM8yV8uF28pNypA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-33d89a393c8so353865f8f.2 for ; Thu, 22 Feb 2024 00:34:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708590888; x=1709195688; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tESwyhC2LgRxw4wt6AcRhuIc+po5jIT2gMhjENq5G6A=; b=ncZX5ux1vAn1TTHNxpeAf3w6htP+EMO0bIHQ9HqelGiDJ9b9zqqdjdylF2GjNzlLcn +/tjBawcWeaEoAGxYr9uFKaKcXBD++FCmi+O9M3BB+ZzZgLfObxEnnPHQBf5bGhJeunl aTSVg17bBOt8gImdMs0wAsprFlfAg86QJFGy611gqJd3gEt7u2HFjGgim4cjNGbtr5eQ 80EBX5q2zroOy1fysPt8RCwsTqp+vx5Xnd++r4v97UPclgBd4H+He9POygThUDfN/hl5 n/KpIAc0gWCe+rb6SyuSN6PWJkgGpS2763e2R9VeJJgVR00MRHWUlKrCRP+j2KJkfowF qPPg== X-Forwarded-Encrypted: i=1; AJvYcCVJHqHW0hFCLk/Vhbr9+M1hiNzs8dwe333EkmxUfV7LyA/a0RUsjQqVxKExgWQELi/z+eaWqwJVlHGxUwH3k5nfEDX/MWMVcw== X-Gm-Message-State: AOJu0Yyia70MSK1T/d1KIIJJJu7bf2W33TqMc1z/u36LaOrj9wed3FvU SEnWNJeCtTHnA1xYkGK4Sh7P+CfTVFY5Ul8ZGo6EfWKxmI9WMgOqj16GrJJiISEFBsm13TlU1OV bty/0X5Uyi3FSzgs2/TN9u/Dmd2Ec5PVixrAt1wM0Qo5Wvp1qLB8Tc6kKhyQGXgRW8A== X-Received: by 2002:a05:6000:184f:b0:33d:31dc:c109 with SMTP id c15-20020a056000184f00b0033d31dcc109mr11445293wri.50.1708590887943; Thu, 22 Feb 2024 00:34:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFURbhn159D4QT0gfb3Li52rNsI6e7RV0bYsfc38VrcPQLmGYWen5VN6F9b+mgNekQPGyherg== X-Received: by 2002:a05:6000:184f:b0:33d:31dc:c109 with SMTP id c15-20020a056000184f00b0033d31dcc109mr11445278wri.50.1708590887519; Thu, 22 Feb 2024 00:34:47 -0800 (PST) Received: from [192.168.11.23] (ip-185-104-136-49.ptr.icomera.net. [185.104.136.49]) by smtp.gmail.com with ESMTPSA id bt27-20020a056000081b00b0033d1b653e4csm20488023wrb.54.2024.02.22.00.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 00:34:46 -0800 (PST) Message-ID: <3dae04f1-90b7-4a03-b239-24df37c57cdf@redhat.com> Date: Thu, 22 Feb 2024 08:34:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] c++: -Wuninitialized when binding a ref to uninit DM [PR113987] To: Marek Polacek , GCC Patches References: <20240221001517.478667-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20240221001517.478667-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/20/24 19:15, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > -- >8 -- > This PR asks that our -Wuninitialized for mem-initializers does > not warn when binding a reference to an uninitialized data member. > We already check !INDIRECT_TYPE_P in find_uninit_fields_r, but > that won't catch binding a parameter of a reference type to an > uninitialized field, as in: > > struct S { S (int&); }; > struct T { > T() : s(i) {} > S s; > int i; > }; > > This patch adds a new function to handle this case. For type_build_ctor_call types like S, it's weird that we currently find_uninit_fields before building the initialization. What if we move the check after the build_aggr_init so we have the actual initializer instead of just the expression? > PR c++/113987 > > gcc/cp/ChangeLog: > > * call.cc (conv_binds_to_reference_parm_p): New. > * cp-tree.h (conv_binds_to_reference_parm_p): Declare. > * init.cc (find_uninit_fields_r): Call it. > > gcc/testsuite/ChangeLog: > > * g++.dg/warn/Wuninitialized-15.C: Turn dg-warning into dg-bogus. > * g++.dg/warn/Wuninitialized-34.C: New test. > --- > gcc/cp/call.cc | 24 ++++++++++++++ > gcc/cp/cp-tree.h | 1 + > gcc/cp/init.cc | 3 +- > gcc/testsuite/g++.dg/warn/Wuninitialized-15.C | 3 +- > gcc/testsuite/g++.dg/warn/Wuninitialized-34.C | 32 +++++++++++++++++++ > 5 files changed, 60 insertions(+), 3 deletions(-) > create mode 100644 gcc/testsuite/g++.dg/warn/Wuninitialized-34.C > > diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc > index 1dac1470d3b..c40ef2e3028 100644 > --- a/gcc/cp/call.cc > +++ b/gcc/cp/call.cc > @@ -14551,4 +14551,28 @@ maybe_show_nonconverting_candidate (tree to, tree from, tree arg, int flags) > "function was not considered"); > } > > +/* We're converting EXPR to TYPE. If that conversion involves a conversion > + function and we're binding EXPR to a reference parameter of that function, > + return true. */ > + > +bool > +conv_binds_to_reference_parm_p (tree type, tree expr) > +{ > + conversion_obstack_sentinel cos; > + conversion *c = implicit_conversion (type, TREE_TYPE (expr), expr, > + /*c_cast_p=*/false, LOOKUP_NORMAL, > + tf_none); > + if (c && !c->bad_p && c->user_conv_p) > + for (; c; c = next_conversion (c)) > + if (c->kind == ck_user) > + for (z_candidate *cand = c->cand; cand; cand = cand->next) > + if (cand->viable == 1) > + for (size_t i = 0; i < cand->num_convs; ++i) > + if (cand->convs[i]->kind == ck_ref_bind > + && conv_get_original_expr (cand->convs[i]) == expr) > + return true; > + > + return false; > +} > + > #include "gt-cp-call.h" > diff --git a/gcc/cp/cp-tree.h b/gcc/cp/cp-tree.h > index 334c11396c2..ce2d85f1f86 100644 > --- a/gcc/cp/cp-tree.h > +++ b/gcc/cp/cp-tree.h > @@ -6845,6 +6845,7 @@ extern void cp_warn_deprecated_use_scopes (tree); > extern tree get_function_version_dispatcher (tree); > extern bool any_template_arguments_need_structural_equality_p (tree); > extern void maybe_show_nonconverting_candidate (tree, tree, tree, int); > +extern bool conv_binds_to_reference_parm_p (tree, tree); > > /* in class.cc */ > extern tree build_vfield_ref (tree, tree); > diff --git a/gcc/cp/init.cc b/gcc/cp/init.cc > index ac37330527e..1a341f7e606 100644 > --- a/gcc/cp/init.cc > +++ b/gcc/cp/init.cc > @@ -906,7 +906,8 @@ find_uninit_fields_r (tree *tp, int *walk_subtrees, void *data) > warning_at (EXPR_LOCATION (init), OPT_Wuninitialized, > "reference %qD is not yet bound to a value when used " > "here", field); > - else if (!INDIRECT_TYPE_P (type) || is_this_parameter (d->member)) > + else if ((!INDIRECT_TYPE_P (type) || is_this_parameter (d->member)) > + && !conv_binds_to_reference_parm_p (type, init)) > warning_at (EXPR_LOCATION (init), OPT_Wuninitialized, > "member %qD is used uninitialized", field); > *walk_subtrees = false; > diff --git a/gcc/testsuite/g++.dg/warn/Wuninitialized-15.C b/gcc/testsuite/g++.dg/warn/Wuninitialized-15.C > index 89e90668c41..2fd33037bfd 100644 > --- a/gcc/testsuite/g++.dg/warn/Wuninitialized-15.C > +++ b/gcc/testsuite/g++.dg/warn/Wuninitialized-15.C > @@ -65,8 +65,7 @@ struct H { > G g; > A a2; > H() : g(a1) { } > - // ??? clang++ doesn't warn here > - H(int) : g(a2) { } // { dg-warning "member .H::a2. is used uninitialized" } > + H(int) : g(a2) { } // { dg-bogus "member .H::a2. is used uninitialized" } > }; > > struct I { > diff --git a/gcc/testsuite/g++.dg/warn/Wuninitialized-34.C b/gcc/testsuite/g++.dg/warn/Wuninitialized-34.C > new file mode 100644 > index 00000000000..28226d8032e > --- /dev/null > +++ b/gcc/testsuite/g++.dg/warn/Wuninitialized-34.C > @@ -0,0 +1,32 @@ > +// PR c++/113987 > +// { dg-do compile } > +// { dg-options "-Wuninitialized" } > + > +struct t1 { > + t1(int); > +}; > +struct t2 { > + t2(int&, int = 0); > + t2(double&, int = 0); > +}; > +struct t3 { > + t3(int&); > +}; > +struct t4 {}; > +void f1(int&); > +struct t { > + t() : > + v1(i), // { dg-warning "is used uninitialized" } > + v2(i), > + v3(i), > + v4((f1(i), t4())), > + v5(i) {} > + t1 v1; > + t2 v2; > + t3 v3; > + t4 v4; > + t1 v5; > + int i; > + int j; > +}; > +int main() { t v1; } > > base-commit: ca5f509903315a56b2f306f8644544861a6525cb