From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 4F4DE386CE4B for ; Thu, 30 Jun 2022 08:42:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F4DE386CE4B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4AF2B1F8DD; Thu, 30 Jun 2022 08:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1656578540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5e0eTfl2gSRkRhBSkPYg4LDKaoFAdeMLkUpm3P9S7g0=; b=EkZjFrKUPCjFru/rVb7YqY6Rlt4fXvdOT+dpoNvw+8feARrRVZ9zcM46mw6U+Xu/gf9XZs B0rfJI2Q5UIvW59T6OLtZuov4aTNy1OCwh+TL9zzdAMC/p2ytkJoEgubVMyb74jkj17JZK bQuZRoCxqfVphyDg2RgUrRgOOwyuFp8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1656578540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5e0eTfl2gSRkRhBSkPYg4LDKaoFAdeMLkUpm3P9S7g0=; b=vHvmPArmwXk5xrjrFC+9BjluRO9EeFzY4dkH999Ca6yHcmR0CGSsGTYqRuJt56TnLc5KDk 5cr58Rk39ax52QCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 26985139E9; Thu, 30 Jun 2022 08:42:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /fcwCOxhvWLxTQAAMHmgww (envelope-from ); Thu, 30 Jun 2022 08:42:20 +0000 Content-Type: multipart/mixed; boundary="------------a2kltVjOVLd0fSANGCCw9178" Message-ID: <3dc13790-a22d-c4d6-6cfe-ab9b567968ff@suse.cz> Date: Thu, 30 Jun 2022 10:42:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 3/3] lto-plugin: implement LDPT_GET_API_VERSION Content-Language: en-US To: Rui Ueyama Cc: Richard Biener , Alexander Monakov , GCC Patches References: <803a0290-3909-b9c5-2461-b1740a00c63a@suse.cz> <146a46f1-3a56-48c5-386f-c15633cc6781@ispras.ru> <37b52d36-d1dd-f291-0baa-0cf670493692@suse.cz> <4e3df681-9523-4781-d324-9a6e230f495a@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 08:42:23 -0000 This is a multi-part message in MIME format. --------------a2kltVjOVLd0fSANGCCw9178 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/30/22 08:43, Rui Ueyama wrote: > Thanks Martin for creating this patch. You're welcome. > > Here is a preliminary change for the mold side: https://github.com/rui314/mold/commit/9ad49d1c556bc963d06cca8233535183490de605 > > Overall the API is looking fine, Good then! > though it is not clear what kind of value is expected as a linker version. A linker version is not a single unsigned integer but something like "1.3.0". Something like "1.3.0-rc2" can also be a linker version. So I don't think we can represent a linker version as a single integer. Well, you can use the same what we use GCC_VERSION (plugin_version): 1000 * MAJOR + MINOR Let me adjust the documentation of the API. Richi: May I install the patch? Thanks, Martin > > On Mon, Jun 20, 2022 at 9:01 PM Martin Liška > wrote: > > On 6/20/22 11:35, Richard Biener wrote: > > I think this is OK.  Can we get buy-in from mold people? > > Sure, I've just pinged Rui: > https://github.com/rui314/mold/issues/454#issuecomment-1160419030 > > Martin > --------------a2kltVjOVLd0fSANGCCw9178 Content-Type: text/x-patch; charset=UTF-8; name="0001-lto-plugin-implement-LDPT_GET_API_VERSION.patch" Content-Disposition: attachment; filename="0001-lto-plugin-implement-LDPT_GET_API_VERSION.patch" Content-Transfer-Encoding: base64 RnJvbSBmMDRiMTg3MjQwYjc4NmE4NjgzNzdjMzg1NDExMzU5OGJhNjljZTFiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBNb24sIDE2IE1heSAyMDIyIDE0OjAxOjUyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g bHRvLXBsdWdpbjogaW1wbGVtZW50IExEUFRfR0VUX0FQSV9WRVJTSU9OCgppbmNsdWRlL0No YW5nZUxvZzoKCgkqIHBsdWdpbi1hcGkuaCAoZW51bSBsaW5rZXJfYXBpX3ZlcnNpb24pOiBO ZXcgZW51bS4KCShsZF9wbHVnaW5fZ2V0X2FwaV92ZXJzaW9uKTogTmV3LgoJKGVudW0gbGRf cGx1Z2luX3RhZyk6IEFkZCBMRFBUX0dFVF9BUElfVkVSU0lPTi4KCShzdHJ1Y3QgbGRfcGx1 Z2luX3R2KTogQWRkIHR2X2dldF9hcGlfdmVyc2lvbi4KCmx0by1wbHVnaW4vQ2hhbmdlTG9n OgoKCSogbHRvLXBsdWdpbi5jIChuZWdvdGlhdGVfYXBpX3ZlcnNpb24pOiBOZXcuCgkob25s b2FkKTogTmVnb3RpYXRlIEFQSSB2ZXJzaW9uLgotLS0KIGluY2x1ZGUvcGx1Z2luLWFwaS5o ICAgIHwgMzMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiBsdG8tcGx1Z2lu L2x0by1wbHVnaW4uYyB8IDM4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrCiAyIGZpbGVzIGNoYW5nZWQsIDcxIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9p bmNsdWRlL3BsdWdpbi1hcGkuaCBiL2luY2x1ZGUvcGx1Z2luLWFwaS5oCmluZGV4IDhhZWJl MmZmMjY3Li5mNjQwMjE1MTQ3MyAxMDA2NDQKLS0tIGEvaW5jbHVkZS9wbHVnaW4tYXBpLmgK KysrIGIvaW5jbHVkZS9wbHVnaW4tYXBpLmgKQEAgLTQ4Myw2ICs0ODMsMzcgQEAgZW51bSBs ZF9wbHVnaW5fbGV2ZWwKICAgTERQTF9GQVRBTAogfTsKIAorLyogQ29udHJhY3QgYmV0d2Vl biBhIHBsdWctaW4gYW5kIGEgbGlua2VyLiAgKi8KKworZW51bSBsaW5rZXJfYXBpX3ZlcnNp b24KK3sKKyAgIC8qIFRoZSBsaW5rZXIvcGx1Z2luIGRvIG5vdCBpbXBsZW1lbnQgYW55IG9m IHRoZSBBUEkgbGV2ZWxzIGJlbG93LCB0aGUgQVBJCisgICAgICAgaXMgZGV0ZXJtaW5lZCBz b2xlbHkgdmlhIHRoZSB0cmFuc2ZlciB2ZWN0b3IuICAqLworICAgTEFQSV9VTlNQRUNJRklF RCA9IDAsCisKKyAgIC8qIEFQSSBsZXZlbCB2MS4gIFRoZSBsaW5rZXIgcHJvdmlkZXMgZ2V0 X3N5bWJvbHNfdjMsIGFkZF9zeW1ib2xzX3YyLAorICAgICAgdGhlIHBsdWdpbiB3aWxsIHVz ZSB0aGF0IGFuZCBub3QgYW55IGxvd2VyIHZlcnNpb25zLgorICAgICAgY2xhaW1fZmlsZSBp cyB0aHJlYWQtc2FmZSBvbiB0aGUgcGx1Z2luIHNpZGUgYW5kCisgICAgICBhZGRfc3ltYm9s cyBvbiB0aGUgbGlua2VyIHNpZGUuICAqLworICAgTEFQSV9WMSA9IDEKK307CisKKy8qIFRo ZSBsaW5rZXIncyBpbnRlcmZhY2UgZm9yIEFQSSB2ZXJzaW9uIG5lZ290aWF0aW9uLiAgQSBw bHVnLWluIGNhbGxzCisgIHRoZSBmdW5jdGlvbiAod2l0aCBpdHMgSURFTlRJRklFUiBhbmQg VkVSU0lPTiksIHBsdXMgbWluaW1hbCBhbmQgbWF4aW1hbAorICB2ZXJzaW9uIG9mIGxpbmtl cl9hcGlfdmVyc2lvbiBpcyBwcm92aWRlZC4gIExpbmtlciB0aGVuIHJldHVybnMgc2VsZWN0 ZWQKKyAgQVBJIHZlcnNpb24gYW5kIHByb3ZpZGVzIGl0cyBJREVOVElGSUVSIGFuZCBWRVJT SU9OLgorICBCb3RoIFBMVUdJTl9WRVJTSU9OIGFuZCBMSU5LRVJfVkVSU0lPTiBhcmUgaW4g dGhlIGZvbGxvd2luZyBmb3JtYXQ6CisgIDEwMDAgKiBNQUpPUiArIE1JTk9SLgorICBJZGVu dGlmaWVyIHBvaW50ZXJzIHJlbWFpbiB2YWxpZCBhcyBsb25nIGFzIHRoZSBwbHVnaW4gaXMg bG9hZGVkLiAgKi8KKwordHlwZWRlZgorZW51bSBsaW5rZXJfYXBpX3ZlcnNpb24KKygqbGRf cGx1Z2luX2dldF9hcGlfdmVyc2lvbikgKGNvbnN0IGNoYXIgKnBsdWdpbl9pZGVudGlmaWVy LCB1bnNpZ25lZCBwbHVnaW5fdmVyc2lvbiwKKwkJCSAgICAgIGVudW0gbGlua2VyX2FwaV92 ZXJzaW9uIG1pbmltYWxfYXBpX3N1cHBvcnRlZCwKKwkJCSAgICAgIGVudW0gbGlua2VyX2Fw aV92ZXJzaW9uIG1heGltYWxfYXBpX3N1cHBvcnRlZCwKKwkJCSAgICAgIGNvbnN0IGNoYXIg KipsaW5rZXJfaWRlbnRpZmllciwKKwkJCSAgICAgIHVuc2lnbmVkICpsaW5rZXJfdmVyc2lv bik7CisKIC8qIFZhbHVlcyBmb3IgdGhlIHR2X3RhZyBmaWVsZCBvZiB0aGUgdHJhbnNmZXIg dmVjdG9yLiAgKi8KIAogZW51bSBsZF9wbHVnaW5fdGFnCkBAIC01MjEsNiArNTUyLDcgQEAg ZW51bSBsZF9wbHVnaW5fdGFnCiAgIExEUFRfUkVHSVNURVJfTkVXX0lOUFVUX0hPT0ssCiAg IExEUFRfR0VUX1dSQVBfU1lNQk9MUywKICAgTERQVF9BRERfU1lNQk9MU19WMiwKKyAgTERQ VF9HRVRfQVBJX1ZFUlNJT04sCiB9OwogCiAvKiBUaGUgcGx1Z2luIHRyYW5zZmVyIHZlY3Rv ci4gICovCkBAIC01NTYsNiArNTg4LDcgQEAgc3RydWN0IGxkX3BsdWdpbl90dgogICAgIGxk X3BsdWdpbl9nZXRfaW5wdXRfc2VjdGlvbl9zaXplIHR2X2dldF9pbnB1dF9zZWN0aW9uX3Np emU7CiAgICAgbGRfcGx1Z2luX3JlZ2lzdGVyX25ld19pbnB1dCB0dl9yZWdpc3Rlcl9uZXdf aW5wdXQ7CiAgICAgbGRfcGx1Z2luX2dldF93cmFwX3N5bWJvbHMgdHZfZ2V0X3dyYXBfc3lt Ym9sczsKKyAgICBsZF9wbHVnaW5fZ2V0X2FwaV92ZXJzaW9uIHR2X2dldF9hcGlfdmVyc2lv bjsKICAgfSB0dl91OwogfTsKIApkaWZmIC0tZ2l0IGEvbHRvLXBsdWdpbi9sdG8tcGx1Z2lu LmMgYi9sdG8tcGx1Z2luL2x0by1wbHVnaW4uYwppbmRleCA2MzVlMTI2OTQ2Yi4uMDZlMzIx OWRlNzUgMTAwNjQ0Ci0tLSBhL2x0by1wbHVnaW4vbHRvLXBsdWdpbi5jCisrKyBiL2x0by1w bHVnaW4vbHRvLXBsdWdpbi5jCkBAIC03NCw2ICs3NCw3IEBAIGFsb25nIHdpdGggdGhpcyBw cm9ncmFtOyBzZWUgdGhlIGZpbGUgQ09QWUlORzMuICBJZiBub3Qgc2VlCiAjaW5jbHVkZSAi Li4vZ2NjL2x0by9jb21tb24uaCIKICNpbmNsdWRlICJzaW1wbGUtb2JqZWN0LmgiCiAjaW5j bHVkZSAicGx1Z2luLWFwaS5oIgorI2luY2x1ZGUgImFuc2lkZWNsLmgiCiAKIC8qIFdlIG5l ZWQgdG8gdXNlIEk2NCBpbnN0ZWFkIG9mIGxsIHdpZHRoLXNwZWNpZmllciBvbiBuYXRpdmUg V2luZG93cy4KICAgIFRoZSByZWFzb24gZm9yIHRoaXMgaXMgdGhhdCBvbGRlciBNUy1ydW50 aW1lcyBkb24ndCBzdXBwb3J0IHRoZSBsbC4gICovCkBAIC0xNzQsNiArMTc1LDEwIEBAIHN0 YXRpYyBsZF9wbHVnaW5fYWRkX2lucHV0X2ZpbGUgYWRkX2lucHV0X2ZpbGU7CiBzdGF0aWMg bGRfcGx1Z2luX2FkZF9pbnB1dF9saWJyYXJ5IGFkZF9pbnB1dF9saWJyYXJ5Owogc3RhdGlj IGxkX3BsdWdpbl9tZXNzYWdlIG1lc3NhZ2U7CiBzdGF0aWMgbGRfcGx1Z2luX2FkZF9zeW1i b2xzIGFkZF9zeW1ib2xzLCBhZGRfc3ltYm9sc192MjsKK3N0YXRpYyBsZF9wbHVnaW5fZ2V0 X2FwaV92ZXJzaW9uIGdldF9hcGlfdmVyc2lvbjsKKworLyogQnkgZGVmYXVsdCwgdXNlIHZl cnNpb24gTEFQSV9VTlNQRUNJRklFRCBpZiB0aGVyZSBpcyBub3QgbmVnb3RpYXRpb24uICAq Lworc3RhdGljIGVudW0gbGlua2VyX2FwaV92ZXJzaW9uIGFwaV92ZXJzaW9uID0gTEFQSV9V TlNQRUNJRklFRDsKIAogc3RhdGljIHN0cnVjdCBwbHVnaW5fZmlsZV9pbmZvICpjbGFpbWVk X2ZpbGVzID0gTlVMTDsKIHN0YXRpYyB1bnNpZ25lZCBpbnQgbnVtX2NsYWltZWRfZmlsZXMg PSAwOwpAQCAtMTQyMSw2ICsxNDI2LDMzIEBAIHByb2Nlc3Nfb3B0aW9uIChjb25zdCBjaGFy ICpvcHRpb24pCiAgIHZlcmJvc2UgPSB2ZXJib3NlIHx8IGRlYnVnOwogfQogCisvKiBOZWdv dGlhdGUgbGlua2VyIEFQSSB2ZXJzaW9uLiAgKi8KKworc3RhdGljIHZvaWQKK25lZ290aWF0 ZV9hcGlfdmVyc2lvbiAodm9pZCkKK3sKKyAgY29uc3QgY2hhciAqbGlua2VyX2lkZW50aWZp ZXI7CisgIHVuc2lnbmVkIGxpbmtlcl92ZXJzaW9uOworCisgIGFwaV92ZXJzaW9uID0gZ2V0 X2FwaV92ZXJzaW9uICgiR0NDIiwgR0NDX1ZFUlNJT04sIExBUElfVU5TUEVDSUZJRUQsCisJ CQkJIExBUElfVjEsICZsaW5rZXJfaWRlbnRpZmllciwgJmxpbmtlcl92ZXJzaW9uKTsKKwor ICBzd2l0Y2ggKGFwaV92ZXJzaW9uKQorICAgIHsKKyAgICBjYXNlIExBUElfVU5TUEVDSUZJ RUQ6CisgICAgICBicmVhazsKKyAgICBjYXNlIExBUElfVjE6CisgICAgICBjaGVjayAoZ2V0 X3N5bWJvbHNfdjMsIExEUExfRkFUQUwsCisJICAgICAiZ2V0X3N5bWJvbHNfdjMgcmVxdWly ZWQgZm9yIEFQSSB2ZXJzaW9uIDEiKTsKKyAgICAgIGNoZWNrIChhZGRfc3ltYm9sc192Miwg TERQTF9GQVRBTCwKKwkgICAgICJhZGRfc3ltYm9sc192MiByZXF1aXJlZCBmb3IgQVBJIHZl cnNpb24gMSIpOworICAgICAgYnJlYWs7CisgICAgZGVmYXVsdDoKKyAgICAgIGZwcmludGYg KHN0ZGVyciwgInVuc3VwcG9ydGVkIEFQSSB2ZXJzaW9uXG4iKTsKKyAgICAgIGFib3J0ICgp OworICAgIH0KK30KKwogLyogQ2FsbGVkIGJ5IGEgbGlua2VyIGFmdGVyIGxvYWRpbmcgdGhl IHBsdWdpbi4gVFYgaXMgdGhlIHRyYW5zZmVyIHZlY3Rvci4gKi8KIAogZW51bSBsZF9wbHVn aW5fc3RhdHVzCkBAIC0xNDg3LDEyICsxNTE5LDE4IEBAIG9ubG9hZCAoc3RydWN0IGxkX3Bs dWdpbl90diAqdHYpCiAJICAvKiBXZSBvbmx5IHVzZSB0aGlzIHRvIG1ha2UgdXNlci1mcmll bmRseSB0ZW1wIGZpbGUgbmFtZXMuICAqLwogCSAgbGlua19vdXRwdXRfbmFtZSA9IHAtPnR2 X3UudHZfc3RyaW5nOwogCSAgYnJlYWs7CisJY2FzZSBMRFBUX0dFVF9BUElfVkVSU0lPTjoK KwkgIGdldF9hcGlfdmVyc2lvbiA9IHAtPnR2X3UudHZfZ2V0X2FwaV92ZXJzaW9uOworCSAg YnJlYWs7CiAJZGVmYXVsdDoKIAkgIGJyZWFrOwogCX0KICAgICAgIHArKzsKICAgICB9CiAK KyAgaWYgKGdldF9hcGlfdmVyc2lvbikKKyAgICBuZWdvdGlhdGVfYXBpX3ZlcnNpb24gKCk7 CisKICAgY2hlY2sgKHJlZ2lzdGVyX2NsYWltX2ZpbGUsIExEUExfRkFUQUwsICJyZWdpc3Rl cl9jbGFpbV9maWxlIG5vdCBmb3VuZCIpOwogICBjaGVjayAoYWRkX3N5bWJvbHMsIExEUExf RkFUQUwsICJhZGRfc3ltYm9scyBub3QgZm91bmQiKTsKICAgc3RhdHVzID0gcmVnaXN0ZXJf Y2xhaW1fZmlsZSAoY2xhaW1fZmlsZV9oYW5kbGVyKTsKLS0gCjIuMzYuMQoK --------------a2kltVjOVLd0fSANGCCw9178--