From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Xfqi=5I=foss.arm.com=Richard.Earnshaw@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id 7B3EB3858C83
	for <gcc-patches@gcc.gnu.org>; Wed, 11 Jan 2023 10:48:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B3EB3858C83
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B1D6FEC;
	Wed, 11 Jan 2023 02:49:39 -0800 (PST)
Received: from [10.57.37.91] (unknown [10.57.37.91])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6EC3D3F587;
	Wed, 11 Jan 2023 02:48:56 -0800 (PST)
Message-ID: <3dc63625-fe1a-99e6-b578-78714adb25e2@foss.arm.com>
Date: Wed, 11 Jan 2023 10:48:55 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 1/15 V2] arm: Make mbranch-protection opts parsing common
 to AArch32/64
Content-Language: en-GB
To: Andrea Corallo <andrea.corallo@arm.com>,
 Andrea Corallo via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>, nd <nd@arm.com>
References: <gkrk07dczbq.fsf@arm.com> <gkrfsi1cx4c.fsf@arm.com>
 <gkr8rizz7xv.fsf_-_@arm.com>
From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
In-Reply-To: <gkr8rizz7xv.fsf_-_@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3489.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>



On 22/12/2022 17:04, Andrea Corallo via Gcc-patches wrote:
> Hi all,
> 
> respinning this as a rebase was necessary, also now is setting
> 'aarch_enable_bti' to zero as default for arm as suggested during the
> review of 12/15.
> 
> Best Regards
> 
>    Andrea
> 
> 

gcc/ChangeLog:

	* common/config/aarch64/aarch64-common.cc: Include aarch-common.h.
	(all_architectures): Fix comment.
	(aarch64_parse_extension): Rename return type, enum value names.
	* config/aarch64/aarch64-c.cc (aarch64_update_cpp_builtins): Rename
	factored out aarch_ra_sign_scope and aarch_ra_sign_key variables.
	Also rename corresponding enum values.
	* config/aarch64/aarch64-opts.h (aarch64_function_type): Factor
	out aarch64_function_type and move it to common code as
	aarch_function_type in aarch-common.h.
	* config/aarch64/aarch64-protos.h: Include common types header,
	move out types aarch64_parse_opt_result and aarch64_key_type to
	aarch-common.h
	* config/aarch64/aarch64.cc: Move mbranch-protection parsing types
	and functions out into aarch-common.h and aarch-common.cc.  Fix up
	all the name changes resulting from the move.
	* config/aarch64/aarch64.md: Fix up aarch64_ra_sign_key type name change
	and enum value.
	* config/aarch64/aarch64.opt: Include aarch-common.h to import
	type move.  Fix up name changes from factoring out common code and
	data.
	* config/arm/aarch-common-protos.h: Export factored out routines to both
	backends.
	* config/arm/aarch-common.cc: Include newly factored out types.
	Move all mbranch-protection code and data structures from
	aarch64.cc.
	* config/arm/aarch-common.h: New header that declares types shared
	between aarch32 and aarch64 backends.
	* config/arm/arm-protos.h: Declare types and variables that are
	made common to aarch64 and aarch32 backends - aarch_ra_sign_key,
	aarch_ra_sign_scope and aarch_enable_bti.

I don't see an entry for config/arm/arm.opt.  Please make sure you 
patches pass "git gcc-verify".

Otherwise, this is OK.

R.