From: Andrew Stubbs <ams@baylibre.com>
To: Tobias Burnus <tburnus@baylibre.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch][v2] gcn/mkoffload.cc: Fix SRAM_ECC and XNACK handling [PR111966]
Date: Mon, 29 Jan 2024 09:50:34 +0000 [thread overview]
Message-ID: <3dfe519b-5657-4091-8831-c206e1b47419@baylibre.com> (raw)
In-Reply-To: <9270c731-05b8-410b-b33b-0c6764747f5f@baylibre.com>
On 25/01/2024 15:11, Tobias Burnus wrote:
> Updated patch enclosed.
>
> Tobias Burnus wrote:
>> I have now run the attached script and the result running yesterday's
>> build with both my patch and your patch applied.
>
> (And the now committed gcn-hsa.h patch)
>
> Now the result with the testscript is:
>
> * fiji, gfx1030, gfx1100 work, except for "error: '-mxnack=on' is
> incompatible with ..."
> (and link errors for fiji as libgomp is not build, which makes the
> testing a tad less reliable but should be fine).
>
> * (default)/gfx900/gfx906/gfx908: Works, except for -mxnack=on/any due
> to .target / -mattr= mismatch
>
> * gfx90a: simply works
>
> OK for mainline?
>
> Tobias
>
> PS: For the test script, see previous email in the thread; for the
> output of that script, see attachment.
>
> PPS: I hope I got everything right.
OK.
Andrew
prev parent reply other threads:[~2024-01-29 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 22:12 [patch] " Tobias Burnus
2024-01-25 10:17 ` Andrew Stubbs
2024-01-25 12:06 ` Tobias Burnus
2024-01-25 15:11 ` [patch][v2] " Tobias Burnus
2024-01-29 9:50 ` Andrew Stubbs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dfe519b-5657-4091-8831-c206e1b47419@baylibre.com \
--to=ams@baylibre.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tburnus@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).