* testsuite: avoid no-stack-protector-attr-3 fail on mips*-*-*
@ 2021-06-22 7:07 Xi Ruoyao
2021-06-22 9:44 ` [PATCH resend] " Xi Ruoyao
0 siblings, 1 reply; 4+ messages in thread
From: Xi Ruoyao @ 2021-06-22 7:07 UTC (permalink / raw)
To: gcc-patches; +Cc: Matthew Fortune, xry111
On MIPS a call to __stack_chk_fail needs an additional .reloc pseudo-op,
so "stack_chk_fail" will appear two times.
gcc/testsuite/
* no-stack-protector-attr-3.C (dg-final): Adjust for MIPS.
---
gcc/testsuite/g++.dg/no-stack-protector-attr-3.C | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/testsuite/g++.dg/no-stack-protector-attr-3.C b/gcc/testsuite/g++.dg/no-stack-protector-attr-3.C
index 56a4e74da50..76a5ec08681 100644
--- a/gcc/testsuite/g++.dg/no-stack-protector-attr-3.C
+++ b/gcc/testsuite/g++.dg/no-stack-protector-attr-3.C
@@ -20,4 +20,5 @@ int __attribute__((stack_protect)) bar()
return 0;
}
-/* { dg-final { scan-assembler-times "stack_chk_fail" 1 } } */
+/* { dg-final { scan-assembler-times "stack_chk_fail" 1 { target { ! mips*-*-* } } } }*/
+/* { dg-final { scan-assembler-times "stack_chk_fail" 2 { target { mips*-*-* } } } }*/
--
2.32.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH resend] testsuite: avoid no-stack-protector-attr-3 fail on mips*-*-*
2021-06-22 7:07 testsuite: avoid no-stack-protector-attr-3 fail on mips*-*-* Xi Ruoyao
@ 2021-06-22 9:44 ` Xi Ruoyao
2021-06-24 6:05 ` Jeff Law
0 siblings, 1 reply; 4+ messages in thread
From: Xi Ruoyao @ 2021-06-22 9:44 UTC (permalink / raw)
To: gcc-patches; +Cc: Matthew Fortune, xry111
[Resend because the original subject missed "[PATCH]" and the path in
ChangeLog is wrong.]
On MIPS a call to __stack_chk_fail needs an additional .reloc pseudo-op,
so "stack_chk_fail" will appear two times.
gcc/testsuite/
* g++.dg/no-stack-protector-attr-3.C (dg-final): Adjust for
MIPS.
---
gcc/testsuite/g++.dg/no-stack-protector-attr-3.C | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/testsuite/g++.dg/no-stack-protector-attr-3.C b/gcc/testsuite/g++.dg/no-stack-protector-attr-3.C
index 56a4e74da50..76a5ec08681 100644
--- a/gcc/testsuite/g++.dg/no-stack-protector-attr-3.C
+++ b/gcc/testsuite/g++.dg/no-stack-protector-attr-3.C
@@ -20,4 +20,5 @@ int __attribute__((stack_protect)) bar()
return 0;
}
-/* { dg-final { scan-assembler-times "stack_chk_fail" 1 } } */
+/* { dg-final { scan-assembler-times "stack_chk_fail" 1 { target { ! mips*-*-* } } } }*/
+/* { dg-final { scan-assembler-times "stack_chk_fail" 2 { target { mips*-*-* } } } }*/
--
2.32.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH resend] testsuite: avoid no-stack-protector-attr-3 fail on mips*-*-*
2021-06-22 9:44 ` [PATCH resend] " Xi Ruoyao
@ 2021-06-24 6:05 ` Jeff Law
2021-06-25 2:53 ` Xi Ruoyao
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Law @ 2021-06-24 6:05 UTC (permalink / raw)
To: xry111, gcc-patches; +Cc: Matthew Fortune
On 6/22/2021 3:44 AM, Xi Ruoyao via Gcc-patches wrote:
> [Resend because the original subject missed "[PATCH]" and the path in
> ChangeLog is wrong.]
>
> On MIPS a call to __stack_chk_fail needs an additional .reloc pseudo-op,
> so "stack_chk_fail" will appear two times.
>
> gcc/testsuite/
>
> * g++.dg/no-stack-protector-attr-3.C (dg-final): Adjust for
> MIPS.
OK. Seems like a good patch for you to test your commit privs with once
the infrastructure overseers have set up your account
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH resend] testsuite: avoid no-stack-protector-attr-3 fail on mips*-*-*
2021-06-24 6:05 ` Jeff Law
@ 2021-06-25 2:53 ` Xi Ruoyao
0 siblings, 0 replies; 4+ messages in thread
From: Xi Ruoyao @ 2021-06-25 2:53 UTC (permalink / raw)
To: Jeff Law, gcc-patches; +Cc: Matthew Fortune
On Thu, 2021-06-24 at 00:05 -0600, Jeff Law wrote:
>
>
> On 6/22/2021 3:44 AM, Xi Ruoyao via Gcc-patches wrote:
> > [Resend because the original subject missed "[PATCH]" and the path
> > in
> > ChangeLog is wrong.]
> >
> > On MIPS a call to __stack_chk_fail needs an additional .reloc
> > pseudo-op,
> > so "stack_chk_fail" will appear two times.
> >
> > gcc/testsuite/
> >
> > * g++.dg/no-stack-protector-attr-3.C (dg-final): Adjust for
> > MIPS.
> OK. Seems like a good patch for you to test your commit privs with
> once
> the infrastructure overseers have set up your account
>
> Jeff
>
Pushed into trunk as 607c558804f7.
--
Xi Ruoyao <xry111@mengyan1223.wang>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-25 2:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 7:07 testsuite: avoid no-stack-protector-attr-3 fail on mips*-*-* Xi Ruoyao
2021-06-22 9:44 ` [PATCH resend] " Xi Ruoyao
2021-06-24 6:05 ` Jeff Law
2021-06-25 2:53 ` Xi Ruoyao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).