From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Segher Boessenkool <segher@kernel.crashing.org>,
Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] longlong.h: Do no use asm input cast for clang
Date: Mon, 12 Dec 2022 14:10:16 -0300 [thread overview]
Message-ID: <3e4bc189-7d73-f875-b425-61dde1a86e34@linaro.org> (raw)
In-Reply-To: <20221130232456.GT25951@gate.crashing.org>
On 30/11/22 20:24, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Nov 30, 2022 at 03:16:25PM -0300, Adhemerval Zanella via Gcc-patches wrote:
>> clang by default rejects the input casts with:
>>
>> error: invalid use of a cast in a inline asm context requiring an
>> lvalue: remove the cast or build with -fheinous-gnu-extensions
>>
>> And even with -fheinous-gnu-extensions clang still throws an warning
>> and also states that this option might be removed in the future.
>> For gcc the cast are still useful somewhat [1], so just remove it
>> clang is used.
>
> This is one of the things in inline asm that is tightly tied to GCC
> internals. You should emulate GCC's behaviour faithfully if you want
> to claim you implement the inline asm GNU C extension.
Agree, that's why I just make it a no-op for clang which indicates that
it does not seem much use of this extension.
> I understand that the casts should be no-ops on the asm side (maybe they
> change the sign) and they are present as type-checking. Can we implement
> this type-checking in a different (portable) way? I think the macro you use
> should be named like __asm_output_check_type (..) or so to indicate the
> intended purpose.
I do not think trying to leverage it on clang side would yield much, it
seems that it really does not want to support this extension. I am not
sure we can really make it portable, best option I can think of would to
add a mix of __builtin_classify_type and typeof prior asm call (we do
something similar to powerp64 syscall code on glibc), although it would
still require some gcc specific builtins.
I am open for ideas, since to get this header to be clang-compatible on
glibc it requires to get it first on gcc.
>
>> --- a/include/ChangeLog
>> +++ b/include/ChangeLog
>
> That should not be part of the patch? Changelog entries should be
> verbatim in the message you send.
>
> The size of this patch already makes clear this is a bad idea, imo.
> This code is already hard enough to read.
Indeed, I forgot that CL entries were not part of the commit.
next prev parent reply other threads:[~2022-12-12 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 18:16 Adhemerval Zanella
2022-11-30 23:24 ` Segher Boessenkool
2022-12-01 7:26 ` Richard Biener
2022-12-12 18:15 ` Segher Boessenkool
2022-12-12 17:10 ` Adhemerval Zanella Netto [this message]
2022-12-12 23:52 ` Segher Boessenkool
2023-01-10 12:26 ` Adhemerval Zanella Netto
2023-01-10 13:20 ` Segher Boessenkool
2023-01-10 14:35 ` Andreas Schwab
2023-01-10 18:20 ` Segher Boessenkool
2023-01-10 20:33 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e4bc189-7d73-f875-b425-61dde1a86e34@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).