* [PATCH][pushed] gcov: update documentation entry about string format
@ 2021-06-17 9:39 Martin Liška
0 siblings, 0 replies; 3+ messages in thread
From: Martin Liška @ 2021-06-17 9:39 UTC (permalink / raw)
To: gcc-patches
gcc/ChangeLog:
* gcov-io.h: Update documentation entry about string format.
---
gcc/gcov-io.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/gcc/gcov-io.h b/gcc/gcov-io.h
index f7584eb9679..ff92afe63df 100644
--- a/gcc/gcov-io.h
+++ b/gcc/gcov-io.h
@@ -42,15 +42,14 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
Numbers are recorded in the 32 bit unsigned binary form of the
endianness of the machine generating the file. 64 bit numbers are
- stored as two 32 bit numbers, the low part first. Strings are
- padded with 1 to 4 NUL bytes, to bring the length up to a multiple
- of 4. The number of 4 bytes is stored, followed by the padded
+ stored as two 32 bit numbers, the low part first.
+ The number of bytes is stored, followed by the
string. Zero length and NULL strings are simply stored as a length
of zero (they have no trailing NUL or padding).
int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3
int64: int32:low int32:high
- string: int32:0 | int32:length char* char:0 padding
+ string: int32:0 | int32:length char* char:0
padding: | char:0 | char:0 char:0 | char:0 char:0 char:0
item: int32 | int64 | string
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][pushed] gcov: update documentation entry about string format
2021-06-21 19:27 Eugene Rozenfeld
@ 2021-06-22 6:50 ` Martin Liška
0 siblings, 0 replies; 3+ messages in thread
From: Martin Liška @ 2021-06-22 6:50 UTC (permalink / raw)
To: Eugene Rozenfeld, gcc-patches
On 6/21/21 9:27 PM, Eugene Rozenfeld wrote:
> Thank you for updating the documentation Martin.
I thank you.
>
> The following line can now be removed:
>
> padding: | char:0 | char:0 char:0 | char:0 char:0 char:0
Sure, I've just done that.
Martin
>
> Eugene
>
> -----Original Message-----
> From: Gcc-patches <gcc-patches-bounces+erozen=microsoft.com@gcc.gnu.org> On Behalf Of Martin Liška
> Sent: Thursday, June 17, 2021 2:40 AM
> To: gcc-patches@gcc.gnu.org
> Subject: [EXTERNAL] [PATCH][pushed] gcov: update documentation entry about string format
>
> gcc/ChangeLog:
>
> * gcov-io.h: Update documentation entry about string format.
> ---
> gcc/gcov-io.h | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/gcc/gcov-io.h b/gcc/gcov-io.h index f7584eb9679..ff92afe63df 100644
> --- a/gcc/gcov-io.h
> +++ b/gcc/gcov-io.h
> @@ -42,15 +42,14 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
>
> Numbers are recorded in the 32 bit unsigned binary form of the
> endianness of the machine generating the file. 64 bit numbers are
> - stored as two 32 bit numbers, the low part first. Strings are
> - padded with 1 to 4 NUL bytes, to bring the length up to a multiple
> - of 4. The number of 4 bytes is stored, followed by the padded
> + stored as two 32 bit numbers, the low part first.
> + The number of bytes is stored, followed by the
> string. Zero length and NULL strings are simply stored as a length
> of zero (they have no trailing NUL or padding).
>
> int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3
> int64: int32:low int32:high
> - string: int32:0 | int32:length char* char:0 padding
> + string: int32:0 | int32:length char* char:0
> padding: | char:0 | char:0 char:0 | char:0 char:0 char:0
> item: int32 | int64 | string
>
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH][pushed] gcov: update documentation entry about string format
@ 2021-06-21 19:27 Eugene Rozenfeld
2021-06-22 6:50 ` Martin Liška
0 siblings, 1 reply; 3+ messages in thread
From: Eugene Rozenfeld @ 2021-06-21 19:27 UTC (permalink / raw)
To: Martin Liška, gcc-patches
Thank you for updating the documentation Martin.
The following line can now be removed:
padding: | char:0 | char:0 char:0 | char:0 char:0 char:0
Eugene
-----Original Message-----
From: Gcc-patches <gcc-patches-bounces+erozen=microsoft.com@gcc.gnu.org> On Behalf Of Martin Liška
Sent: Thursday, June 17, 2021 2:40 AM
To: gcc-patches@gcc.gnu.org
Subject: [EXTERNAL] [PATCH][pushed] gcov: update documentation entry about string format
gcc/ChangeLog:
* gcov-io.h: Update documentation entry about string format.
---
gcc/gcov-io.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/gcc/gcov-io.h b/gcc/gcov-io.h index f7584eb9679..ff92afe63df 100644
--- a/gcc/gcov-io.h
+++ b/gcc/gcov-io.h
@@ -42,15 +42,14 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
Numbers are recorded in the 32 bit unsigned binary form of the
endianness of the machine generating the file. 64 bit numbers are
- stored as two 32 bit numbers, the low part first. Strings are
- padded with 1 to 4 NUL bytes, to bring the length up to a multiple
- of 4. The number of 4 bytes is stored, followed by the padded
+ stored as two 32 bit numbers, the low part first.
+ The number of bytes is stored, followed by the
string. Zero length and NULL strings are simply stored as a length
of zero (they have no trailing NUL or padding).
int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3
int64: int32:low int32:high
- string: int32:0 | int32:length char* char:0 padding
+ string: int32:0 | int32:length char* char:0
padding: | char:0 | char:0 char:0 | char:0 char:0 char:0
item: int32 | int64 | string
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-22 6:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 9:39 [PATCH][pushed] gcov: update documentation entry about string format Martin Liška
2021-06-21 19:27 Eugene Rozenfeld
2021-06-22 6:50 ` Martin Liška
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).